[Buildroot] [PATCH] package/tstools: fix build w/ gcc-15

[Buildroot] [PATCH] package/tstools: fix build w/ gcc-15

[Peter Korsgaard]

GCC-15 defaults to C23, which changes the meaning of an empty parameter
list:

https://gcc.gnu.org/gcc-15/porting_to.html#c23-fn-decls-without-parameters

Leading to a build failure:

tsserve.c: In function ‘set_child_exit_handler’:
tsserve.c:2988:21: error: assignment to ‘__sighandler_t’ {aka ‘void (*)(int)’} from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]
 2988 |   action.sa_handler = on_child_exit;

Add a patch from an upstream PR to fix that.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 .../tstools/0002-fix-build-with-gcc-15.patch  | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 package/tstools/0002-fix-build-with-gcc-15.patch

diff --git a/package/tstools/0002-fix-build-with-gcc-15.patch b/package/tstools/0002-fix-build-with-gcc-15.patch
new file mode 100644
index 0000000000..193bad43b8
--- /dev/null
+++ b/package/tstools/0002-fix-build-with-gcc-15.patch
@@ -0,0 +1,27 @@
+From a1f2a71b286135d89865bb0332cbe3db59cea300 Mon Sep 17 00:00:00 2001
+From: Rudi Heitbaum <rudi@heitbaum.com>
+Date: Mon, 9 Dec 2024 16:57:53 +1100
+Subject: [PATCH] fix build with gcc-15
+
+Upstream: https://github.com/kynesim/tstools/pull/44
+Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
+---
+ tsserve.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tsserve.c b/tsserve.c
+index d81042e..253ba0c 100644
+--- a/tsserve.c
++++ b/tsserve.c
+@@ -2958,7 +2958,7 @@ static void set_child_exit_handler();
+ /*
+  * Signal handler - catch children and stop them becoming zombies
+  */
+-static void on_child_exit()
++static void on_child_exit(int signum)
+ {
+ #if 0
+   print_msg("sighandler: starting\n");
+-- 
+2.39.5
+
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH] package/tstools: fix build w/ gcc-15

[Peter Korsgaard]

GCC-15 defaults to C23, which changes the meaning of an empty parameter
list:

https://gcc.gnu.org/gcc-15/porting_to.html#c23-fn-decls-without-parameters

Leading to a build failure:

tsserve.c: In function ‘set_child_exit_handler’:
tsserve.c:2988:21: error: assignment to ‘__sighandler_t’ {aka ‘void (*)(int)’} from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]
 2988 |   action.sa_handler = on_child_exit;

Add a patch from an upstream PR to fix that.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 .../tstools/0002-fix-build-with-gcc-15.patch  | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 package/tstools/0002-fix-build-with-gcc-15.patch

diff --git a/package/tstools/0002-fix-build-with-gcc-15.patch b/package/tstools/0002-fix-build-with-gcc-15.patch
new file mode 100644
index 0000000000..193bad43b8
--- /dev/null
+++ b/package/tstools/0002-fix-build-with-gcc-15.patch
@@ -0,0 +1,27 @@
+From a1f2a71b286135d89865bb0332cbe3db59cea300 Mon Sep 17 00:00:00 2001
+From: Rudi Heitbaum <rudi@heitbaum.com>
+Date: Mon, 9 Dec 2024 16:57:53 +1100
+Subject: [PATCH] fix build with gcc-15
+
+Upstream: https://github.com/kynesim/tstools/pull/44
+Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
+---
+ tsserve.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tsserve.c b/tsserve.c
+index d81042e..253ba0c 100644
+--- a/tsserve.c
++++ b/tsserve.c
+@@ -2958,7 +2958,7 @@ static void set_child_exit_handler();
+ /*
+  * Signal handler - catch children and stop them becoming zombies
+  */
+-static void on_child_exit()
++static void on_child_exit(int signum)
+ {
+ #if 0
+   print_msg("sighandler: starting\n");
+-- 
+2.39.5
+
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/tstools: fix build w/ gcc-15

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > GCC-15 defaults to C23, which changes the meaning of an empty parameter
 > list:

 > https://gcc.gnu.org/gcc-15/porting_to.html#c23-fn-decls-without-parameters

 > Leading to a build failure:

 > tsserve.c: In function ‘set_child_exit_handler’:
 > tsserve.c:2988:21: error: assignment to ‘__sighandler_t’ {aka ‘void
 > (*)(int)’} from incompatible pointer type ‘void (*)(void)’
 > [-Wincompatible-pointer-types]
 >  2988 |   action.sa_handler = on_child_exit;

 > Add a patch from an upstream PR to fix that.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/tstools: fix build w/ gcc-15

[Baruch Siach via buildroot]

Hi Peter,

On Sun, Aug 31 2025, Peter Korsgaard wrote:

>>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>
>  > GCC-15 defaults to C23, which changes the meaning of an empty parameter
>  > list:
>
>  > https://gcc.gnu.org/gcc-15/porting_to.html#c23-fn-decls-without-parameters
>
>  > Leading to a build failure:
>
>  > tsserve.c: In function ‘set_child_exit_handler’:
>  > tsserve.c:2988:21: error: assignment to ‘__sighandler_t’ {aka ‘void
>  > (*)(int)’} from incompatible pointer type ‘void (*)(void)’
>  > [-Wincompatible-pointer-types]
>  >  2988 |   action.sa_handler = on_child_exit;
>
>  > Add a patch from an upstream PR to fix that.
>
>  > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>
> Committed, thanks.

This is not in master as of commit c7af01f47a ("package/ipmitool: move
to codeberg").

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/tstools: fix build w/ gcc-15

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 >> > Add a patch from an upstream PR to fix that.
 >> 
 >> > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> 
 >> Committed, thanks.

 > This is not in master as of commit c7af01f47a ("package/ipmitool: move
 > to codeberg").

Ups, fixed now - Thanks!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot