* [PATCH v2 resend] arm: orion: use string choices helper
@ 2025-07-04 2:47 Kuninori Morimoto
2025-07-07 14:56 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2025-07-04 2:47 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Russell King, Sebastian Hesselbarth,
linux-arm-kernel, Andrew Morton
We can use string choices helper, let's use it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v1 -> v2
- add commit message
- add Reviewed-by
arch/arm/plat-orion/gpio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
index ca1bd764cfa5..6f09f65e3d95 100644
--- a/arch/arm/plat-orion/gpio.c
+++ b/arch/arm/plat-orion/gpio.c
@@ -468,14 +468,14 @@ static void orion_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
if (is_out) {
seq_printf(s, " out %s %s\n",
- out & msk ? "hi" : "lo",
+ str_hi_lo(out & msk),
blink & msk ? "(blink )" : "");
continue;
}
seq_printf(s, " in %s (act %s) - IRQ",
- (data_in ^ in_pol) & msk ? "hi" : "lo",
- in_pol & msk ? "lo" : "hi");
+ str_hi_lo((data_in ^ in_pol) & msk),
+ str_lo_hi(in_pol & msk));
if (!((edg_msk | lvl_msk) & msk)) {
seq_puts(s, " disabled\n");
continue;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 resend] arm: orion: use string choices helper
2025-07-04 2:47 [PATCH v2 resend] arm: orion: use string choices helper Kuninori Morimoto
@ 2025-07-07 14:56 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2025-07-07 14:56 UTC (permalink / raw)
To: Kuninori Morimoto, Andrew Lunn, Russell King,
Sebastian Hesselbarth, linux-arm-kernel, Andrew Morton
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> writes:
> We can use string choices helper, let's use it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied on mvebu/arm
Thanks,
Gregory
> ---
> v1 -> v2
> - add commit message
> - add Reviewed-by
>
> arch/arm/plat-orion/gpio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
> index ca1bd764cfa5..6f09f65e3d95 100644
> --- a/arch/arm/plat-orion/gpio.c
> +++ b/arch/arm/plat-orion/gpio.c
> @@ -468,14 +468,14 @@ static void orion_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
>
> if (is_out) {
> seq_printf(s, " out %s %s\n",
> - out & msk ? "hi" : "lo",
> + str_hi_lo(out & msk),
> blink & msk ? "(blink )" : "");
> continue;
> }
>
> seq_printf(s, " in %s (act %s) - IRQ",
> - (data_in ^ in_pol) & msk ? "hi" : "lo",
> - in_pol & msk ? "lo" : "hi");
> + str_hi_lo((data_in ^ in_pol) & msk),
> + str_lo_hi(in_pol & msk));
> if (!((edg_msk | lvl_msk) & msk)) {
> seq_puts(s, " disabled\n");
> continue;
> --
> 2.43.0
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-07 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-04 2:47 [PATCH v2 resend] arm: orion: use string choices helper Kuninori Morimoto
2025-07-07 14:56 ` Gregory CLEMENT
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.