[Buildroot] [PATCH] package/e2fsprogs: Don't build docs for host

[Buildroot] [PATCH] package/e2fsprogs: Don't build docs for host

[Charlie Jenkins]

texinfo isn't provided for the host in buildroot, but e2fsprogs always
attempts to build the documentation. The error that gets printed is as
follows:

/usr/bin/install: cannot stat 'libext2fs.info*': No such file or directory
make[3]: [Makefile:363: install-doc-libs] Error 1 (ignored)

This error is ignored but it is unnecessary.

Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
---
 package/e2fsprogs/e2fsprogs.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
index 7f33b256c2626430a4578a9d8ffd8258df364a43..ad65d5189e75808af011ec87f0bee9d252f53767 100644
--- a/package/e2fsprogs/e2fsprogs.mk
+++ b/package/e2fsprogs/e2fsprogs.mk
@@ -56,6 +56,12 @@ E2FSPROGS_CONF_OPTS = \
 	--disable-rpath \
 	--enable-symlink-install
 
+# docs will fail to build for the host because buildroot doesn't provide texinfo
+define HOST_E2FSPROGS_REMOVE_DOCS
+	rm -rf $(@D)/doc
+endef
+HOST_E2FSPROGS_PRE_INSTALL_HOOKS += HOST_E2FSPROGS_REMOVE_DOCS
+
 ifeq ($(BR2_PACKAGE_E2FSPROGS_FUSE2FS),y)
 E2FSPROGS_CONF_OPTS += --enable-fuse2fs
 E2FSPROGS_DEPENDENCIES += libfuse

---
base-commit: af094ed137d6967afb6270b69c516a22eb9d8091
change-id: 20250407-fix_e2fsprogs-68470f22d8cd
-- 
- Charlie

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/e2fsprogs: Don't build docs for host

[Thomas Petazzoni via buildroot]

Hello Charlie,

On Tue, 08 Apr 2025 17:03:05 -0700
Charlie Jenkins <charlie@rivosinc.com> wrote:

> texinfo isn't provided for the host in buildroot, but e2fsprogs always
> attempts to build the documentation. The error that gets printed is as
> follows:
> 
> /usr/bin/install: cannot stat 'libext2fs.info*': No such file or directory
> make[3]: [Makefile:363: install-doc-libs] Error 1 (ignored)
> 
> This error is ignored but it is unnecessary.
> 
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
>  package/e2fsprogs/e2fsprogs.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

But why is that an issue for the host variant of e2fsprogs and not the
target variant?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/e2fsprogs: Don't build docs for host

[Peter Korsgaard]

>>>>> "Charlie" == Charlie Jenkins <charlie@rivosinc.com> writes:

 > texinfo isn't provided for the host in buildroot, but e2fsprogs always
 > attempts to build the documentation. The error that gets printed is as
 > follows:

 > /usr/bin/install: cannot stat 'libext2fs.info*': No such file or directory
 > make[3]: [Makefile:363: install-doc-libs] Error 1 (ignored)

 > This error is ignored but it is unnecessary.

 > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>

This is presumably not unique to the host version? Given that this is
intentional behaviour from upstream (hence the "ignored"), I don't think
it makes sense to add the extra complexity.

If you would like to get rid of the warning then please work with
upstream to handle it in a cleaner way (E.G. with a configure flag to
disable docs).

> ---
 >  package/e2fsprogs/e2fsprogs.mk | 6 ++++++
 >  1 file changed, 6 insertions(+)

 > diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
 > index 7f33b256c2626430a4578a9d8ffd8258df364a43..ad65d5189e75808af011ec87f0bee9d252f53767 100644
 > --- a/package/e2fsprogs/e2fsprogs.mk
 > +++ b/package/e2fsprogs/e2fsprogs.mk
 > @@ -56,6 +56,12 @@ E2FSPROGS_CONF_OPTS = \
 >  	--disable-rpath \
 >  	--enable-symlink-install
 
 > +# docs will fail to build for the host because buildroot doesn't provide texinfo
 > +define HOST_E2FSPROGS_REMOVE_DOCS
 > +	rm -rf $(@D)/doc
 > +endef
 > +HOST_E2FSPROGS_PRE_INSTALL_HOOKS += HOST_E2FSPROGS_REMOVE_DOCS
 > +
 >  ifeq ($(BR2_PACKAGE_E2FSPROGS_FUSE2FS),y)
 >  E2FSPROGS_CONF_OPTS += --enable-fuse2fs
 >  E2FSPROGS_DEPENDENCIES += libfuse

 > ---
 > base-commit: af094ed137d6967afb6270b69c516a22eb9d8091
 > change-id: 20250407-fix_e2fsprogs-68470f22d8cd
 > -- 

 > - Charlie

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot