Re: [PATCH v8] mm/mempolicy: Weighted Interleave Auto-tuning

["Huang, Ying" <ying.huang@linux.alibaba.com>]

Hi, Joshua,

Joshua Hahn <joshua.hahnjy@gmail.com> writes:

[snip]

> @@ -3707,8 +3720,12 @@ static void wi_state_free(void)
>  	kfree(&wi_group->wi_kobj);
>  }
>
> +static struct kobj_attribute wi_auto_attr =
> +	__ATTR(auto, 0664, weighted_interleave_auto_show,
> +			   weighted_interleave_auto_store);
> +
>  static void wi_cleanup(void) {
> -	sysfs_remove_file(&wi_group->wi_kobj, &wi_group->auto_kobj_attr.attr);
> +	sysfs_remove_file(&wi_group->wi_kobj, &wi_auto_attr.attr);

If we use wi_auto_attr directly here, we can remove auto_kobj_attr field
from struct sysfs_wi_group?

>  	sysfs_wi_node_delete_all();
>  	wi_state_free();
>  }

[snip]

---
Best Regards,
Huang, Ying