[Buildroot] [PATCH 1/1] package/rlwrap: use the github helper

[Buildroot] [PATCH 1/1] package/rlwrap: use the github helper

[Matt Silva]

Currently, rlwrap just downloads directly from the hardcoded URL to its
Github releases. However, we have a github helper function to streamline
this and handle if Github changes its download mechanisms in the future.

Signed-off-by: Matt Silva <dev@matt-silva.com>
---
 package/rlwrap/rlwrap.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/rlwrap/rlwrap.mk b/package/rlwrap/rlwrap.mk
index e3973e841b..3d3d4fab92 100644
--- a/package/rlwrap/rlwrap.mk
+++ b/package/rlwrap/rlwrap.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 RLWRAP_VERSION = 0.46.1
-RLWRAP_SITE = https://github.com/hanslub42/rlwrap/releases/download/$(RLWRAP_VERSION)
+RLWRAP_SITE = $(call github,hanslub42,rlwrap,v$(RLWRAP_VERSION))
 RLWRAP_LICENSE = GPL-2.0+
 RLWRAP_LICENSE_FILES = AUTHORS COPYING
 
-- 
2.47.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/rlwrap: use the github helper

[Baruch Siach via buildroot]

Hi Matt,

On Wed, Apr 09 2025, Matt Silva wrote:
> Currently, rlwrap just downloads directly from the hardcoded URL to its
> Github releases. However, we have a github helper function to streamline
> this and handle if Github changes its download mechanisms in the future.
>
> Signed-off-by: Matt Silva <dev@matt-silva.com>
> ---
>  package/rlwrap/rlwrap.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/rlwrap/rlwrap.mk b/package/rlwrap/rlwrap.mk
> index e3973e841b..3d3d4fab92 100644
> --- a/package/rlwrap/rlwrap.mk
> +++ b/package/rlwrap/rlwrap.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  RLWRAP_VERSION = 0.46.1
> -RLWRAP_SITE = https://github.com/hanslub42/rlwrap/releases/download/$(RLWRAP_VERSION)
> +RLWRAP_SITE = $(call github,hanslub42,rlwrap,v$(RLWRAP_VERSION))

We prefer to use release tarball when the package maintainer provides
one. See the relevant section in the Buildroot manual:

  https://buildroot.org/downloads/manual/manual.html#github-download-url

baruch

>  RLWRAP_LICENSE = GPL-2.0+
>  RLWRAP_LICENSE_FILES = AUTHORS COPYING

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot