* [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()
@ 2025-03-25 15:45 Philippe Mathieu-Daudé
2025-03-25 18:36 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-25 15:45 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Alex Bennée, Zhao Liu, Anton Johansson,
Pierrick Bouvier, Philippe Mathieu-Daudé
When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p().
Directly use the expanded form for clarity.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/i386/gdbstub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c
index 04c49e802d7..3dc022fccf7 100644
--- a/target/i386/gdbstub.c
+++ b/target/i386/gdbstub.c
@@ -287,9 +287,9 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
if (n < CPU_NB_REGS) {
if (TARGET_LONG_BITS == 64) {
if (env->hflags & HF_CS64_MASK) {
- env->regs[gpr_map[n]] = ldtul_p(mem_buf);
+ env->regs[gpr_map[n]] = ldq_p(mem_buf);
} else if (n < CPU_NB_REGS32) {
- env->regs[gpr_map[n]] = ldtul_p(mem_buf) & 0xffffffffUL;
+ env->regs[gpr_map[n]] = ldq_p(mem_buf) & 0xffffffffUL;
}
return sizeof(target_ulong);
} else if (n < CPU_NB_REGS32) {
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()
2025-03-25 15:45 [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p() Philippe Mathieu-Daudé
@ 2025-03-25 18:36 ` Richard Henderson
2025-03-26 8:50 ` Zhao Liu
2025-03-26 11:26 ` Alex Bennée
2 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2025-03-25 18:36 UTC (permalink / raw)
To: qemu-devel
On 3/25/25 08:45, Philippe Mathieu-Daudé wrote:
> When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p().
> Directly use the expanded form for clarity.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/i386/gdbstub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()
2025-03-25 15:45 [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p() Philippe Mathieu-Daudé
2025-03-25 18:36 ` Richard Henderson
@ 2025-03-26 8:50 ` Zhao Liu
2025-03-26 11:26 ` Alex Bennée
2 siblings, 0 replies; 5+ messages in thread
From: Zhao Liu @ 2025-03-26 8:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Paolo Bonzini, Alex Bennée, Anton Johansson,
Pierrick Bouvier
On Tue, Mar 25, 2025 at 04:45:28PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 25 Mar 2025 16:45:28 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()
> X-Mailer: git-send-email 2.47.1
>
> When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p().
> Directly use the expanded form for clarity.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/i386/gdbstub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()
2025-03-25 15:45 [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p() Philippe Mathieu-Daudé
2025-03-25 18:36 ` Richard Henderson
2025-03-26 8:50 ` Zhao Liu
@ 2025-03-26 11:26 ` Alex Bennée
2025-12-26 16:21 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2025-03-26 11:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Paolo Bonzini, Zhao Liu, Anton Johansson,
Pierrick Bouvier
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p().
> Directly use the expanded form for clarity.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Queued to gdbsub/next, thanks.
<snip>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()
2025-03-26 11:26 ` Alex Bennée
@ 2025-12-26 16:21 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-12-26 16:21 UTC (permalink / raw)
To: Alex Bennée
Cc: qemu-devel, Paolo Bonzini, Zhao Liu, Anton Johansson,
Pierrick Bouvier
Hi,
On 26/3/25 12:26, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
>> When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p().
>> Directly use the expanded form for clarity.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Queued to gdbsub/next, thanks.
> <snip>
>
This patch got never merged, is there an issue with it?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-26 16:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-25 15:45 [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p() Philippe Mathieu-Daudé
2025-03-25 18:36 ` Richard Henderson
2025-03-26 8:50 ` Zhao Liu
2025-03-26 11:26 ` Alex Bennée
2025-12-26 16:21 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.