Re: [PATCH v7 01/10] hw/qdev-properties-system: Introduce EndianMode QAPI enum

[Markus Armbruster <armbru@redhat.com>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Introduce the EndianMode type and the DEFINE_PROP_ENDIAN() macros.
> Endianness can be BIG, LITTLE or unspecified (default).
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  qapi/common.json                    | 16 ++++++++++++++++
>  include/hw/qdev-properties-system.h |  7 +++++++
>  hw/core/qdev-properties-system.c    | 11 +++++++++++
>  3 files changed, 34 insertions(+)
>
> diff --git a/qapi/common.json b/qapi/common.json
> index 6ffc7a37890..33d8df19f67 100644
> --- a/qapi/common.json
> +++ b/qapi/common.json
> @@ -212,3 +212,19 @@
>  ##
>  { 'struct': 'HumanReadableText',
>    'data': { 'human-readable-text': 'str' } }
> +
> +##
> +# @EndianMode:
> +#
> +# An enumeration of three options: little, big, and unspecified

Not sure this sentence is worth its keep.  It's consistent with existing
practice in this file, though.

> +#
> +# @unspecified: Endianness not specified
> +#
> +# @little: Little endianness
> +#
> +# @big: Big endianness
> +#
> +# Since: 10.0
> +##
> +{ 'enum': 'EndianMode',
> +  'data': [ 'unspecified', 'little', 'big' ] }

Acked-by: Markus Armbruster <armbru@redhat.com>

[...]