From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-ppc@nongnu.org, "Sai Pavan Boddu" <sai.pavan.boddu@amd.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v7 02/10] hw/intc/xilinx_intc: Make device endianness configurable
Date: Wed, 12 Feb 2025 13:56:25 +0100 [thread overview]
Message-ID: <8e5050d7-2792-44af-8317-2dd6948f72c7@redhat.com> (raw)
In-Reply-To: <20250212123659.52764-3-philmd@linaro.org>
On 12/02/2025 13.36, Philippe Mathieu-Daudé wrote:
> Replace the DEVICE_NATIVE_ENDIAN MemoryRegionOps by a pair
> of DEVICE_LITTLE_ENDIAN / DEVICE_BIG_ENDIAN.
> Add the "little-endian" property to select the device
> endianness, defaulting to little endian.
> Set the proper endianness for each machine using the device.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
...
> diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
> index 8b44be75a22..55398cc67d1 100644
> --- a/hw/microblaze/petalogix_ml605_mmu.c
> +++ b/hw/microblaze/petalogix_ml605_mmu.c
> @@ -111,6 +111,7 @@ petalogix_ml605_init(MachineState *machine)
>
>
> dev = qdev_new("xlnx.xps-intc");
> + qdev_prop_set_enum(dev, "endianness", ENDIAN_MODE_LITTLE);
Do we still need a TARGET_BIG_ENDIAN ?: check here, too? ... the
petalogix_ml605_machine_init() code still contains it, though big endian is
marked as deprecated and untested ...
Anyway, assuming that nobody uses this in big endian anymore:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-02-12 12:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 12:36 [PATCH v7 00/10] hw/microblaze: Allow running cross-endian vCPUs Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 01/10] hw/qdev-properties-system: Introduce EndianMode QAPI enum Philippe Mathieu-Daudé
2025-02-13 10:07 ` Markus Armbruster
2025-02-12 12:36 ` [PATCH v7 02/10] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2025-02-12 12:39 ` Philippe Mathieu-Daudé
2025-02-12 12:56 ` Thomas Huth [this message]
2025-02-13 12:15 ` Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 03/10] hw/net/xilinx_ethlite: " Philippe Mathieu-Daudé
2025-02-12 13:01 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 04/10] hw/timer/xilinx_timer: " Philippe Mathieu-Daudé
2025-02-12 13:04 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 05/10] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2025-02-12 13:06 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 06/10] hw/ssi/xilinx_spi: " Philippe Mathieu-Daudé
2025-02-12 13:10 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 07/10] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 08/10] tests/functional: Allow microblaze tests to take a machine name argument Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 09/10] tests/functional: Remove sleep() kludges from microblaze tests Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 10/10] tests/functional: Have microblaze tests inherit common parent class Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e5050d7-2792-44af-8317-2dd6948f72c7@redhat.com \
--to=thuth@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.