From: Thomas Gleixner <tglx@linutronix.de>
To: Bitao Hu <yaoma@linux.alibaba.com>,
dianders@chromium.org, liusong@linux.alibaba.com,
akpm@linux-foundation.org, pmladek@suse.com,
kernelfans@gmail.com, deller@gmx.de, npiggin@gmail.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
jan.kiszka@siemens.com
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
yaoma@linux.alibaba.com
Subject: Re: [PATCHv12 4/4] watchdog/softlockup: report the most frequent interrupts
Date: Sat, 23 Mar 2024 21:43:58 +0100 [thread overview]
Message-ID: <87zfuofzld.ffs@tglx> (raw)
In-Reply-To: <20240306125208.71803-5-yaoma@linux.alibaba.com>
On Wed, Mar 06 2024 at 20:52, Bitao Hu wrote:
> + if (__this_cpu_read(snapshot_taken)) {
> + for_each_active_irq(i) {
> + count = kstat_get_irq_since_snapshot(i);
> + tabulate_irq_count(irq_counts_sorted, i, count, NUM_HARDIRQ_REPORT);
> + }
> +
> + /*
> + * We do not want the "watchdog: " prefix on every line,
> + * hence we use "printk" instead of "pr_crit".
> + */
You are not providing any justification why the prefix is not
wanted. Just saying 'We do not want' does not cut it and who is 'We'. I
certainly not.
I really disagree because the prefixes are very useful for searching log
files. So not having it makes it harder to filter out for no reason.
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Bitao Hu <yaoma@linux.alibaba.com>,
dianders@chromium.org, liusong@linux.alibaba.com,
akpm@linux-foundation.org, pmladek@suse.com,
kernelfans@gmail.com, deller@gmx.de, npiggin@gmail.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
jan.kiszka@siemens.com
Cc: yaoma@linux.alibaba.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCHv12 4/4] watchdog/softlockup: report the most frequent interrupts
Date: Sat, 23 Mar 2024 21:43:58 +0100 [thread overview]
Message-ID: <87zfuofzld.ffs@tglx> (raw)
In-Reply-To: <20240306125208.71803-5-yaoma@linux.alibaba.com>
On Wed, Mar 06 2024 at 20:52, Bitao Hu wrote:
> + if (__this_cpu_read(snapshot_taken)) {
> + for_each_active_irq(i) {
> + count = kstat_get_irq_since_snapshot(i);
> + tabulate_irq_count(irq_counts_sorted, i, count, NUM_HARDIRQ_REPORT);
> + }
> +
> + /*
> + * We do not want the "watchdog: " prefix on every line,
> + * hence we use "printk" instead of "pr_crit".
> + */
You are not providing any justification why the prefix is not
wanted. Just saying 'We do not want' does not cut it and who is 'We'. I
certainly not.
I really disagree because the prefixes are very useful for searching log
files. So not having it makes it harder to filter out for no reason.
Thanks,
tglx
next prev parent reply other threads:[~2024-03-23 20:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:52 [PATCHv12 0/4] *** Detect interrupt storm in softlockup *** Bitao Hu
2024-03-06 12:52 ` Bitao Hu
2024-03-06 12:52 ` [PATCHv12 1/4] genirq: Provide a snapshot mechanism for interrupt statistics Bitao Hu
2024-03-06 12:52 ` Bitao Hu
2024-04-09 9:58 ` Thomas Gleixner
2024-04-09 9:58 ` Thomas Gleixner
2024-04-10 6:45 ` Bitao Hu
2024-04-10 6:45 ` Bitao Hu
2024-04-10 14:17 ` Thomas Gleixner
2024-04-10 14:17 ` Thomas Gleixner
2024-03-06 12:52 ` [PATCHv12 2/4] genirq: Avoid summation loops for /proc/interrupts Bitao Hu
2024-03-06 12:52 ` Bitao Hu
2024-03-06 12:52 ` [PATCHv12 3/4] watchdog/softlockup: low-overhead detection of interrupt storm Bitao Hu
2024-03-06 12:52 ` Bitao Hu
2024-03-06 12:52 ` [PATCHv12 4/4] watchdog/softlockup: report the most frequent interrupts Bitao Hu
2024-03-06 12:52 ` Bitao Hu
2024-03-23 20:43 ` Thomas Gleixner [this message]
2024-03-23 20:43 ` Thomas Gleixner
2024-03-25 9:47 ` Bitao Hu
2024-03-25 9:47 ` Bitao Hu
2024-04-01 16:41 ` Doug Anderson
2024-04-01 16:41 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfuofzld.ffs@tglx \
--to=tglx@linutronix.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=dianders@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liusong@linux.alibaba.com \
--cc=npiggin@gmail.com \
--cc=pmladek@suse.com \
--cc=tsbogend@alpha.franken.de \
--cc=yaoma@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.