* [Intel-gfx] [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs @ 2023-12-01 16:11 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2023-12-01 16:11 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Ville Syrjälä Cc: Andy Shevchenko, Hans de Goede, intel-gfx, dri-devel soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent and use devm_gpiod_get() for all GPIOs. This allows removing the intel_dsi_vbt_gpio_cleanup() function, which only function was to put the GPIO-descriptors. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Note this applies on top of Andy's recent GPIO rework series which has just landed in drm-intel-next --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 17 ++--------------- drivers/gpu/drm/i915/display/intel_dsi_vbt.h | 1 - drivers/gpu/drm/i915/display/vlv_dsi.c | 10 +--------- 3 files changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c index 275d0218394c..a5d7fc8418c9 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c @@ -922,7 +922,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) gpiod_add_lookup_table(gpiod_lookup_table); if (want_panel_gpio) { - intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags); + intel_dsi->gpio_panel = devm_gpiod_get(dev->dev, "panel", flags); if (IS_ERR(intel_dsi->gpio_panel)) { drm_err(&dev_priv->drm, "Failed to own gpio for panel control\n"); @@ -932,7 +932,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) if (want_backlight_gpio) { intel_dsi->gpio_backlight = - gpiod_get(dev->dev, "backlight", flags); + devm_gpiod_get(dev->dev, "backlight", flags); if (IS_ERR(intel_dsi->gpio_backlight)) { drm_err(&dev_priv->drm, "Failed to own gpio for backlight control\n"); @@ -943,16 +943,3 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) if (gpiod_lookup_table) gpiod_remove_lookup_table(gpiod_lookup_table); } - -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi) -{ - if (intel_dsi->gpio_panel) { - gpiod_put(intel_dsi->gpio_panel); - intel_dsi->gpio_panel = NULL; - } - - if (intel_dsi->gpio_backlight) { - gpiod_put(intel_dsi->gpio_backlight); - intel_dsi->gpio_backlight = NULL; - } -} diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h index 468d873fab1a..3462fcc760e6 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h @@ -13,7 +13,6 @@ struct intel_dsi; bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, enum mipi_seq seq_id); void intel_dsi_log_params(struct intel_dsi *intel_dsi); diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c index 5bda97c96810..9b33b8a74d64 100644 --- a/drivers/gpu/drm/i915/display/vlv_dsi.c +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c @@ -1532,16 +1532,8 @@ static void intel_dsi_unprepare(struct intel_encoder *encoder) } } -static void intel_dsi_encoder_destroy(struct drm_encoder *encoder) -{ - struct intel_dsi *intel_dsi = enc_to_intel_dsi(to_intel_encoder(encoder)); - - intel_dsi_vbt_gpio_cleanup(intel_dsi); - intel_encoder_destroy(encoder); -} - static const struct drm_encoder_funcs intel_dsi_funcs = { - .destroy = intel_dsi_encoder_destroy, + .destroy = intel_encoder_destroy, }; static enum drm_mode_status vlv_dsi_mode_valid(struct drm_connector *connector, -- 2.41.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs @ 2023-12-01 16:11 ` Hans de Goede 0 siblings, 0 replies; 8+ messages in thread From: Hans de Goede @ 2023-12-01 16:11 UTC (permalink / raw) To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Ville Syrjälä Cc: Andy Shevchenko, Hans de Goede, intel-gfx, dri-devel soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent and use devm_gpiod_get() for all GPIOs. This allows removing the intel_dsi_vbt_gpio_cleanup() function, which only function was to put the GPIO-descriptors. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Note this applies on top of Andy's recent GPIO rework series which has just landed in drm-intel-next --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 17 ++--------------- drivers/gpu/drm/i915/display/intel_dsi_vbt.h | 1 - drivers/gpu/drm/i915/display/vlv_dsi.c | 10 +--------- 3 files changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c index 275d0218394c..a5d7fc8418c9 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c @@ -922,7 +922,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) gpiod_add_lookup_table(gpiod_lookup_table); if (want_panel_gpio) { - intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags); + intel_dsi->gpio_panel = devm_gpiod_get(dev->dev, "panel", flags); if (IS_ERR(intel_dsi->gpio_panel)) { drm_err(&dev_priv->drm, "Failed to own gpio for panel control\n"); @@ -932,7 +932,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) if (want_backlight_gpio) { intel_dsi->gpio_backlight = - gpiod_get(dev->dev, "backlight", flags); + devm_gpiod_get(dev->dev, "backlight", flags); if (IS_ERR(intel_dsi->gpio_backlight)) { drm_err(&dev_priv->drm, "Failed to own gpio for backlight control\n"); @@ -943,16 +943,3 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) if (gpiod_lookup_table) gpiod_remove_lookup_table(gpiod_lookup_table); } - -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi) -{ - if (intel_dsi->gpio_panel) { - gpiod_put(intel_dsi->gpio_panel); - intel_dsi->gpio_panel = NULL; - } - - if (intel_dsi->gpio_backlight) { - gpiod_put(intel_dsi->gpio_backlight); - intel_dsi->gpio_backlight = NULL; - } -} diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h index 468d873fab1a..3462fcc760e6 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h @@ -13,7 +13,6 @@ struct intel_dsi; bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, enum mipi_seq seq_id); void intel_dsi_log_params(struct intel_dsi *intel_dsi); diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c index 5bda97c96810..9b33b8a74d64 100644 --- a/drivers/gpu/drm/i915/display/vlv_dsi.c +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c @@ -1532,16 +1532,8 @@ static void intel_dsi_unprepare(struct intel_encoder *encoder) } } -static void intel_dsi_encoder_destroy(struct drm_encoder *encoder) -{ - struct intel_dsi *intel_dsi = enc_to_intel_dsi(to_intel_encoder(encoder)); - - intel_dsi_vbt_gpio_cleanup(intel_dsi); - intel_encoder_destroy(encoder); -} - static const struct drm_encoder_funcs intel_dsi_funcs = { - .destroy = intel_dsi_encoder_destroy, + .destroy = intel_encoder_destroy, }; static enum drm_mode_status vlv_dsi_mode_valid(struct drm_connector *connector, -- 2.41.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs 2023-12-01 16:11 ` Hans de Goede @ 2023-12-01 16:26 ` Andy Shevchenko -1 siblings, 0 replies; 8+ messages in thread From: Andy Shevchenko @ 2023-12-01 16:26 UTC (permalink / raw) To: Hans de Goede; +Cc: intel-gfx, dri-devel, Rodrigo Vivi On Fri, Dec 01, 2023 at 05:11:30PM +0100, Hans de Goede wrote: > soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent > and use devm_gpiod_get() for all GPIOs. > > This allows removing the intel_dsi_vbt_gpio_cleanup() function, > which only function was to put the GPIO-descriptors. Fine by me, but I'm not to judge if it is a right approach or not. In my series I have reused existing call... Anyway, FWIW, Reviewed-by: Andy Shevchenko <andy@kernel.org> -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs @ 2023-12-01 16:26 ` Andy Shevchenko 0 siblings, 0 replies; 8+ messages in thread From: Andy Shevchenko @ 2023-12-01 16:26 UTC (permalink / raw) To: Hans de Goede; +Cc: Tvrtko Ursulin, intel-gfx, dri-devel, Rodrigo Vivi On Fri, Dec 01, 2023 at 05:11:30PM +0100, Hans de Goede wrote: > soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent > and use devm_gpiod_get() for all GPIOs. > > This allows removing the intel_dsi_vbt_gpio_cleanup() function, > which only function was to put the GPIO-descriptors. Fine by me, but I'm not to judge if it is a right approach or not. In my series I have reused existing call... Anyway, FWIW, Reviewed-by: Andy Shevchenko <andy@kernel.org> -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Use devm_gpiod_get() for all GPIOs 2023-12-01 16:11 ` Hans de Goede (?) (?) @ 2023-12-02 2:54 ` Patchwork -1 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2023-12-02 2:54 UTC (permalink / raw) To: Hans de Goede; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 19363 bytes --] == Series Details == Series: drm/i915/dsi: Use devm_gpiod_get() for all GPIOs URL : https://patchwork.freedesktop.org/series/127206/ State : success == Summary == CI Bug Log - changes from CI_DRM_13962 -> Patchwork_127206v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/index.html Participating hosts (33 -> 38) ------------------------------ Additional (6): fi-bsw-n3050 bat-dg1-5 bat-dg2-8 fi-tgl-1115g4 bat-dg2-9 bat-mtlp-8 Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_127206v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - bat-mtlp-8: NOTRUN -> [SKIP][1] ([i915#9318]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html - fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([i915#9318]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html * igt@gem_exec_suspend@basic-s0@lmem0: - bat-dg2-9: NOTRUN -> [INCOMPLETE][3] ([i915#9275]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html * igt@gem_huc_copy@huc-copy: - fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([i915#2190]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@parallel-random-engines: - bat-mtlp-8: NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@gem_lmem_swapping@parallel-random-engines.html - fi-tgl-1115g4: NOTRUN -> [SKIP][6] ([i915#4613]) +3 other tests skip [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html * igt@gem_mmap@basic: - bat-mtlp-8: NOTRUN -> [SKIP][7] ([i915#4083]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@gem_mmap@basic.html - bat-dg2-8: NOTRUN -> [SKIP][8] ([i915#4083]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@gem_mmap@basic.html - bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#4083]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@gem_mmap@basic.html - bat-dg2-9: NOTRUN -> [SKIP][10] ([i915#4083]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@gem_mmap@basic.html * igt@gem_mmap_gtt@basic: - bat-dg2-9: NOTRUN -> [SKIP][11] ([i915#4077]) +2 other tests skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@gem_mmap_gtt@basic.html * igt@gem_render_tiled_blits@basic: - bat-mtlp-8: NOTRUN -> [SKIP][12] ([i915#4079]) +1 other test skip [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html - bat-dg2-8: NOTRUN -> [SKIP][13] ([i915#4079]) +1 other test skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@gem_render_tiled_blits@basic.html * igt@gem_tiled_blits@basic: - fi-bsw-n3050: NOTRUN -> [SKIP][14] ([fdo#109271]) +14 other tests skip [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-bsw-n3050/igt@gem_tiled_blits@basic.html - bat-dg1-5: NOTRUN -> [SKIP][15] ([i915#4077]) +2 other tests skip [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@gem_tiled_blits@basic.html * igt@gem_tiled_fence_blits@basic: - bat-mtlp-8: NOTRUN -> [SKIP][16] ([i915#4077]) +2 other tests skip [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@gem_tiled_fence_blits@basic.html - bat-dg2-8: NOTRUN -> [SKIP][17] ([i915#4077]) +2 other tests skip [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@gem_tiled_fence_blits@basic.html * igt@gem_tiled_pread_basic: - bat-dg1-5: NOTRUN -> [SKIP][18] ([i915#4079]) +1 other test skip [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@gem_tiled_pread_basic.html - bat-dg2-9: NOTRUN -> [SKIP][19] ([i915#4079]) +1 other test skip [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@gem_tiled_pread_basic.html * igt@i915_pm_rps@basic-api: - bat-mtlp-8: NOTRUN -> [SKIP][20] ([i915#6621]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@i915_pm_rps@basic-api.html - bat-dg2-8: NOTRUN -> [SKIP][21] ([i915#6621]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@i915_pm_rps@basic-api.html - bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#6621]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@i915_pm_rps@basic-api.html - bat-dg2-9: NOTRUN -> [SKIP][23] ([i915#6621]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@i915_pm_rps@basic-api.html * igt@i915_suspend@basic-s3-without-i915: - fi-tgl-1115g4: NOTRUN -> [INCOMPLETE][24] ([i915#7443]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html - bat-mtlp-8: NOTRUN -> [SKIP][25] ([i915#6645]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html - bat-dg2-8: NOTRUN -> [SKIP][26] ([i915#6645]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy: - bat-dg2-8: NOTRUN -> [SKIP][27] ([i915#4212]) +6 other tests skip [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy: - bat-dg2-9: NOTRUN -> [SKIP][28] ([i915#5190]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html - bat-mtlp-8: NOTRUN -> [SKIP][29] ([i915#5190]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html - bat-dg2-8: NOTRUN -> [SKIP][30] ([i915#5190]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html * igt@kms_addfb_basic@basic-x-tiled-legacy: - bat-dg1-5: NOTRUN -> [SKIP][31] ([i915#4212]) +7 other tests skip [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_addfb_basic@basic-x-tiled-legacy.html * igt@kms_addfb_basic@basic-y-tiled-legacy: - bat-mtlp-8: NOTRUN -> [SKIP][32] ([i915#4212]) +8 other tests skip [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html - bat-dg2-8: NOTRUN -> [SKIP][33] ([i915#4215] / [i915#5190]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html - bat-dg1-5: NOTRUN -> [SKIP][34] ([i915#4215]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html - bat-dg2-9: NOTRUN -> [SKIP][35] ([i915#4215] / [i915#5190]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html * igt@kms_addfb_basic@framebuffer-vs-set-tiling: - bat-dg2-9: NOTRUN -> [SKIP][36] ([i915#4212]) +6 other tests skip [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html * igt@kms_addfb_basic@tile-pitch-mismatch: - bat-dg2-8: NOTRUN -> [SKIP][37] ([i915#4212] / [i915#5608]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_addfb_basic@tile-pitch-mismatch.html - bat-dg2-9: NOTRUN -> [SKIP][38] ([i915#4212] / [i915#5608]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-tgl-1115g4: NOTRUN -> [SKIP][39] ([i915#4103]) +1 other test skip [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - bat-mtlp-8: NOTRUN -> [SKIP][40] ([i915#4213]) +1 other test skip [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html - bat-dg2-8: NOTRUN -> [SKIP][41] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html - bat-dg1-5: NOTRUN -> [SKIP][42] ([i915#4103] / [i915#4213]) +1 other test skip [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html - bat-dg2-9: NOTRUN -> [SKIP][43] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_dsc@dsc-basic: - fi-tgl-1115g4: NOTRUN -> [SKIP][44] ([i915#3555] / [i915#3840]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@kms_dsc@dsc-basic.html - bat-mtlp-8: NOTRUN -> [SKIP][45] ([i915#3555] / [i915#3840] / [i915#4098] / [i915#9159]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_dsc@dsc-basic.html - bat-dg1-5: NOTRUN -> [SKIP][46] ([i915#3555] / [i915#3840]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_dsc@dsc-basic.html * igt@kms_force_connector_basic@force-load-detect: - bat-mtlp-8: NOTRUN -> [SKIP][47] ([fdo#109285]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html - bat-dg2-8: NOTRUN -> [SKIP][48] ([fdo#109285]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_force_connector_basic@force-load-detect.html - bat-dg1-5: NOTRUN -> [SKIP][49] ([fdo#109285]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html - fi-tgl-1115g4: NOTRUN -> [SKIP][50] ([fdo#109285]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html - bat-dg2-9: NOTRUN -> [SKIP][51] ([fdo#109285]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-dg2-9: NOTRUN -> [SKIP][52] ([i915#5274]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html - bat-mtlp-8: NOTRUN -> [SKIP][53] ([i915#5274]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html - bat-dg2-8: NOTRUN -> [SKIP][54] ([i915#5274]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_hdmi_inject@inject-audio: - fi-bsw-n3050: NOTRUN -> [FAIL][55] ([IGT#152]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-bsw-n3050/igt@kms_hdmi_inject@inject-audio.html - bat-dg1-5: NOTRUN -> [SKIP][56] ([i915#433]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_hdmi_inject@inject-audio.html * igt@kms_setmode@basic-clone-single-crtc: - bat-dg1-5: NOTRUN -> [SKIP][57] ([i915#3555]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html - bat-dg2-9: NOTRUN -> [SKIP][58] ([i915#3555] / [i915#4098]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html - fi-tgl-1115g4: NOTRUN -> [SKIP][59] ([i915#3555]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html - bat-mtlp-8: NOTRUN -> [SKIP][60] ([i915#3555] / [i915#8809]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html - bat-dg2-8: NOTRUN -> [SKIP][61] ([i915#3555] / [i915#4098]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - bat-dg2-8: NOTRUN -> [SKIP][62] ([i915#3708]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@prime_vgem@basic-fence-flip.html - bat-dg2-9: NOTRUN -> [SKIP][63] ([i915#3708]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-fence-mmap: - bat-dg2-9: NOTRUN -> [SKIP][64] ([i915#3708] / [i915#4077]) +1 other test skip [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html * igt@prime_vgem@basic-fence-read: - bat-mtlp-8: NOTRUN -> [SKIP][65] ([i915#3708]) +2 other tests skip [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html - bat-dg1-5: NOTRUN -> [SKIP][66] ([i915#3708]) +3 other tests skip [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@prime_vgem@basic-fence-read.html * igt@prime_vgem@basic-gtt: - bat-mtlp-8: NOTRUN -> [SKIP][67] ([i915#3708] / [i915#4077]) +1 other test skip [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-mtlp-8/igt@prime_vgem@basic-gtt.html - bat-dg2-8: NOTRUN -> [SKIP][68] ([i915#3708] / [i915#4077]) +1 other test skip [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@prime_vgem@basic-gtt.html - bat-dg1-5: NOTRUN -> [SKIP][69] ([i915#3708] / [i915#4077]) +1 other test skip [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg1-5/igt@prime_vgem@basic-gtt.html * igt@prime_vgem@basic-write: - bat-dg2-9: NOTRUN -> [SKIP][70] ([i915#3291] / [i915#3708]) +2 other tests skip [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-9/igt@prime_vgem@basic-write.html - bat-dg2-8: NOTRUN -> [SKIP][71] ([i915#3291] / [i915#3708]) +2 other tests skip [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-dg2-8/igt@prime_vgem@basic-write.html #### Possible fixes #### * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1: - bat-rplp-1: [ABORT][72] ([i915#8668]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#152]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/152 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809 [i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159 [i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275 [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318 [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673 [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732 [i915#9736]: https://gitlab.freedesktop.org/drm/intel/issues/9736 Build changes ------------- * Linux: CI_DRM_13962 -> Patchwork_127206v1 CI-20190529: 20190529 CI_DRM_13962: 6915556fe478277b884730a627ad8ae1f4ab9efa @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7614: c7298ec108dc1c861c9a2593e973648ad9b420b4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_127206v1: 6915556fe478277b884730a627ad8ae1f4ab9efa @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 219381abbb11 drm/i915/dsi: Use devm_gpiod_get() for all GPIOs == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/index.html [-- Attachment #2: Type: text/html, Size: 25499 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: Use devm_gpiod_get() for all GPIOs 2023-12-01 16:11 ` Hans de Goede ` (2 preceding siblings ...) (?) @ 2023-12-03 5:46 ` Patchwork -1 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2023-12-03 5:46 UTC (permalink / raw) To: Hans de Goede; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 41779 bytes --] == Series Details == Series: drm/i915/dsi: Use devm_gpiod_get() for all GPIOs URL : https://patchwork.freedesktop.org/series/127206/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13962_full -> Patchwork_127206v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_127206v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_127206v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 11) ------------------------------ Additional (1): shard-tglu0 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_127206v1_full: ### IGT changes ### #### Possible regressions #### * igt@kms_vblank@wait-forked-hang@pipe-a-hdmi-a-2: - shard-dg2: NOTRUN -> [TIMEOUT][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@kms_vblank@wait-forked-hang@pipe-a-hdmi-a-2.html * igt@syncobj_wait@invalid-wait-zero-handles: - shard-dg2: NOTRUN -> [FAIL][2] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@syncobj_wait@invalid-wait-zero-handles.html Known issues ------------ Here are the changes found in Patchwork_127206v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@api_intel_bb@object-reloc-purge-cache: - shard-dg2: NOTRUN -> [SKIP][3] ([i915#8411]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@api_intel_bb@object-reloc-purge-cache.html * igt@device_reset@unbind-cold-reset-rebind: - shard-mtlp: NOTRUN -> [SKIP][4] ([i915#7701]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@device_reset@unbind-cold-reset-rebind.html - shard-dg2: NOTRUN -> [SKIP][5] ([i915#7701]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@device_reset@unbind-cold-reset-rebind.html * igt@drm_fdinfo@virtual-busy: - shard-mtlp: NOTRUN -> [SKIP][6] ([i915#8414]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@drm_fdinfo@virtual-busy.html - shard-dg2: NOTRUN -> [SKIP][7] ([i915#8414]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@drm_fdinfo@virtual-busy.html * igt@gem_ctx_persistence@heartbeat-hang: - shard-dg2: NOTRUN -> [SKIP][8] ([i915#8555]) +1 other test skip [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_ctx_persistence@heartbeat-hang.html - shard-mtlp: NOTRUN -> [SKIP][9] ([i915#8555]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_ctx_persistence@heartbeat-hang.html * igt@gem_eio@hibernate: - shard-dg2: NOTRUN -> [ABORT][10] ([i915#7975] / [i915#8213]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@gem_eio@hibernate.html * igt@gem_exec_balancer@bonded-false-hang: - shard-dg2: NOTRUN -> [SKIP][11] ([i915#4812]) +1 other test skip [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_exec_balancer@bonded-false-hang.html * igt@gem_exec_balancer@hog: - shard-dg1: NOTRUN -> [SKIP][12] ([i915#4812]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@gem_exec_balancer@hog.html * igt@gem_exec_capture@many-4k-zero: - shard-dg2: NOTRUN -> [FAIL][13] ([i915#9606]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_exec_capture@many-4k-zero.html - shard-mtlp: NOTRUN -> [FAIL][14] ([i915#9606]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_exec_capture@many-4k-zero.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][15] -> [FAIL][16] ([i915#2842]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-tglu: [PASS][17] -> [FAIL][18] ([i915#2842]) +1 other test fail [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-tglu-7/igt@gem_exec_fair@basic-throttle@rcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-tglu-5/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_fence@concurrent: - shard-mtlp: NOTRUN -> [SKIP][19] ([i915#4812]) +1 other test skip [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_exec_fence@concurrent.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-dg2: NOTRUN -> [SKIP][20] ([i915#3539] / [i915#4852]) +2 other tests skip [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-cpu-gtt-noreloc: - shard-dg2: NOTRUN -> [SKIP][21] ([i915#3281]) +6 other tests skip [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html * igt@gem_exec_reloc@basic-cpu-wc-active: - shard-mtlp: NOTRUN -> [SKIP][22] ([i915#3281]) +2 other tests skip [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_exec_reloc@basic-cpu-wc-active.html * igt@gem_exec_schedule@preempt-queue-chain: - shard-dg2: NOTRUN -> [SKIP][23] ([i915#4537] / [i915#4812]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@gem_exec_schedule@preempt-queue-chain.html * igt@gem_exec_schedule@wide@rcs0: - shard-glk: [PASS][24] -> [FAIL][25] ([i915#9521]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-glk8/igt@gem_exec_schedule@wide@rcs0.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-glk6/igt@gem_exec_schedule@wide@rcs0.html * igt@gem_exec_suspend@basic-s0@smem: - shard-dg2: NOTRUN -> [INCOMPLETE][26] ([i915#9275]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s4-devices@smem: - shard-tglu: [PASS][27] -> [ABORT][28] ([i915#7975] / [i915#8213]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-tglu-2/igt@gem_exec_suspend@basic-s4-devices@smem.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html * igt@gem_lmem_swapping@smem-oom: - shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-glk8/igt@gem_lmem_swapping@smem-oom.html * igt@gem_lmem_swapping@verify-random-ccs: - shard-mtlp: NOTRUN -> [SKIP][30] ([i915#4613]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_lmem_swapping@verify-random-ccs.html * igt@gem_mmap@short-mmap: - shard-dg2: NOTRUN -> [SKIP][31] ([i915#4083]) +6 other tests skip [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_mmap@short-mmap.html * igt@gem_mmap_gtt@basic-write-gtt: - shard-mtlp: NOTRUN -> [SKIP][32] ([i915#4077]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_mmap_gtt@basic-write-gtt.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-dg2: NOTRUN -> [SKIP][33] ([i915#4077]) +4 other tests skip [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_mmap_gtt@hang-user: - shard-dg1: NOTRUN -> [SKIP][34] ([i915#4077]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@gem_mmap_gtt@hang-user.html * igt@gem_mmap_wc@write-read: - shard-mtlp: NOTRUN -> [SKIP][35] ([i915#4083]) +2 other tests skip [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_mmap_wc@write-read.html * igt@gem_pread@snoop: - shard-dg1: NOTRUN -> [SKIP][36] ([i915#3282]) +1 other test skip [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@gem_pread@snoop.html * igt@gem_pxp@reject-modify-context-protection-off-1: - shard-dg2: NOTRUN -> [SKIP][37] ([i915#4270]) +1 other test skip [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_pxp@reject-modify-context-protection-off-1.html - shard-mtlp: NOTRUN -> [SKIP][38] ([i915#4270]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_pxp@reject-modify-context-protection-off-1.html * igt@gem_readwrite@beyond-eob: - shard-dg2: NOTRUN -> [SKIP][39] ([i915#3282]) +1 other test skip [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_readwrite@beyond-eob.html - shard-mtlp: NOTRUN -> [SKIP][40] ([i915#3282]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_readwrite@beyond-eob.html * igt@gem_render_copy@y-tiled-ccs-to-y-tiled-ccs: - shard-mtlp: NOTRUN -> [SKIP][41] ([i915#8428]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-ccs.html * igt@gem_userptr_blits@readonly-unsync: - shard-dg2: NOTRUN -> [SKIP][42] ([i915#3297]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@gem_userptr_blits@readonly-unsync.html * igt@gem_userptr_blits@vma-merge: - shard-dg2: NOTRUN -> [FAIL][43] ([i915#3318]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@gem_userptr_blits@vma-merge.html - shard-mtlp: NOTRUN -> [FAIL][44] ([i915#3318]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gem_userptr_blits@vma-merge.html * igt@gen7_exec_parse@basic-rejected: - shard-dg2: NOTRUN -> [SKIP][45] ([fdo#109289]) +2 other tests skip [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@gen7_exec_parse@basic-rejected.html * igt@gen9_exec_parse@basic-rejected: - shard-mtlp: NOTRUN -> [SKIP][46] ([i915#2856]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@gen9_exec_parse@basic-rejected.html * igt@gen9_exec_parse@unaligned-jump: - shard-dg2: NOTRUN -> [SKIP][47] ([i915#2856]) +1 other test skip [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@gen9_exec_parse@unaligned-jump.html * igt@i915_pm_freq_mult@media-freq@gt0: - shard-dg1: NOTRUN -> [SKIP][48] ([i915#6590]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@i915_pm_freq_mult@media-freq@gt0.html * igt@i915_pm_rps@basic-api: - shard-mtlp: NOTRUN -> [SKIP][49] ([i915#6621]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@i915_pm_rps@basic-api.html - shard-dg2: NOTRUN -> [SKIP][50] ([i915#6621]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@i915_pm_rps@basic-api.html * igt@kms_big_fb@x-tiled-16bpp-rotate-270: - shard-dg2: NOTRUN -> [SKIP][51] ([fdo#111614]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-tglu: [PASS][52] -> [FAIL][53] ([i915#3743]) +1 other test fail [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-tglu-9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-tglu-7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@y-tiled-addfb: - shard-mtlp: NOTRUN -> [SKIP][54] ([i915#6187]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_big_fb@y-tiled-addfb.html * igt@kms_big_fb@y-tiled-addfb-size-offset-overflow: - shard-dg2: NOTRUN -> [SKIP][55] ([i915#5190]) +11 other tests skip [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@kms_big_fb@y-tiled-addfb-size-offset-overflow.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-90: - shard-mtlp: NOTRUN -> [SKIP][56] ([fdo#111615]) +1 other test skip [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_big_fb@yf-tiled-64bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip: - shard-dg2: NOTRUN -> [SKIP][57] ([i915#4538] / [i915#5190]) +2 other tests skip [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html * igt@kms_cdclk@plane-scaling@pipe-c-edp-1: - shard-mtlp: NOTRUN -> [SKIP][58] ([i915#4087]) +3 other tests skip [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_cdclk@plane-scaling@pipe-c-edp-1.html * igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][59] ([i915#4087]) +3 other tests skip [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3.html * igt@kms_chamelium_color@gamma: - shard-dg2: NOTRUN -> [SKIP][60] ([fdo#111827]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@kms_chamelium_color@gamma.html * igt@kms_chamelium_edid@hdmi-edid-stress-resolution-4k: - shard-mtlp: NOTRUN -> [SKIP][61] ([i915#7828]) +2 other tests skip [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_chamelium_edid@hdmi-edid-stress-resolution-4k.html * igt@kms_chamelium_frames@hdmi-crc-multiple: - shard-dg2: NOTRUN -> [SKIP][62] ([i915#7828]) +6 other tests skip [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_chamelium_frames@hdmi-crc-multiple.html * igt@kms_content_protection@uevent: - shard-mtlp: NOTRUN -> [SKIP][63] ([i915#6944]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_content_protection@uevent.html - shard-dg2: NOTRUN -> [SKIP][64] ([i915#7118]) +1 other test skip [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_content_protection@uevent.html * igt@kms_cursor_crc@cursor-random-512x170: - shard-dg2: NOTRUN -> [SKIP][65] ([i915#3359]) +2 other tests skip [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_cursor_crc@cursor-random-512x170.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic: - shard-mtlp: NOTRUN -> [SKIP][66] ([i915#3546]) +1 other test skip [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size: - shard-dg2: NOTRUN -> [SKIP][67] ([i915#4103] / [i915#4213]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html * igt@kms_cursor_legacy@cursorb-vs-flipb-legacy: - shard-dg2: NOTRUN -> [SKIP][68] ([fdo#109274] / [i915#5354]) +3 other tests skip [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-glk: [PASS][69] -> [FAIL][70] ([i915#2346]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_dither@fb-8bpc-vs-panel-8bpc: - shard-dg2: NOTRUN -> [SKIP][71] ([i915#3555]) +3 other tests skip [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html * igt@kms_dsc@dsc-basic: - shard-dg2: NOTRUN -> [SKIP][72] ([i915#3555] / [i915#3840] / [i915#4098]) +1 other test skip [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@kms_dsc@dsc-basic.html * igt@kms_fence_pin_leak: - shard-dg2: NOTRUN -> [SKIP][73] ([i915#4881]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_fence_pin_leak.html * igt@kms_flip@2x-flip-vs-modeset: - shard-dg2: NOTRUN -> [SKIP][74] ([fdo#109274]) +5 other tests skip [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_flip@2x-flip-vs-modeset.html * igt@kms_flip@2x-flip-vs-panning-vs-hang: - shard-snb: NOTRUN -> [SKIP][75] ([fdo#109271]) +4 other tests skip [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-snb7/igt@kms_flip@2x-flip-vs-panning-vs-hang.html * igt@kms_flip@2x-plain-flip-interruptible: - shard-mtlp: NOTRUN -> [SKIP][76] ([i915#3637]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_flip@2x-plain-flip-interruptible.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][77] ([i915#8810]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode: - shard-dg2: NOTRUN -> [SKIP][78] ([i915#2672]) +3 other tests skip [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode: - shard-dg1: NOTRUN -> [SKIP][79] ([i915#2587] / [i915#2672]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][80] ([i915#2672]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][81] ([i915#2672] / [i915#3555]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode: - shard-dg2: NOTRUN -> [SKIP][82] ([i915#2672] / [i915#3555]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc: - shard-dg2: NOTRUN -> [SKIP][83] ([i915#8708]) +12 other tests skip [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: - shard-dg1: NOTRUN -> [SKIP][84] ([i915#8708]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw: - shard-dg2: NOTRUN -> [SKIP][85] ([i915#5354]) +21 other tests skip [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][86] ([i915#8708]) +1 other test skip [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu: - shard-dg2: NOTRUN -> [SKIP][87] ([i915#3458]) +14 other tests skip [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu: - shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271]) +4 other tests skip [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-glk8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff: - shard-dg1: NOTRUN -> [SKIP][89] ([fdo#111825]) +1 other test skip [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render: - shard-mtlp: NOTRUN -> [SKIP][90] ([i915#1825]) +10 other tests skip [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html * igt@kms_hdr@invalid-metadata-sizes: - shard-dg2: NOTRUN -> [SKIP][91] ([i915#3555] / [i915#8228]) +2 other tests skip [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_hdr@invalid-metadata-sizes.html * igt@kms_panel_fitting@legacy: - shard-dg2: NOTRUN -> [SKIP][92] ([i915#6301]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_panel_fitting@legacy.html * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-edp-1: - shard-mtlp: NOTRUN -> [SKIP][93] ([i915#5235]) +2 other tests skip [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-edp-1: - shard-mtlp: NOTRUN -> [SKIP][94] ([i915#3555] / [i915#5235]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][95] ([i915#5235]) +23 other tests skip [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3.html * igt@kms_prime@basic-crc-vgem: - shard-dg2: NOTRUN -> [SKIP][96] ([i915#6524] / [i915#6805]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_prime@basic-crc-vgem.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area: - shard-dg2: NOTRUN -> [SKIP][97] ([i915#9683]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-dg2: NOTRUN -> [SKIP][98] ([i915#9673] / [i915#9732]) +2 other tests skip [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_psr@psr2_cursor_mmap_gtt.html * igt@kms_rotation_crc@sprite-rotation-90: - shard-dg2: NOTRUN -> [SKIP][99] ([i915#4235]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_rotation_crc@sprite-rotation-90.html * igt@kms_tiled_display@basic-test-pattern: - shard-dg1: NOTRUN -> [SKIP][100] ([i915#8623]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@kms_tiled_display@basic-test-pattern.html * igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1: - shard-snb: NOTRUN -> [FAIL][101] ([i915#9196]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-snb1/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html * igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1: - shard-tglu: [PASS][102] -> [FAIL][103] ([i915#9196]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html * igt@kms_writeback@writeback-pixel-formats: - shard-dg2: NOTRUN -> [SKIP][104] ([i915#2437]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@kms_writeback@writeback-pixel-formats.html * igt@perf_pmu@busy-idle-check-all@vcs0: - shard-dg2: NOTRUN -> [FAIL][105] ([i915#4349]) +2 other tests fail [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@perf_pmu@busy-idle-check-all@vcs0.html - shard-mtlp: NOTRUN -> [FAIL][106] ([i915#4349]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@perf_pmu@busy-idle-check-all@vcs0.html * igt@prime_vgem@basic-gtt: - shard-dg2: NOTRUN -> [SKIP][107] ([i915#3708] / [i915#4077]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-2/igt@prime_vgem@basic-gtt.html * igt@prime_vgem@fence-flip-hang: - shard-dg2: NOTRUN -> [SKIP][108] ([i915#3708]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@prime_vgem@fence-flip-hang.html - shard-mtlp: NOTRUN -> [SKIP][109] ([i915#3708]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@prime_vgem@fence-flip-hang.html * igt@tools_test@sysfs_l3_parity: - shard-dg2: NOTRUN -> [SKIP][110] ([i915#4818]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@tools_test@sysfs_l3_parity.html * igt@v3d/v3d_job_submission@array-job-submission: - shard-dg2: NOTRUN -> [SKIP][111] ([i915#2575]) +9 other tests skip [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-1/igt@v3d/v3d_job_submission@array-job-submission.html * igt@v3d/v3d_submit_cl@single-out-sync: - shard-mtlp: NOTRUN -> [SKIP][112] ([i915#2575]) +2 other tests skip [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@v3d/v3d_submit_cl@single-out-sync.html * igt@vc4/vc4_create_bo@create-bo-4096: - shard-dg2: NOTRUN -> [SKIP][113] ([i915#7711]) +4 other tests skip [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-6/igt@vc4/vc4_create_bo@create-bo-4096.html - shard-mtlp: NOTRUN -> [SKIP][114] ([i915#7711]) +1 other test skip [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@vc4/vc4_create_bo@create-bo-4096.html * igt@vc4/vc4_mmap@mmap-bo: - shard-dg1: NOTRUN -> [SKIP][115] ([i915#7711]) +1 other test skip [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-18/igt@vc4/vc4_mmap@mmap-bo.html #### Possible fixes #### * igt@gem_lmem_swapping@smem-oom@lmem0: - shard-dg1: [TIMEOUT][116] ([i915#5493]) -> [PASS][117] [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-dg1-18/igt@gem_lmem_swapping@smem-oom@lmem0.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0: - shard-mtlp: [FAIL][118] ([i915#5138]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-tglu: [FAIL][120] ([i915#3743]) -> [PASS][121] +1 other test pass [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-tglu-9/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-tglu-4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [FAIL][122] ([i915#2346]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@forked-bo@all-pipes: - shard-mtlp: [DMESG-WARN][124] ([i915#2017]) -> [PASS][125] [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-mtlp-4/igt@kms_cursor_legacy@forked-bo@all-pipes.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-3/igt@kms_cursor_legacy@forked-bo@all-pipes.html * igt@kms_flip@flip-vs-suspend@b-edp1: - shard-mtlp: [FAIL][126] ([fdo#103375]) -> [PASS][127] +10 other tests pass [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-mtlp-8/igt@kms_flip@flip-vs-suspend@b-edp1.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-8/igt@kms_flip@flip-vs-suspend@b-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move: - shard-dg2: [FAIL][128] ([i915#6880]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html * {igt@kms_pm_rpm@modeset-lpsp-stress-no-wait}: - shard-dg2: [SKIP][130] ([i915#9519]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-dg2-1/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-10/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html * igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1: - shard-mtlp: [FAIL][132] ([i915#9196]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-c-edp-1.html * igt@perf@enable-disable@0-rcs0: - shard-dg2: [FAIL][134] ([i915#8724]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-dg2-11/igt@perf@enable-disable@0-rcs0.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-5/igt@perf@enable-disable@0-rcs0.html * igt@perf_pmu@busy-double-start@rcs0: - shard-mtlp: [FAIL][136] ([i915#4349]) -> [PASS][137] +1 other test pass [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-mtlp-4/igt@perf_pmu@busy-double-start@rcs0.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-3/igt@perf_pmu@busy-double-start@rcs0.html #### Warnings #### * igt@kms_async_flips@crc@pipe-b-edp-1: - shard-mtlp: [FAIL][138] ([i915#8247]) -> [DMESG-FAIL][139] ([i915#8561]) +1 other test dmesg-fail [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-mtlp-7/igt@kms_async_flips@crc@pipe-b-edp-1.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-mtlp-3/igt@kms_async_flips@crc@pipe-b-edp-1.html * igt@kms_psr@psr2_primary_blt: - shard-dg2: [SKIP][140] ([i915#9673] / [i915#9732]) -> [SKIP][141] ([i915#9673] / [i915#9736]) +1 other test skip [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-dg2-1/igt@kms_psr@psr2_primary_blt.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-11/igt@kms_psr@psr2_primary_blt.html * igt@perf@non-zero-reason@0-rcs0: - shard-dg2: [FAIL][142] ([i915#7484]) -> [FAIL][143] ([i915#9100]) [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13962/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6187]: https://gitlab.freedesktop.org/drm/intel/issues/6187 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805 [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247 [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428 [i915#8430]: https://gitlab.freedesktop.org/drm/intel/issues/8430 [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555 [i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561 [i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709 [i915#8724]: https://gitlab.freedesktop.org/drm/intel/issues/8724 [i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810 [i915#9100]: https://gitlab.freedesktop.org/drm/intel/issues/9100 [i915#9196]: https://gitlab.freedesktop.org/drm/intel/issues/9196 [i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275 [i915#9310]: https://gitlab.freedesktop.org/drm/intel/issues/9310 [i915#9340]: https://gitlab.freedesktop.org/drm/intel/issues/9340 [i915#9423]: https://gitlab.freedesktop.org/drm/intel/issues/9423 [i915#9519]: https://gitlab.freedesktop.org/drm/intel/issues/9519 [i915#9521]: https://gitlab.freedesktop.org/drm/intel/issues/9521 [i915#9606]: https://gitlab.freedesktop.org/drm/intel/issues/9606 [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673 [i915#9683]: https://gitlab.freedesktop.org/drm/intel/issues/9683 [i915#9685]: https://gitlab.freedesktop.org/drm/intel/issues/9685 [i915#9723]: https://gitlab.freedesktop.org/drm/intel/issues/9723 [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732 [i915#9736]: https://gitlab.freedesktop.org/drm/intel/issues/9736 Build changes ------------- * Linux: CI_DRM_13962 -> Patchwork_127206v1 * Piglit: None -> piglit_4509 CI-20190529: 20190529 CI_DRM_13962: 6915556fe478277b884730a627ad8ae1f4ab9efa @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7614: c7298ec108dc1c861c9a2593e973648ad9b420b4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_127206v1: 6915556fe478277b884730a627ad8ae1f4ab9efa @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_127206v1/index.html [-- Attachment #2: Type: text/html, Size: 48522 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs 2023-12-01 16:11 ` Hans de Goede @ 2023-12-04 9:42 ` Jani Nikula -1 siblings, 0 replies; 8+ messages in thread From: Jani Nikula @ 2023-12-04 9:42 UTC (permalink / raw) To: Hans de Goede, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Ville Syrjälä Cc: Andy Shevchenko, Hans de Goede, intel-gfx, dri-devel On Fri, 01 Dec 2023, Hans de Goede <hdegoede@redhat.com> wrote: > soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent > and use devm_gpiod_get() for all GPIOs. > > This allows removing the intel_dsi_vbt_gpio_cleanup() function, > which only function was to put the GPIO-descriptors. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Jani Nikula <jani.nikula@intel.com> > --- > Note this applies on top of Andy's recent GPIO rework series which > has just landed in drm-intel-next > --- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 17 ++--------------- > drivers/gpu/drm/i915/display/intel_dsi_vbt.h | 1 - > drivers/gpu/drm/i915/display/vlv_dsi.c | 10 +--------- > 3 files changed, 3 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > index 275d0218394c..a5d7fc8418c9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > @@ -922,7 +922,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) > gpiod_add_lookup_table(gpiod_lookup_table); > > if (want_panel_gpio) { > - intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags); > + intel_dsi->gpio_panel = devm_gpiod_get(dev->dev, "panel", flags); > if (IS_ERR(intel_dsi->gpio_panel)) { > drm_err(&dev_priv->drm, > "Failed to own gpio for panel control\n"); > @@ -932,7 +932,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) > > if (want_backlight_gpio) { > intel_dsi->gpio_backlight = > - gpiod_get(dev->dev, "backlight", flags); > + devm_gpiod_get(dev->dev, "backlight", flags); > if (IS_ERR(intel_dsi->gpio_backlight)) { > drm_err(&dev_priv->drm, > "Failed to own gpio for backlight control\n"); > @@ -943,16 +943,3 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) > if (gpiod_lookup_table) > gpiod_remove_lookup_table(gpiod_lookup_table); > } > - > -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi) > -{ > - if (intel_dsi->gpio_panel) { > - gpiod_put(intel_dsi->gpio_panel); > - intel_dsi->gpio_panel = NULL; > - } > - > - if (intel_dsi->gpio_backlight) { > - gpiod_put(intel_dsi->gpio_backlight); > - intel_dsi->gpio_backlight = NULL; > - } > -} > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h > index 468d873fab1a..3462fcc760e6 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h > @@ -13,7 +13,6 @@ struct intel_dsi; > > bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); > void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); > -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); > void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, > enum mipi_seq seq_id); > void intel_dsi_log_params(struct intel_dsi *intel_dsi); > diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c > index 5bda97c96810..9b33b8a74d64 100644 > --- a/drivers/gpu/drm/i915/display/vlv_dsi.c > +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c > @@ -1532,16 +1532,8 @@ static void intel_dsi_unprepare(struct intel_encoder *encoder) > } > } > > -static void intel_dsi_encoder_destroy(struct drm_encoder *encoder) > -{ > - struct intel_dsi *intel_dsi = enc_to_intel_dsi(to_intel_encoder(encoder)); > - > - intel_dsi_vbt_gpio_cleanup(intel_dsi); > - intel_encoder_destroy(encoder); > -} > - > static const struct drm_encoder_funcs intel_dsi_funcs = { > - .destroy = intel_dsi_encoder_destroy, > + .destroy = intel_encoder_destroy, > }; > > static enum drm_mode_status vlv_dsi_mode_valid(struct drm_connector *connector, -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs @ 2023-12-04 9:42 ` Jani Nikula 0 siblings, 0 replies; 8+ messages in thread From: Jani Nikula @ 2023-12-04 9:42 UTC (permalink / raw) To: Hans de Goede, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Ville Syrjälä Cc: Andy Shevchenko, Hans de Goede, intel-gfx, dri-devel On Fri, 01 Dec 2023, Hans de Goede <hdegoede@redhat.com> wrote: > soc_gpio_set_value() already uses devm_gpiod_get(), lets be consistent > and use devm_gpiod_get() for all GPIOs. > > This allows removing the intel_dsi_vbt_gpio_cleanup() function, > which only function was to put the GPIO-descriptors. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Jani Nikula <jani.nikula@intel.com> > --- > Note this applies on top of Andy's recent GPIO rework series which > has just landed in drm-intel-next > --- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 17 ++--------------- > drivers/gpu/drm/i915/display/intel_dsi_vbt.h | 1 - > drivers/gpu/drm/i915/display/vlv_dsi.c | 10 +--------- > 3 files changed, 3 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > index 275d0218394c..a5d7fc8418c9 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > @@ -922,7 +922,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) > gpiod_add_lookup_table(gpiod_lookup_table); > > if (want_panel_gpio) { > - intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags); > + intel_dsi->gpio_panel = devm_gpiod_get(dev->dev, "panel", flags); > if (IS_ERR(intel_dsi->gpio_panel)) { > drm_err(&dev_priv->drm, > "Failed to own gpio for panel control\n"); > @@ -932,7 +932,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) > > if (want_backlight_gpio) { > intel_dsi->gpio_backlight = > - gpiod_get(dev->dev, "backlight", flags); > + devm_gpiod_get(dev->dev, "backlight", flags); > if (IS_ERR(intel_dsi->gpio_backlight)) { > drm_err(&dev_priv->drm, > "Failed to own gpio for backlight control\n"); > @@ -943,16 +943,3 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on) > if (gpiod_lookup_table) > gpiod_remove_lookup_table(gpiod_lookup_table); > } > - > -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi) > -{ > - if (intel_dsi->gpio_panel) { > - gpiod_put(intel_dsi->gpio_panel); > - intel_dsi->gpio_panel = NULL; > - } > - > - if (intel_dsi->gpio_backlight) { > - gpiod_put(intel_dsi->gpio_backlight); > - intel_dsi->gpio_backlight = NULL; > - } > -} > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h > index 468d873fab1a..3462fcc760e6 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.h > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.h > @@ -13,7 +13,6 @@ struct intel_dsi; > > bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id); > void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on); > -void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi); > void intel_dsi_vbt_exec_sequence(struct intel_dsi *intel_dsi, > enum mipi_seq seq_id); > void intel_dsi_log_params(struct intel_dsi *intel_dsi); > diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c > index 5bda97c96810..9b33b8a74d64 100644 > --- a/drivers/gpu/drm/i915/display/vlv_dsi.c > +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c > @@ -1532,16 +1532,8 @@ static void intel_dsi_unprepare(struct intel_encoder *encoder) > } > } > > -static void intel_dsi_encoder_destroy(struct drm_encoder *encoder) > -{ > - struct intel_dsi *intel_dsi = enc_to_intel_dsi(to_intel_encoder(encoder)); > - > - intel_dsi_vbt_gpio_cleanup(intel_dsi); > - intel_encoder_destroy(encoder); > -} > - > static const struct drm_encoder_funcs intel_dsi_funcs = { > - .destroy = intel_dsi_encoder_destroy, > + .destroy = intel_encoder_destroy, > }; > > static enum drm_mode_status vlv_dsi_mode_valid(struct drm_connector *connector, -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-04 13:53 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-01 16:11 [Intel-gfx] [PATCH] drm/i915/dsi: Use devm_gpiod_get() for all GPIOs Hans de Goede 2023-12-01 16:11 ` Hans de Goede 2023-12-01 16:26 ` [Intel-gfx] " Andy Shevchenko 2023-12-01 16:26 ` Andy Shevchenko 2023-12-02 2:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2023-12-03 5:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2023-12-04 9:42 ` [Intel-gfx] [PATCH] " Jani Nikula 2023-12-04 9:42 ` Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.