From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Danilo Krummrich" <dakr@redhat.com>,
airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
sarah.walker@imgtec.com, donald.robson@imgtec.com,
boris.brezillon@collabora.com, christian.koenig@amd.com,
faith@gfxstrand.net
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a VM / BO combination
Date: Tue, 31 Oct 2023 13:45:54 +0200 [thread overview]
Message-ID: <87zfzz3thp.fsf@intel.com> (raw)
In-Reply-To: <f00a4975cf32c3ae28124343a2c994acda083829.camel@linux.intel.com>
On Tue, 31 Oct 2023, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote:
> On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote:
>> + * Returns: a pointer to the &drm_gpuvm_bo on success, NULL on
>
> Still needs s/Returns:/Return:/g
FWIW, both work to accommodate the variance across the kernel, although
I think only the latter is documented and recommended. It's also the
most popular:
10577 Return
3596 Returns
1104 RETURN
568 return
367 returns
352 RETURNS
1 RETURNs
BR,
Jani.
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Danilo Krummrich" <dakr@redhat.com>,
airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
sarah.walker@imgtec.com, donald.robson@imgtec.com,
boris.brezillon@collabora.com, christian.koenig@amd.com,
faith@gfxstrand.net
Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a VM / BO combination
Date: Tue, 31 Oct 2023 13:45:54 +0200 [thread overview]
Message-ID: <87zfzz3thp.fsf@intel.com> (raw)
In-Reply-To: <f00a4975cf32c3ae28124343a2c994acda083829.camel@linux.intel.com>
On Tue, 31 Oct 2023, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote:
> On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote:
>> + * Returns: a pointer to the &drm_gpuvm_bo on success, NULL on
>
> Still needs s/Returns:/Return:/g
FWIW, both work to accommodate the variance across the kernel, although
I think only the latter is documented and recommended. It's also the
most popular:
10577 Return
3596 Returns
1104 RETURN
568 return
367 returns
352 RETURNS
1 RETURNs
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-31 11:46 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 20:16 [Nouveau] [PATCH drm-misc-next v7 0/7] [RFC] DRM GPUVM features Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 1/7] drm/gpuvm: convert WARN() to drm_WARN() variants Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-24 8:45 ` [Nouveau] " Christian König
2023-10-24 8:45 ` Christian König
2023-10-24 8:45 ` Christian König
2023-10-24 12:16 ` [Nouveau] " Danilo Krummrich
2023-10-24 12:16 ` Danilo Krummrich
2023-10-24 12:16 ` Danilo Krummrich
2023-10-31 10:08 ` [Nouveau] " Thomas Hellström
2023-10-31 10:08 ` Thomas Hellström
2023-10-31 10:08 ` Thomas Hellström
2023-10-31 16:47 ` [Nouveau] " Danilo Krummrich
2023-10-31 16:47 ` Danilo Krummrich
2023-10-31 16:47 ` Danilo Krummrich
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 2/7] drm/gpuvm: add common dma-resv per struct drm_gpuvm Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 3/7] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a VM / BO combination Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-31 10:32 ` [Nouveau] " Thomas Hellström
2023-10-31 10:32 ` Thomas Hellström
2023-10-31 10:32 ` Thomas Hellström
2023-10-31 11:45 ` Jani Nikula [this message]
2023-10-31 11:45 ` Jani Nikula
2023-10-31 16:30 ` [Nouveau] " Danilo Krummrich
2023-10-31 16:30 ` Danilo Krummrich
2023-10-31 16:50 ` [Nouveau] " Thomas Hellström
2023-10-31 16:50 ` Thomas Hellström
2023-10-31 17:43 ` [Nouveau] " Danilo Krummrich
2023-10-31 17:43 ` Danilo Krummrich
2023-10-31 17:38 ` [Nouveau] " Danilo Krummrich
2023-10-31 17:38 ` Danilo Krummrich
2023-11-01 16:38 ` [Nouveau] " Thomas Hellström
2023-11-01 16:38 ` Thomas Hellström
2023-11-01 17:21 ` [Nouveau] " Danilo Krummrich
2023-11-01 17:21 ` Danilo Krummrich
2023-11-01 19:45 ` [Nouveau] " Thomas Hellström
2023-11-01 19:45 ` Thomas Hellström
2023-11-01 20:46 ` [Nouveau] " Danilo Krummrich
2023-11-01 20:46 ` Danilo Krummrich
2023-10-31 11:25 ` [Nouveau] " Thomas Hellström
2023-10-31 11:25 ` Thomas Hellström
2023-10-31 11:25 ` Thomas Hellström
2023-10-31 16:39 ` [Nouveau] " Danilo Krummrich
2023-10-31 16:39 ` Danilo Krummrich
2023-10-31 16:39 ` Danilo Krummrich
2023-10-31 16:45 ` [Nouveau] " Thomas Hellström
2023-10-31 16:45 ` Thomas Hellström
2023-10-31 16:45 ` Thomas Hellström
2023-10-31 17:52 ` [Nouveau] " Danilo Krummrich
2023-10-31 17:52 ` Danilo Krummrich
2023-10-31 17:52 ` Danilo Krummrich
2023-11-01 9:41 ` [Nouveau] " Thomas Hellström
2023-11-01 9:41 ` Thomas Hellström
2023-11-01 9:41 ` Thomas Hellström
2023-11-01 9:56 ` [Nouveau] " Thomas Hellström
2023-11-01 9:56 ` Thomas Hellström
2023-11-01 9:56 ` Thomas Hellström
2023-11-01 17:23 ` [Nouveau] " Danilo Krummrich
2023-11-01 17:23 ` Danilo Krummrich
2023-11-01 17:23 ` Danilo Krummrich
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 5/7] drm/gpuvm: track/lock/validate external/evicted objects Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-31 11:34 ` [Nouveau] " Thomas Hellström
2023-10-31 11:34 ` Thomas Hellström
2023-10-31 11:34 ` Thomas Hellström
2023-10-31 16:41 ` [Nouveau] " Danilo Krummrich
2023-10-31 16:41 ` Danilo Krummrich
2023-10-31 16:41 ` Danilo Krummrich
2023-10-31 16:52 ` [Nouveau] " Thomas Hellström
2023-10-31 16:52 ` Thomas Hellström
2023-10-31 16:52 ` Thomas Hellström
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 6/7] drm/nouveau: make use of the GPUVM's shared dma-resv Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` [Nouveau] [PATCH drm-misc-next v7 7/7] drm/nouveau: use GPUVM common infrastructure Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-23 20:16 ` Danilo Krummrich
2023-10-31 12:38 ` [PATCH drm-misc-next v7 0/7] [RFC] DRM GPUVM features Boris Brezillon
2023-10-31 12:38 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfzz3thp.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith@gfxstrand.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=sarah.walker@imgtec.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.