[Intel-xe] [PATCH 0/2] Fix two issues pointed by LKP

[Intel-xe] [PATCH 0/2] Fix two issues pointed by LKP

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

LKP reported two issues on Xe driver:

1. the Kconfig dependencies are wrong for non-X86 archs;
2. xe_display_misc has a non-static function without a prototype,
   which isn't used anywhere.

Address both issues to close https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/

Mauro Carvalho Chehab (2):
  misc: mei: fix Kconfig dependencies
  drm: xe: xe_display_misc: fix build with W=1

 drivers/gpu/drm/xe/display/xe_display_misc.c | 2 +-
 drivers/misc/mei/gsc_proxy/Kconfig           | 1 +
 drivers/misc/mei/hdcp/Kconfig                | 1 +
 drivers/misc/mei/pxp/Kconfig                 | 1 +
 4 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.41.0

[Intel-xe] [PATCH 1/2] misc: mei: fix Kconfig dependencies

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The dependency chain for INTEL_MEI is not properly addressed, as
reported by LKP:

   WARNING: unmet direct dependencies detected for INTEL_MEI_ME
   Depends on [n]: X86 && PCI [=y]
   Selected by [y]:
   - INTEL_MEI_HDCP [=y] && (DRM_I915 [=n] || DRM_XE [=y])

Basically, all symbols selecting INTEL_MEI shall also depends on
both X86 and PCI.

Add such dependency, as otherwise the dependencies won't be
properly followed.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 drivers/misc/mei/gsc_proxy/Kconfig | 1 +
 drivers/misc/mei/hdcp/Kconfig      | 1 +
 drivers/misc/mei/pxp/Kconfig       | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/misc/mei/gsc_proxy/Kconfig b/drivers/misc/mei/gsc_proxy/Kconfig
index 5f68d9f3d691..6053ebbf536d 100644
--- a/drivers/misc/mei/gsc_proxy/Kconfig
+++ b/drivers/misc/mei/gsc_proxy/Kconfig
@@ -4,6 +4,7 @@
 config INTEL_MEI_GSC_PROXY
 	tristate "Intel GSC Proxy services of ME Interface"
 	select INTEL_MEI_ME
+	depends on X86 && PCI
 	depends on DRM_I915
 	help
          MEI Support for GSC Proxy Services on Intel platforms.
diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
index 2ac9148988d4..a5e8d3e9fc92 100644
--- a/drivers/misc/mei/hdcp/Kconfig
+++ b/drivers/misc/mei/hdcp/Kconfig
@@ -4,6 +4,7 @@
 config INTEL_MEI_HDCP
 	tristate "Intel HDCP2.2 services of ME Interface"
 	select INTEL_MEI_ME
+	depends on X86 && PCI
 	depends on DRM_I915 || DRM_XE
 	help
 	  MEI Support for HDCP2.2 Services on Intel platforms.
diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
index 4029b96afc04..3acc05fea744 100644
--- a/drivers/misc/mei/pxp/Kconfig
+++ b/drivers/misc/mei/pxp/Kconfig
@@ -4,6 +4,7 @@
 #
 config INTEL_MEI_PXP
 	tristate "Intel PXP services of ME Interface"
+	depends on X86 && PCI
 	select INTEL_MEI_ME
 	depends on DRM_I915
 	help
-- 
2.41.0

Re: [Intel-xe] [PATCH 1/2] misc: mei: fix Kconfig dependencies

[Francois Dugast]

On Fri, Oct 20, 2023 at 09:32:14AM +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> The dependency chain for INTEL_MEI is not properly addressed, as
> reported by LKP:
> 
>    WARNING: unmet direct dependencies detected for INTEL_MEI_ME
>    Depends on [n]: X86 && PCI [=y]
>    Selected by [y]:
>    - INTEL_MEI_HDCP [=y] && (DRM_I915 [=n] || DRM_XE [=y])
> 
> Basically, all symbols selecting INTEL_MEI shall also depends on
> both X86 and PCI.
> 
> Add such dependency, as otherwise the dependencies won't be
> properly followed.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> ---
>  drivers/misc/mei/gsc_proxy/Kconfig | 1 +
>  drivers/misc/mei/hdcp/Kconfig      | 1 +
>  drivers/misc/mei/pxp/Kconfig       | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/misc/mei/gsc_proxy/Kconfig b/drivers/misc/mei/gsc_proxy/Kconfig
> index 5f68d9f3d691..6053ebbf536d 100644
> --- a/drivers/misc/mei/gsc_proxy/Kconfig
> +++ b/drivers/misc/mei/gsc_proxy/Kconfig
> @@ -4,6 +4,7 @@
>  config INTEL_MEI_GSC_PROXY
>  	tristate "Intel GSC Proxy services of ME Interface"
>  	select INTEL_MEI_ME
> +	depends on X86 && PCI
>  	depends on DRM_I915
>  	help
>           MEI Support for GSC Proxy Services on Intel platforms.
> diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
> index 2ac9148988d4..a5e8d3e9fc92 100644
> --- a/drivers/misc/mei/hdcp/Kconfig
> +++ b/drivers/misc/mei/hdcp/Kconfig
> @@ -4,6 +4,7 @@
>  config INTEL_MEI_HDCP
>  	tristate "Intel HDCP2.2 services of ME Interface"
>  	select INTEL_MEI_ME
> +	depends on X86 && PCI
>  	depends on DRM_I915 || DRM_XE
>  	help
>  	  MEI Support for HDCP2.2 Services on Intel platforms.
> diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> index 4029b96afc04..3acc05fea744 100644
> --- a/drivers/misc/mei/pxp/Kconfig
> +++ b/drivers/misc/mei/pxp/Kconfig
> @@ -4,6 +4,7 @@
>  #
>  config INTEL_MEI_PXP
>  	tristate "Intel PXP services of ME Interface"
> +	depends on X86 && PCI
>  	select INTEL_MEI_ME
>  	depends on DRM_I915
>  	help
> -- 
> 2.41.0
> 

Re: [Intel-xe] [PATCH 1/2] misc: mei: fix Kconfig dependencies

[Jani Nikula]

On Fri, 20 Oct 2023, Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> The dependency chain for INTEL_MEI is not properly addressed, as
> reported by LKP:
>
>    WARNING: unmet direct dependencies detected for INTEL_MEI_ME
>    Depends on [n]: X86 && PCI [=y]
>    Selected by [y]:
>    - INTEL_MEI_HDCP [=y] && (DRM_I915 [=n] || DRM_XE [=y])
>
> Basically, all symbols selecting INTEL_MEI shall also depends on
> both X86 and PCI.
>
> Add such dependency, as otherwise the dependencies won't be
> properly followed.

This must *not* be applied to drm-xe-next directly. Get it merged
upstream first, and backport with cherry-pick -x annotation if needed.

BR,
Jani

>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  drivers/misc/mei/gsc_proxy/Kconfig | 1 +
>  drivers/misc/mei/hdcp/Kconfig      | 1 +
>  drivers/misc/mei/pxp/Kconfig       | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/drivers/misc/mei/gsc_proxy/Kconfig b/drivers/misc/mei/gsc_proxy/Kconfig
> index 5f68d9f3d691..6053ebbf536d 100644
> --- a/drivers/misc/mei/gsc_proxy/Kconfig
> +++ b/drivers/misc/mei/gsc_proxy/Kconfig
> @@ -4,6 +4,7 @@
>  config INTEL_MEI_GSC_PROXY
>  	tristate "Intel GSC Proxy services of ME Interface"
>  	select INTEL_MEI_ME
> +	depends on X86 && PCI
>  	depends on DRM_I915
>  	help
>           MEI Support for GSC Proxy Services on Intel platforms.
> diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
> index 2ac9148988d4..a5e8d3e9fc92 100644
> --- a/drivers/misc/mei/hdcp/Kconfig
> +++ b/drivers/misc/mei/hdcp/Kconfig
> @@ -4,6 +4,7 @@
>  config INTEL_MEI_HDCP
>  	tristate "Intel HDCP2.2 services of ME Interface"
>  	select INTEL_MEI_ME
> +	depends on X86 && PCI
>  	depends on DRM_I915 || DRM_XE
>  	help
>  	  MEI Support for HDCP2.2 Services on Intel platforms.
> diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> index 4029b96afc04..3acc05fea744 100644
> --- a/drivers/misc/mei/pxp/Kconfig
> +++ b/drivers/misc/mei/pxp/Kconfig
> @@ -4,6 +4,7 @@
>  #
>  config INTEL_MEI_PXP
>  	tristate "Intel PXP services of ME Interface"
> +	depends on X86 && PCI
>  	select INTEL_MEI_ME
>  	depends on DRM_I915
>  	help

-- 
Jani Nikula, Intel

[Intel-xe] [PATCH 2/2] drm: xe: xe_display_misc: fix build with W=1

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

As reported by LKP, when the Xe driver is built with W=1, a warning
will be produced:

	>> drivers/gpu/drm/xe/display/xe_display_misc.c:10:14: warning: no previous prototype for 'intel_gmch_vga_set_decode' [-Wmissing-prototypes]
	      10 | unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
	         |              ^~~~~~~~~~~~~~~~~~~~~~~~~

Currently, such function is just a stub, not used anywhere.
Yet, it is declared there without a prototype. As this is just a
reminder for something that will be implemented in the future,
change it to static and add __maybe_unused to disable compiler
warnings on it.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 drivers/gpu/drm/xe/display/xe_display_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c b/drivers/gpu/drm/xe/display/xe_display_misc.c
index 81ff97e704ea..53a53e500a09 100644
--- a/drivers/gpu/drm/xe/display/xe_display_misc.c
+++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
@@ -7,7 +7,7 @@
 
 struct pci_dev;
 
-unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
+__maybe_unused static unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
 {
 	/* ToDo: Implement the actual handling of vga decode */
 	return 0;
-- 
2.41.0

Re: [Intel-xe] [PATCH 2/2] drm: xe: xe_display_misc: fix build with W=1

[Jani Nikula]

On Fri, 20 Oct 2023, Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> As reported by LKP, when the Xe driver is built with W=1, a warning
> will be produced:
>
> 	>> drivers/gpu/drm/xe/display/xe_display_misc.c:10:14: warning: no previous prototype for 'intel_gmch_vga_set_decode' [-Wmissing-prototypes]
> 	      10 | unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
> 	         |              ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Currently, such function is just a stub, not used anywhere.
> Yet, it is declared there without a prototype. As this is just a
> reminder for something that will be implemented in the future,
> change it to static and add __maybe_unused to disable compiler
> warnings on it.

Please just include the header with the prototype.

BR,
Jani.

>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  drivers/gpu/drm/xe/display/xe_display_misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c b/drivers/gpu/drm/xe/display/xe_display_misc.c
> index 81ff97e704ea..53a53e500a09 100644
> --- a/drivers/gpu/drm/xe/display/xe_display_misc.c
> +++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
> @@ -7,7 +7,7 @@
>  
>  struct pci_dev;
>  
> -unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
> +__maybe_unused static unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
>  {
>  	/* ToDo: Implement the actual handling of vga decode */
>  	return 0;

-- 
Jani Nikula, Intel

[Intel-xe] ✗ CI.Patch_applied: failure for Fix two issues pointed by LKP

[Patchwork]

== Series Details ==

Series: Fix two issues pointed by LKP
URL   : https://patchwork.freedesktop.org/series/125383/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 4354e27ef drm/xe: Simplify xe_res_get_buddy()
=== git am output follows ===
Applying: misc: mei: fix Kconfig dependencies
Applying: drm: xe: xe_display_misc: fix build with W=1