From: Michael Ellerman <mpe@ellerman.id.au>
To: Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [powerpc:next-test 21/79] arch/powerpc/platforms/powermac/feature.c:137:19: error: unused function 'simple_feature_tweak'
Date: Sat, 19 Aug 2023 17:04:07 +1000 [thread overview]
Message-ID: <87zg2nv7h4.fsf@mail.lhotse> (raw)
In-Reply-To: <6173828b-183c-490d-abca-bdc72221bafc@app.fastmail.com>
"Arnd Bergmann" <arnd@arndb.de> writes:
> On Fri, Aug 18, 2023, at 09:59, kernel test robot wrote:
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
>> next-test
>> head: c56963d48343b50998bacc6df949217c950163e3
>> commit: 54f30b83fe627453082f15d83d7820b28b2d24bb [21/79] powerpc:
>> address missing-prototypes warnings
>
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new
>> version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes:
>> https://lore.kernel.org/oe-kbuild-all/202308181501.AR5HMDWC-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>>> arch/powerpc/platforms/powermac/feature.c:137:19: error: unused function 'simple_feature_tweak' [-Werror,-Wunused-function]
>> static inline int simple_feature_tweak(struct device_node *node, int type,
>> ^
>
> This looks unrelated to my patch, but is easily addressed by marking
> the function __maybe_unused. The warning is triggered by clang specific
> behavior that treats inline functions in .c files differently, see
> 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions
> for W=1 build")
It looks like it can just move inside the nearby ifdef. Will send a
patch.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
oe-kbuild-all@lists.linux.dev
Subject: Re: [powerpc:next-test 21/79] arch/powerpc/platforms/powermac/feature.c:137:19: error: unused function 'simple_feature_tweak'
Date: Sat, 19 Aug 2023 17:04:07 +1000 [thread overview]
Message-ID: <87zg2nv7h4.fsf@mail.lhotse> (raw)
In-Reply-To: <6173828b-183c-490d-abca-bdc72221bafc@app.fastmail.com>
"Arnd Bergmann" <arnd@arndb.de> writes:
> On Fri, Aug 18, 2023, at 09:59, kernel test robot wrote:
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
>> next-test
>> head: c56963d48343b50998bacc6df949217c950163e3
>> commit: 54f30b83fe627453082f15d83d7820b28b2d24bb [21/79] powerpc:
>> address missing-prototypes warnings
>
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new
>> version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes:
>> https://lore.kernel.org/oe-kbuild-all/202308181501.AR5HMDWC-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>>> arch/powerpc/platforms/powermac/feature.c:137:19: error: unused function 'simple_feature_tweak' [-Werror,-Wunused-function]
>> static inline int simple_feature_tweak(struct device_node *node, int type,
>> ^
>
> This looks unrelated to my patch, but is easily addressed by marking
> the function __maybe_unused. The warning is triggered by clang specific
> behavior that treats inline functions in .c files differently, see
> 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions
> for W=1 build")
It looks like it can just move inside the nearby ifdef. Will send a
patch.
cheers
next prev parent reply other threads:[~2023-08-19 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 7:59 [powerpc:next-test 21/79] arch/powerpc/platforms/powermac/feature.c:137:19: error: unused function 'simple_feature_tweak' kernel test robot
2023-08-18 7:59 ` kernel test robot
2023-08-18 12:36 ` Arnd Bergmann
2023-08-18 12:36 ` Arnd Bergmann
2023-08-19 7:04 ` Michael Ellerman [this message]
2023-08-19 7:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg2nv7h4.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.