All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
	"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Luca Coelho <luciano.coelho@intel.com>,
	DRI <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v5] drm/i915: avoid flush_scheduled_work() usage
Date: Sat, 10 Jun 2023 10:01:28 +0300	[thread overview]
Message-ID: <87zg57pzqv.fsf@intel.com> (raw)
In-Reply-To: <47c5fe59-faec-8eb6-7f3c-f76a4bb0f3cb@I-love.SAKURA.ne.jp>

On Mon, 22 May 2023, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a
> macro") says, flush_scheduled_work() is dangerous and will be forbidden.
>
> i915 became the last flush_scheduled_work() user, but developers cannot
> find time for auditing which work items does this flush_scheduled_work()
> need to wait.
>
> Therefore, for now let's start with blind/mechanical conversion within
> the whole drivers/gpu/drm/i915/ directory, based on an assumption that
> i915 does not need to wait for work items outside of this directory.

I'll note also here that I've just pushed Luca's series [1] to switch
i915 to internal device specific workqueues, for the same effect as this
one.


Thanks,
Jani.


[1] https://patchwork.freedesktop.org/series/118947/


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: "Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
	"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Luca Coelho <luciano.coelho@intel.com>,
	DRI <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v5] drm/i915: avoid flush_scheduled_work() usage
Date: Sat, 10 Jun 2023 10:01:28 +0300	[thread overview]
Message-ID: <87zg57pzqv.fsf@intel.com> (raw)
In-Reply-To: <47c5fe59-faec-8eb6-7f3c-f76a4bb0f3cb@I-love.SAKURA.ne.jp>

On Mon, 22 May 2023, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a
> macro") says, flush_scheduled_work() is dangerous and will be forbidden.
>
> i915 became the last flush_scheduled_work() user, but developers cannot
> find time for auditing which work items does this flush_scheduled_work()
> need to wait.
>
> Therefore, for now let's start with blind/mechanical conversion within
> the whole drivers/gpu/drm/i915/ directory, based on an assumption that
> i915 does not need to wait for work items outside of this directory.

I'll note also here that I've just pushed Luca's series [1] to switch
i915 to internal device specific workqueues, for the same effect as this
one.


Thanks,
Jani.


[1] https://patchwork.freedesktop.org/series/118947/


-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-06-10  7:01 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 10:11 [Intel-gfx] [PATCH] drm/i915: avoid flush_scheduled_work() usage Tetsuo Handa
2023-03-03 10:11 ` Tetsuo Handa
2023-03-03 10:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-03-03 11:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-03 12:49 ` [Intel-gfx] [PATCH] " Tetsuo Handa
2023-03-03 12:49   ` Tetsuo Handa
2023-03-06 11:05   ` [Intel-gfx] " Jani Nikula
2023-03-06 11:05     ` Jani Nikula
2023-03-06 11:17     ` [Intel-gfx] " Tetsuo Handa
2023-03-06 11:17       ` Tetsuo Handa
2023-03-06 18:56 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-03-14 11:21 ` [Intel-gfx] [PATCH v2] " Tetsuo Handa
2023-03-14 11:21   ` Tetsuo Handa
2023-03-15 10:47   ` [Intel-gfx] " Luca Coelho
2023-04-14 10:01     ` Tetsuo Handa
2023-04-14 10:13       ` Jani Nikula
2023-04-14 10:52         ` Tetsuo Handa
2023-04-16  7:45           ` Daniel Vetter
2023-04-16  7:45             ` Daniel Vetter
2023-05-03 10:06             ` Jani Nikula
2023-05-03 10:06               ` Jani Nikula
2023-05-03 14:00   ` [Intel-gfx] [PATCH v3] " Tetsuo Handa
2023-05-03 14:00     ` Tetsuo Handa
2023-05-18 14:44     ` [Intel-gfx] [PATCH v4] " Tetsuo Handa
2023-05-18 14:44       ` Tetsuo Handa
2023-05-19  8:02       ` [Intel-gfx] " Tvrtko Ursulin
2023-05-22 10:59       ` [Intel-gfx] [PATCH v5] " Tetsuo Handa
2023-05-22 10:59         ` Tetsuo Handa
2023-06-10  7:01         ` Jani Nikula [this message]
2023-06-10  7:01           ` Jani Nikula
2023-05-03 14:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid flush_scheduled_work() usage (rev3) Patchwork
2023-05-03 14:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-04 19:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid flush_scheduled_work() usage (rev4) Patchwork
2023-05-04 20:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-05  6:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-05-18 15:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid flush_scheduled_work() usage (rev5) Patchwork
2023-05-18 15:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-22 13:54 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: avoid flush_scheduled_work() usage (rev6) Patchwork
2023-05-22 13:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: " Patchwork
2023-05-22 13:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-05-22 13:55 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-05-22 14:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-22 20:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg57pzqv.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=luciano.coelho@intel.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=tvrtko.ursulin@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.