All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Jianlong Huang <jianlong.huang@starfivetech.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells
Date: Thu, 12 Jan 2023 21:28:16 +0200	[thread overview]
Message-ID: <87zganpn69.fsf@tarshish> (raw)
In-Reply-To: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Thu, Jan 12 2023, Andy Shevchenko wrote:

> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

baruch

> ---
>  drivers/pinctrl/pinctrl-digicolor.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index cc3546fc4610..05213261b8a4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap)
>  	chip->set		= dc_gpio_set;
>  	chip->base		= -1;
>  	chip->ngpio		= PINS_COUNT;
> -	chip->of_gpio_n_cells	= 2;
>  
>  	spin_lock_init(&pmap->lock);


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Jianlong Huang <jianlong.huang@starfivetech.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells
Date: Thu, 12 Jan 2023 21:28:16 +0200	[thread overview]
Message-ID: <87zganpn69.fsf@tarshish> (raw)
In-Reply-To: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Thu, Jan 12 2023, Andy Shevchenko wrote:

> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Baruch Siach <baruch@tkos.co.il>

baruch

> ---
>  drivers/pinctrl/pinctrl-digicolor.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index cc3546fc4610..05213261b8a4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap)
>  	chip->set		= dc_gpio_set;
>  	chip->base		= -1;
>  	chip->ngpio		= PINS_COUNT;
> -	chip->of_gpio_n_cells	= 2;
>  
>  	spin_lock_init(&pmap->lock);


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-01-12 19:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 18:48 [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-12 18:48 ` Andy Shevchenko
2023-01-12 18:48 ` [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Andy Shevchenko
2023-01-12 18:48   ` Andy Shevchenko
2023-01-12 19:30   ` Baruch Siach
2023-01-12 19:30     ` Baruch Siach
2023-01-16 14:06   ` Linus Walleij
2023-01-16 14:06     ` Linus Walleij
2023-01-12 19:28 ` Baruch Siach [this message]
2023-01-12 19:28   ` [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zganpn69.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jianlong.huang@starfivetech.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.