All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Victor Hassan <victor@allwinnertech.com>,
	daniel.lezcano@linaro.org, wens@csie.org,
	jernej.skrabec@gmail.com, samuel@sholland.org, maxime@cerno.tech
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [RESEND] clocksource: sun4i: Fix the bug that tick_resume stucks
Date: Sat, 15 Oct 2022 11:04:47 +0200	[thread overview]
Message-ID: <87zgdxa24w.ffs@tglx> (raw)
In-Reply-To: <20221009032507.39145-1-victor@allwinnertech.com>

On Sun, Oct 09 2022 at 11:25, Victor Hassan wrote:
> Currently syscore_resume() will stuck on tick_resume().

This lacks a clear explanation of the problem, i.e. WHY the current
implementation is not working.

> Fix this by changing  `.tick_resume` from
> sun4i_clkevt_shutdown() to a new function sun4i_tick_resume().
>  
> -static struct timer_of to = {
> -	.flags = TIMER_OF_IRQ | TIMER_OF_CLOCK | TIMER_OF_BASE,

How is switching from a statically allocated struct to a runtime
allocated struct related to the problem?

Thanks,

        tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Victor Hassan <victor@allwinnertech.com>,
	daniel.lezcano@linaro.org, wens@csie.org,
	jernej.skrabec@gmail.com, samuel@sholland.org, maxime@cerno.tech
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [RESEND] clocksource: sun4i: Fix the bug that tick_resume stucks
Date: Sat, 15 Oct 2022 11:04:47 +0200	[thread overview]
Message-ID: <87zgdxa24w.ffs@tglx> (raw)
In-Reply-To: <20221009032507.39145-1-victor@allwinnertech.com>

On Sun, Oct 09 2022 at 11:25, Victor Hassan wrote:
> Currently syscore_resume() will stuck on tick_resume().

This lacks a clear explanation of the problem, i.e. WHY the current
implementation is not working.

> Fix this by changing  `.tick_resume` from
> sun4i_clkevt_shutdown() to a new function sun4i_tick_resume().
>  
> -static struct timer_of to = {
> -	.flags = TIMER_OF_IRQ | TIMER_OF_CLOCK | TIMER_OF_BASE,

How is switching from a statically allocated struct to a runtime
allocated struct related to the problem?

Thanks,

        tglx

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-10-15  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09  3:25 [RESEND] clocksource: sun4i: Fix the bug that tick_resume stucks Victor Hassan
2022-10-09  3:25 ` Victor Hassan
2022-10-12 21:46 ` Jernej Škrabec
2022-10-12 21:46   ` Jernej Škrabec
2022-10-15  9:04 ` Thomas Gleixner [this message]
2022-10-15  9:04   ` Thomas Gleixner
2022-10-25  6:23 ` Victor Hassan
2022-10-25  6:23   ` Victor Hassan
2022-10-26  8:21   ` maxime
2022-10-26  8:21     ` maxime
  -- strict thread matches above, loose matches on Subject: below --
2022-09-28  8:48 Victor Hassan
2022-09-28  8:48 ` Victor Hassan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgdxa24w.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=maxime@cerno.tech \
    --cc=samuel@sholland.org \
    --cc=victor@allwinnertech.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.