* [PATCH] drm/i915/guc: Check ctx while waiting for response
@ 2022-06-02 17:21 ` Zhanjun Dong
0 siblings, 0 replies; 15+ messages in thread
From: Zhanjun Dong @ 2022-06-02 17:21 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Zhanjun Dong
We are seeing error message of "No response for request". Some cases happened
while waiting for response and reset/suspend action was triggered. In this
case, no response is not an error, active requests will be cancelled.
This patch will handle this condition and change the error message into
debug message.
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
index f01325cd1b62..a30a388877e2 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
@@ -467,7 +467,7 @@ static int ct_write(struct intel_guc_ct *ct,
* * 0 response received (status is valid)
* * -ETIMEDOUT no response within hardcoded timeout
*/
-static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
+static int wait_for_ct_request_update(struct ct_request *req, u32 *status, struct intel_guc_ct *ct)
{
int err;
@@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
#define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
#define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
#define done \
- (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
+ (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
GUC_HXG_ORIGIN_GUC)
err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
if (err)
err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
#undef done
+ if (!intel_guc_ct_enabled(ct))
+ err = -ECANCELED;
*status = req->status;
return err;
@@ -703,11 +705,15 @@ static int ct_send(struct intel_guc_ct *ct,
intel_guc_notify(ct_to_guc(ct));
- err = wait_for_ct_request_update(&request, status);
+ err = wait_for_ct_request_update(&request, status, ct);
g2h_release_space(ct, GUC_CTB_HXG_MSG_MAX_LEN);
if (unlikely(err)) {
- CT_ERROR(ct, "No response for request %#x (fence %u)\n",
- action[0], request.fence);
+ if (unlikely(err == ECANCELED))
+ CT_DEBUG(ct, "Request %#x (fence %u) cancelled as CTB is disabled\n",
+ action[0], request.fence);
+ else
+ CT_ERROR(ct, "No response for request %#x (fence %u)\n",
+ action[0], request.fence);
goto unlink;
}
@@ -771,8 +777,9 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
ret = ct_send(ct, action, len, response_buf, response_buf_size, &status);
if (unlikely(ret < 0)) {
- CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
- action[0], ERR_PTR(ret), status);
+ if (likely(ret != ECANCELED))
+ CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
+ action[0], ERR_PTR(ret), status);
} else if (unlikely(ret)) {
CT_DEBUG(ct, "send action %#x returned %d (%#x)\n",
action[0], ret, ret);
--
2.36.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
(?)
@ 2022-06-02 17:44 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-06-02 17:44 UTC (permalink / raw)
To: Zhanjun Dong; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Check ctx while waiting for response
URL : https://patchwork.freedesktop.org/series/104672/
State : warning
== Summary ==
Error: dim checkpatch failed
b5d975cdaf5a drm/i915/guc: Check ctx while waiting for response
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6:
We are seeing error message of "No response for request". Some cases happened
-:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#56: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:713:
+ CT_DEBUG(ct, "Request %#x (fence %u) cancelled as CTB is disabled\n",
+ action[0], request.fence);
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:716:
+ CT_ERROR(ct, "No response for request %#x (fence %u)\n",
+ action[0], request.fence);
-:71: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#71: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:782:
+ CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
+ action[0], ERR_PTR(ret), status);
total: 0 errors, 1 warnings, 3 checks, 52 lines checked
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
(?)
(?)
@ 2022-06-02 18:05 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-06-02 18:05 UTC (permalink / raw)
To: Zhanjun Dong; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6605 bytes --]
== Series Details ==
Series: drm/i915/guc: Check ctx while waiting for response
URL : https://patchwork.freedesktop.org/series/104672/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11721 -> Patchwork_104672v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/index.html
Participating hosts (43 -> 40)
------------------------------
Missing (3): fi-rkl-11600 bat-jsl-1 bat-adlp-4
Known issues
------------
Here are the changes found in Patchwork_104672v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][1] -> [DMESG-WARN][2] ([i915#62]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][3] -> [INCOMPLETE][4] ([i915#4785])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- fi-ivb-3770: [PASS][5] -> [INCOMPLETE][6] ([i915#3303] / [i915#5370])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][7] ([i915#3921])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [PASS][8] -> [INCOMPLETE][9] ([i915#3921])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][10] -> [DMESG-FAIL][11] ([i915#4528])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-pnv-d510/igt@i915_selftest@live@requests.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@ring_submission:
- fi-cfl-8109u: [PASS][12] -> [DMESG-WARN][13] ([i915#5904]) +36 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
* igt@kms_busy@basic@flip:
- fi-snb-2520m: [PASS][14] -> [DMESG-WARN][15] ([i915#1982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-snb-2520m/igt@kms_busy@basic@flip.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-snb-2520m/igt@kms_busy@basic@flip.html
* igt@kms_flip@basic-plain-flip@c-dp2:
- fi-cfl-8109u: [PASS][16] -> [DMESG-WARN][17] ([i915#165]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp2.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-cfl-8109u/igt@kms_flip@basic-plain-flip@c-dp2.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-cfl-8109u: [PASS][18] -> [DMESG-WARN][19] ([i915#165] / [i915#62]) +15 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][20] ([fdo#109271] / [i915#4312] / [i915#5594])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-hsw-4770/igt@runner@aborted.html
- fi-ivb-3770: NOTRUN -> [FAIL][21] ([fdo#109271] / [i915#4312])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-ivb-3770/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@gem_contexts:
- fi-bdw-5557u: [INCOMPLETE][22] ([i915#5502]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5370]: https://gitlab.freedesktop.org/drm/intel/issues/5370
[i915#5502]: https://gitlab.freedesktop.org/drm/intel/issues/5502
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Build changes
-------------
* Linux: CI_DRM_11721 -> Patchwork_104672v1
CI-20190529: 20190529
CI_DRM_11721: ee8c8067f279c483c105c5731becae9dbe9b1383 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6505: edb1a467fb622b23b927e28ff603fa43851fea97 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_104672v1: ee8c8067f279c483c105c5731becae9dbe9b1383 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
13b08b19a57d drm/i915/guc: Check ctx while waiting for response
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/index.html
[-- Attachment #2: Type: text/html, Size: 7678 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
` (2 preceding siblings ...)
(?)
@ 2022-06-02 22:58 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-06-02 22:58 UTC (permalink / raw)
To: Zhanjun Dong; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 50648 bytes --]
== Series Details ==
Series: drm/i915/guc: Check ctx while waiting for response
URL : https://patchwork.freedesktop.org/series/104672/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11721_full -> Patchwork_104672v1_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_104672v1_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_104672v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_104672v1_full:
### IGT changes ###
#### Warnings ####
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [DMESG-FAIL][1] ([i915#180]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl4/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@core_hotunplug@unbind-rebind:
- {shard-dg1}: [PASS][3] -> [SKIP][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-dg1-16/igt@core_hotunplug@unbind-rebind.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-dg1-15/igt@core_hotunplug@unbind-rebind.html
* igt@kms_prime@basic-crc:
- {shard-dg1}: NOTRUN -> [SKIP][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-dg1-15/igt@kms_prime@basic-crc.html
* igt@kms_setmode@basic@pipe-a-edp-1:
- {shard-rkl}: NOTRUN -> [FAIL][6] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_setmode@basic@pipe-a-edp-1.html
Known issues
------------
Here are the changes found in Patchwork_104672v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][7] ([i915#4991])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl9/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][8] ([i915#4793])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][9] -> [TIMEOUT][10] ([i915#3070])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb5/igt@gem_eio@unwedge-stress.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb5/igt@gem_eio@unwedge-stress.html
- shard-tglb: [PASS][11] -> [TIMEOUT][12] ([i915#3063])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-tglb7/igt@gem_eio@unwedge-stress.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][13] -> [SKIP][14] ([i915#4525])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb4/igt@gem_exec_balancer@parallel-bb-first.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][15] ([i915#6141])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-tglb6/igt@gem_exec_fair@basic-none-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][20] -> [FAIL][21] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb7/igt@gem_exec_fair@basic-pace@bcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb4/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][22] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-wb-ro-default:
- shard-snb: [PASS][23] -> [SKIP][24] ([fdo#109271]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-snb5/igt@gem_exec_flush@basic-wb-ro-default.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-snb6/igt@gem_exec_flush@basic-wb-ro-default.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([i915#4939]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl4/igt@gem_exec_suspend@basic-s3@smem.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl7/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_lmem_swapping@parallel-random:
- shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk3/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl1/igt@gem_lmem_swapping@parallel-random-verify-ccs.html
* igt@gem_media_vme:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#284])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@gem_media_vme.html
* igt@gem_userptr_blits@coherency-unsync:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3297])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@gem_userptr_blits@coherency-unsync.html
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][31] ([i915#4991])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][32] ([i915#3318])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl7/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#5129])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl9/igt@gem_workarounds@suspend-resume-fd.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl1/igt@gem_workarounds@suspend-resume-fd.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][37] -> [DMESG-WARN][38] ([i915#5566] / [i915#716])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk9/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-chained:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#2527] / [i915#2856])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@gen9_exec_parse@bb-chained.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#5286])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#111615])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3689]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk3/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689] / [i915#3886])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#6095])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_chamelium@dp-hpd-enable-disable-mode:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk3/igt@kms_chamelium@dp-hpd-enable-disable-mode.html
* igt@kms_chamelium@hdmi-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +7 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl4/igt@kms_chamelium@hdmi-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl2/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_color@pipe-d-invalid-gamma-lut-sizes:
- shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271]) +40 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk3/igt@kms_color@pipe-d-invalid-gamma-lut-sizes.html
* igt@kms_color_chamelium@pipe-a-ctm-negative:
- shard-kbl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@kms_color_chamelium@pipe-a-ctm-negative.html
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-snb4/igt@kms_color_chamelium@pipe-a-degamma.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109279] / [i915#3359])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3319])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#3359])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271]) +22 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-iclb: [PASS][60] -> [FAIL][61] ([i915#5072])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109274] / [fdo#111825])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-skl: NOTRUN -> [SKIP][63] ([fdo#109271]) +135 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#4911])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-glk9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#2587])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][67] -> [DMESG-WARN][68] ([i915#180]) +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109280] / [fdo#111825]) +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271]) +12 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][74] ([fdo#108145] / [i915#265]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][75] -> [SKIP][76] ([i915#5176]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][77] -> [SKIP][78] ([i915#5235]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb6/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl7/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-p010:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl1/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-tglb: NOTRUN -> [FAIL][81] ([i915#132] / [i915#3467])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][84] -> [FAIL][85] ([i915#5639])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-glk3/igt@perf@polling-parameterized.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk2/igt@perf@polling-parameterized.html
* igt@prime_nv_pcopy@test3_2:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109291])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@prime_nv_pcopy@test3_2.html
* igt@prime_nv_pcopy@test3_5:
- shard-snb: NOTRUN -> [SKIP][87] ([fdo#109271]) +71 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-snb4/igt@prime_nv_pcopy@test3_5.html
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2994])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl3/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@sema-50:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#2994])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@sysfs_clients@sema-50.html
* igt@sysfs_clients@split-10:
- shard-skl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2994]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl9/igt@sysfs_clients@split-10.html
* igt@sysfs_heartbeat_interval@mixed@bcs0:
- shard-skl: [PASS][91] -> [FAIL][92] ([i915#1731])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl7/igt@sysfs_heartbeat_interval@mixed@bcs0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl7/igt@sysfs_heartbeat_interval@mixed@bcs0.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [PASS][93] -> [WARN][94] ([i915#4055])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl7/igt@sysfs_heartbeat_interval@mixed@rcs0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl7/igt@sysfs_heartbeat_interval@mixed@rcs0.html
#### Possible fixes ####
* igt@drm_read@short-buffer-block:
- {shard-rkl}: [SKIP][95] ([i915#4098]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-1/igt@drm_read@short-buffer-block.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@drm_read@short-buffer-block.html
* igt@fbdev@info:
- {shard-rkl}: [SKIP][97] ([i915#2582]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-5/igt@fbdev@info.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@fbdev@info.html
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][99] ([i915#658]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb6/igt@feature_discovery@psr2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][101] ([i915#4525]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb6/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb4/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][105] ([i915#2842]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-rkl}: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_flush@basic-wb-ro-before-default:
- shard-snb: [SKIP][109] ([fdo#109271]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-snb6/igt@gem_exec_flush@basic-wb-ro-before-default.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-snb2/igt@gem_exec_flush@basic-wb-ro-before-default.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-tglb: [INCOMPLETE][111] ([i915#5843] / [i915#5966]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-tglb7/igt@gem_exec_whisper@basic-fds-forked-all.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb3/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][113] ([i915#2190]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-tglb7/igt@gem_huc_copy@huc-copy.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-tglb2/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-rkl}: [SKIP][115] ([i915#1850]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-1/igt@gem_mmap_wc@set-cache-level.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@gem_mmap_wc@set-cache-level.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][117] ([i915#5566] / [i915#716]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-glk4/igt@gen9_exec_parse@allowed-all.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-glk3/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_dc@dc5-psr:
- {shard-rkl}: [SKIP][119] ([i915#658]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-2/igt@i915_pm_dc@dc5-psr.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][121] ([i915#4281]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@fences-dpms:
- {shard-rkl}: [SKIP][123] ([i915#1849]) -> [PASS][124] +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-1/igt@i915_pm_rpm@fences-dpms.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@i915_pm_rpm@fences-dpms.html
* igt@i915_pm_rpm@system-suspend:
- {shard-dg1}: [FAIL][125] ([fdo#103375]) -> [PASS][126] +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-dg1-19/igt@i915_pm_rpm@system-suspend.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-dg1-19/igt@i915_pm_rpm@system-suspend.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][127] ([i915#2521]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- {shard-rkl}: [SKIP][129] ([i915#1845] / [i915#4098]) -> [PASS][130] +28 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-2/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_color@pipe-a-ctm-red-to-blue:
- {shard-rkl}: [SKIP][131] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][132] +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-1/igt@kms_color@pipe-a-ctm-red-to-blue.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_color@pipe-a-ctm-red-to-blue.html
* igt@kms_color@pipe-c-invalid-degamma-lut-sizes:
- {shard-rkl}: [SKIP][133] ([i915#4070]) -> [PASS][134] +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-6/igt@kms_color@pipe-c-invalid-degamma-lut-sizes.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-5/igt@kms_color@pipe-c-invalid-degamma-lut-sizes.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-random:
- {shard-rkl}: [SKIP][135] ([fdo#112022] / [i915#4070]) -> [PASS][136] +4 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-256x256-random.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x256-random.html
* igt@kms_cursor_edge_walk@pipe-b-256x256-bottom-edge:
- {shard-rkl}: [SKIP][137] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][138] +4 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-2/igt@kms_cursor_edge_walk@pipe-b-256x256-bottom-edge.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-b-256x256-bottom-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic:
- {shard-rkl}: [SKIP][139] ([fdo#111825] / [i915#4070]) -> [PASS][140] +5 similar issues
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-5/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html
* igt@kms_draw_crc@draw-method-rgb565-render-xtiled:
- {shard-rkl}: [SKIP][141] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][142] +3 similar issues
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-5/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-render-xtiled.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [DMESG-WARN][143] ([i915#180]) -> [PASS][144] +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [SKIP][145] ([i915#3701]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_invalid_mode@uint-max-clock:
- {shard-rkl}: [SKIP][147] ([i915#4278]) -> [PASS][148] +1 similar issue
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-1/igt@kms_invalid_mode@uint-max-clock.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_invalid_mode@uint-max-clock.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- {shard-rkl}: [SKIP][149] ([i915#1849] / [i915#4098]) -> [PASS][150] +29 similar issues
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-2/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: [DMESG-WARN][151] ([i915#180]) -> [PASS][152] +4 similar issues
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][153] ([fdo#108145] / [i915#265]) -> [PASS][154] +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][155] -> [PASS][156] +2 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@cursor_blt:
- {shard-rkl}: [SKIP][157] ([i915#1072]) -> [PASS][158] +2 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-5/igt@kms_psr@cursor_blt.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_psr@cursor_blt.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][159] ([fdo#109441]) -> [PASS][160] +2 similar issues
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb6/igt@kms_psr@psr2_primary_mmap_gtt.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_universal_plane@universal-plane-pipe-a-sanity:
- {shard-rkl}: [SKIP][161] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-rkl-5/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][163] ([i915#6117]) -> [SKIP][164] ([i915#4525])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb1/igt@gem_exec_balancer@parallel-ordering.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb3/igt@gem_exec_balancer@parallel-ordering.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled:
- shard-skl: [SKIP][165] ([fdo#109271]) -> [SKIP][166] ([fdo#109271] / [i915#1888]) +1 similar issue
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-skl10/igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][167] ([i915#658]) -> [SKIP][168] ([i915#2920])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb6/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][169] ([fdo#111068] / [i915#658]) -> [SKIP][170] ([i915#2920]) +1 similar issue
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][171] ([i915#2920]) -> [SKIP][172] ([fdo#111068] / [i915#658]) +1 similar issue
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][173], [FAIL][174], [FAIL][175], [FAIL][176], [FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180], [FAIL][181], [FAIL][182], [FAIL][183]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][184], [FAIL][185], [FAIL][186], [FAIL][187], [FAIL][188], [FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194], [FAIL][195], [FAIL][196]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl1/igt@runner@aborted.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl7/igt@runner@aborted.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl7/igt@runner@aborted.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl7/igt@runner@aborted.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl6/igt@runner@aborted.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl1/igt@runner@aborted.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl6/igt@runner@aborted.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl7/igt@runner@aborted.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl4/igt@runner@aborted.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl6/igt@runner@aborted.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11721/shard-kbl6/igt@runner@aborted.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl4/igt@runner@aborted.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl7/igt@runner@aborted.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl6/igt@runner@aborted.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl7/igt@runner@aborted.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl6/igt@runner@aborted.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl6/igt@runner@aborted.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl6/igt@runner@aborted.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl4/igt@runner@aborted.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl7/igt@runner@aborted.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@runner@aborted.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl4/igt@runner@aborted.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl1/igt@runner@aborted.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/shard-kbl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4055]: https://gitlab.freedesktop.org/drm/intel/issues/4055
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4793]: https://gitlab.freedesktop.org/drm/intel/issues/4793
[i915#4807]: https://gitlab.freedesktop.org/drm/intel/issues/4807
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5129]: https://gitlab.freedesktop.org/drm/intel/issues/5129
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5266]: https://gitlab.freedesktop.org/drm/intel/issues/5266
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
[i915#5843]: https://gitlab.freedesktop.org/drm/intel/issues/5843
[i915#5966]: https://gitlab.freedesktop.org/drm/intel/issues/5966
[i915#6054]: https://gitlab.freedesktop.org/drm/intel/issues/6054
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6139]: https://gitlab.freedesktop.org/drm/intel/issues/6139
[i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140
[i915#6141]: https://gitlab.freedesktop.org/drm/intel/issues/6141
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
Build changes
-------------
* Linux: CI_DRM_11721 -> Patchwork_104672v1
CI-20190529: 20190529
CI_DRM_11721: ee8c8067f279c483c105c5731becae9dbe9b1383 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6505: edb1a467fb622b23b927e28ff603fa43851fea97 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_104672v1: ee8c8067f279c483c105c5731becae9dbe9b1383 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104672v1/index.html
[-- Attachment #2: Type: text/html, Size: 55851 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
` (3 preceding siblings ...)
(?)
@ 2022-06-14 15:34 ` Teres Alexis, Alan Previn
-1 siblings, 0 replies; 15+ messages in thread
From: Teres Alexis, Alan Previn @ 2022-06-14 15:34 UTC (permalink / raw)
To: Dong, Zhanjun, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Can't see anything wrong with this.
I consider this only a NIT, so feel : not sure if -ECANCELLED is reflective of the "ct service being temporarily down"
as opposed to the "requester cancelling". Perhaps a -EPIPE or -EAGAIN (if we got this far, we know we are probably mid-
reset) ?? (if not already used elsewhere along this callstack). Else :
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
...alan
On Thu, 2022-06-02 at 10:21 -0700, Zhanjun Dong wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message into
> debug message.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index f01325cd1b62..a30a388877e2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -467,7 +467,7 @@ static int ct_write(struct intel_guc_ct *ct,
> * * 0 response received (status is valid)
> * * -ETIMEDOUT no response within hardcoded timeout
> */
> -static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> +static int wait_for_ct_request_update(struct ct_request *req, u32 *status, struct intel_guc_ct *ct)
> {
> int err;
>
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
>
> *status = req->status;
> return err;
> @@ -703,11 +705,15 @@ static int ct_send(struct intel_guc_ct *ct,
>
> intel_guc_notify(ct_to_guc(ct));
>
> - err = wait_for_ct_request_update(&request, status);
> + err = wait_for_ct_request_update(&request, status, ct);
> g2h_release_space(ct, GUC_CTB_HXG_MSG_MAX_LEN);
> if (unlikely(err)) {
> - CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> - action[0], request.fence);
> + if (unlikely(err == ECANCELED))
> + CT_DEBUG(ct, "Request %#x (fence %u) cancelled as CTB is disabled\n",
> + action[0], request.fence);
> + else
> + CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> + action[0], request.fence);
> goto unlink;
> }
>
> @@ -771,8 +777,9 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
>
> ret = ct_send(ct, action, len, response_buf, response_buf_size, &status);
> if (unlikely(ret < 0)) {
> - CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> - action[0], ERR_PTR(ret), status);
> + if (likely(ret != ECANCELED))
> + CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> + action[0], ERR_PTR(ret), status);
> } else if (unlikely(ret)) {
> CT_DEBUG(ct, "send action %#x returned %d (%#x)\n",
> action[0], ret, ret);
> --
> 2.36.0
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
` (4 preceding siblings ...)
(?)
@ 2022-06-14 16:10 ` Michal Wajdeczko
-1 siblings, 0 replies; 15+ messages in thread
From: Michal Wajdeczko @ 2022-06-14 16:10 UTC (permalink / raw)
To: Zhanjun Dong, intel-gfx, dri-devel
On 02.06.2022 19:21, Zhanjun Dong wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message into
> debug message.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index f01325cd1b62..a30a388877e2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -467,7 +467,7 @@ static int ct_write(struct intel_guc_ct *ct,
> * * 0 response received (status is valid)
> * * -ETIMEDOUT no response within hardcoded timeout
> */
> -static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> +static int wait_for_ct_request_update(struct ct_request *req, u32 *status, struct intel_guc_ct *ct)
if you need to add "intel_guc_ct *ct" param then make it the first one
> {
> int err;
>
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
>
> *status = req->status;
> return err;
> @@ -703,11 +705,15 @@ static int ct_send(struct intel_guc_ct *ct,
>
> intel_guc_notify(ct_to_guc(ct));
>
> - err = wait_for_ct_request_update(&request, status);
> + err = wait_for_ct_request_update(&request, status, ct);
> g2h_release_space(ct, GUC_CTB_HXG_MSG_MAX_LEN);
> if (unlikely(err)) {
> - CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> - action[0], request.fence);
> + if (unlikely(err == ECANCELED))
you are looking for -ECANCELED
and I guess you can safely drop "unlikely" hint here
> + CT_DEBUG(ct, "Request %#x (fence %u) cancelled as CTB is disabled\n",
> + action[0], request.fence);
> + else
> + CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> + action[0], request.fence);
> goto unlink;
> }
>
> @@ -771,8 +777,9 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
>
> ret = ct_send(ct, action, len, response_buf, response_buf_size, &status);
> if (unlikely(ret < 0)) {
> - CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> - action[0], ERR_PTR(ret), status);
> + if (likely(ret != ECANCELED))
ditto
,Michal
> + CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> + action[0], ERR_PTR(ret), status);
> } else if (unlikely(ret)) {
> CT_DEBUG(ct, "send action %#x returned %d (%#x)\n",
> action[0], ret, ret);
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
@ 2022-06-14 16:21 ` Jani Nikula
-1 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-06-14 16:21 UTC (permalink / raw)
To: Zhanjun Dong, intel-gfx, dri-devel; +Cc: Zhanjun Dong
On Thu, 02 Jun 2022, Zhanjun Dong <zhanjun.dong@intel.com> wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message into
> debug message.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index f01325cd1b62..a30a388877e2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -467,7 +467,7 @@ static int ct_write(struct intel_guc_ct *ct,
> * * 0 response received (status is valid)
> * * -ETIMEDOUT no response within hardcoded timeout
> */
> -static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> +static int wait_for_ct_request_update(struct ct_request *req, u32 *status, struct intel_guc_ct *ct)
> {
> int err;
>
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
>
> *status = req->status;
> return err;
> @@ -703,11 +705,15 @@ static int ct_send(struct intel_guc_ct *ct,
>
> intel_guc_notify(ct_to_guc(ct));
>
> - err = wait_for_ct_request_update(&request, status);
> + err = wait_for_ct_request_update(&request, status, ct);
> g2h_release_space(ct, GUC_CTB_HXG_MSG_MAX_LEN);
> if (unlikely(err)) {
> - CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> - action[0], request.fence);
> + if (unlikely(err == ECANCELED))
I think you mean -ECANCELED, not ECANCELED.
Please drop the unlikely(). I no longer want to see a single unlikely()
or likely() added anywhere without proper performance
justification. They make the code harder to read, for no real benefit,
and people just cargo cult copy paste them everywhere. Moreover, nested
unlikely/likely is just silly.
> + CT_DEBUG(ct, "Request %#x (fence %u) cancelled as CTB is disabled\n",
> + action[0], request.fence);
> + else
> + CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> + action[0], request.fence);
> goto unlink;
> }
>
> @@ -771,8 +777,9 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
>
> ret = ct_send(ct, action, len, response_buf, response_buf_size, &status);
> if (unlikely(ret < 0)) {
> - CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> - action[0], ERR_PTR(ret), status);
> + if (likely(ret != ECANCELED))
Ditto for -ECANCELED and likely().
BR,
Jani.
> + CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> + action[0], ERR_PTR(ret), status);
> } else if (unlikely(ret)) {
> CT_DEBUG(ct, "send action %#x returned %d (%#x)\n",
> action[0], ret, ret);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
@ 2022-06-14 16:21 ` Jani Nikula
0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-06-14 16:21 UTC (permalink / raw)
To: Zhanjun Dong, intel-gfx, dri-devel; +Cc: Zhanjun Dong, Tvrtko Ursulin
On Thu, 02 Jun 2022, Zhanjun Dong <zhanjun.dong@intel.com> wrote:
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message into
> debug message.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index f01325cd1b62..a30a388877e2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -467,7 +467,7 @@ static int ct_write(struct intel_guc_ct *ct,
> * * 0 response received (status is valid)
> * * -ETIMEDOUT no response within hardcoded timeout
> */
> -static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> +static int wait_for_ct_request_update(struct ct_request *req, u32 *status, struct intel_guc_ct *ct)
> {
> int err;
>
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
>
> *status = req->status;
> return err;
> @@ -703,11 +705,15 @@ static int ct_send(struct intel_guc_ct *ct,
>
> intel_guc_notify(ct_to_guc(ct));
>
> - err = wait_for_ct_request_update(&request, status);
> + err = wait_for_ct_request_update(&request, status, ct);
> g2h_release_space(ct, GUC_CTB_HXG_MSG_MAX_LEN);
> if (unlikely(err)) {
> - CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> - action[0], request.fence);
> + if (unlikely(err == ECANCELED))
I think you mean -ECANCELED, not ECANCELED.
Please drop the unlikely(). I no longer want to see a single unlikely()
or likely() added anywhere without proper performance
justification. They make the code harder to read, for no real benefit,
and people just cargo cult copy paste them everywhere. Moreover, nested
unlikely/likely is just silly.
> + CT_DEBUG(ct, "Request %#x (fence %u) cancelled as CTB is disabled\n",
> + action[0], request.fence);
> + else
> + CT_ERROR(ct, "No response for request %#x (fence %u)\n",
> + action[0], request.fence);
> goto unlink;
> }
>
> @@ -771,8 +777,9 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
>
> ret = ct_send(ct, action, len, response_buf, response_buf_size, &status);
> if (unlikely(ret < 0)) {
> - CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> - action[0], ERR_PTR(ret), status);
> + if (likely(ret != ECANCELED))
Ditto for -ECANCELED and likely().
BR,
Jani.
> + CT_ERROR(ct, "Sending action %#x failed (%pe) status=%#X\n",
> + action[0], ERR_PTR(ret), status);
> } else if (unlikely(ret)) {
> CT_DEBUG(ct, "send action %#x returned %d (%#x)\n",
> action[0], ret, ret);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
2022-06-02 17:21 ` Zhanjun Dong
@ 2022-06-14 16:28 ` Dixit, Ashutosh
-1 siblings, 0 replies; 15+ messages in thread
From: Dixit, Ashutosh @ 2022-06-14 16:28 UTC (permalink / raw)
To: Zhanjun Dong; +Cc: intel-gfx, alan.previn.teres.alexis, dri-devel
On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
Hi Zhanjun,
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message into
> debug message.
IMO the patch title should be changed: which ctx are we checking while
waiting for response? Something like "check for ct enabled while waiting
for response"?
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
Also, I really don't like intel_guc_ct_enabled() being called in two
places. Is there a possibility that intel_guc_ct_enabled() can return false
in the first place (causing the wait to exit) and then return true in the
second place (so we don't return -ECANCELED)?
Is it possible to change the status of the request to something else from
intel_guc_ct_disable() (or wherever ct->enabled is set to false) rather
than introducing intel_guc_ct_enabled() checks here. Changing the status of
the request when CT goes down would cause the wait's to exit here. And then
we can check that special request status signifying CT went down?
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/guc: Check ctx while waiting for response
@ 2022-06-14 16:28 ` Dixit, Ashutosh
0 siblings, 0 replies; 15+ messages in thread
From: Dixit, Ashutosh @ 2022-06-14 16:28 UTC (permalink / raw)
To: Zhanjun Dong
Cc: intel-gfx, alan.previn.teres.alexis, dri-devel, michal.wajdeczko
On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
Hi Zhanjun,
> We are seeing error message of "No response for request". Some cases happened
> while waiting for response and reset/suspend action was triggered. In this
> case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message into
> debug message.
IMO the patch title should be changed: which ctx are we checking while
waiting for response? Something like "check for ct enabled while waiting
for response"?
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
Also, I really don't like intel_guc_ct_enabled() being called in two
places. Is there a possibility that intel_guc_ct_enabled() can return false
in the first place (causing the wait to exit) and then return true in the
second place (so we don't return -ECANCELED)?
Is it possible to change the status of the request to something else from
intel_guc_ct_disable() (or wherever ct->enabled is set to false) rather
than introducing intel_guc_ct_enabled() checks here. Changing the status of
the request when CT goes down would cause the wait's to exit here. And then
we can check that special request status signifying CT went down?
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
2022-06-14 16:28 ` Dixit, Ashutosh
@ 2022-06-14 18:42 ` Dong, Zhanjun
-1 siblings, 0 replies; 15+ messages in thread
From: Dong, Zhanjun @ 2022-06-14 18:42 UTC (permalink / raw)
To: Dixit, Ashutosh
Cc: intel-gfx@lists.freedesktop.org, Teres Alexis, Alan Previn,
dri-devel@lists.freedesktop.org
Thanks for all comments, I will update code and prepare for next version.
Regards,
Zhanjun
-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
Sent: June 14, 2022 12:28 PM
To: Dong, Zhanjun <zhanjun.dong@intel.com>
Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Teres Alexis, Alan Previn <alan.previn.teres.alexis@intel.com>; Wajdeczko, Michal <Michal.Wajdeczko@intel.com>
Subject: Re: [PATCH] drm/i915/guc: Check ctx while waiting for response
On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
Hi Zhanjun,
> We are seeing error message of "No response for request". Some cases
> happened while waiting for response and reset/suspend action was
> triggered. In this case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message
> into debug message.
IMO the patch title should be changed: which ctx are we checking while waiting for response? Something like "check for ct enabled while waiting for response"?
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct
> ct_request *req, u32 *status) #define
> GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10 #define
> GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000 #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN,
> +READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
Also, I really don't like intel_guc_ct_enabled() being called in two places. Is there a possibility that intel_guc_ct_enabled() can return false in the first place (causing the wait to exit) and then return true in the second place (so we don't return -ECANCELED)?
Is it possible to change the status of the request to something else from
intel_guc_ct_disable() (or wherever ct->enabled is set to false) rather than introducing intel_guc_ct_enabled() checks here. Changing the status of the request when CT goes down would cause the wait's to exit here. And then we can check that special request status signifying CT went down?
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH] drm/i915/guc: Check ctx while waiting for response
@ 2022-06-14 18:42 ` Dong, Zhanjun
0 siblings, 0 replies; 15+ messages in thread
From: Dong, Zhanjun @ 2022-06-14 18:42 UTC (permalink / raw)
To: Dixit, Ashutosh
Cc: intel-gfx@lists.freedesktop.org, Teres Alexis, Alan Previn,
dri-devel@lists.freedesktop.org, Wajdeczko, Michal
Thanks for all comments, I will update code and prepare for next version.
Regards,
Zhanjun
-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
Sent: June 14, 2022 12:28 PM
To: Dong, Zhanjun <zhanjun.dong@intel.com>
Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Teres Alexis, Alan Previn <alan.previn.teres.alexis@intel.com>; Wajdeczko, Michal <Michal.Wajdeczko@intel.com>
Subject: Re: [PATCH] drm/i915/guc: Check ctx while waiting for response
On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
Hi Zhanjun,
> We are seeing error message of "No response for request". Some cases
> happened while waiting for response and reset/suspend action was
> triggered. In this case, no response is not an error, active requests will be cancelled.
>
> This patch will handle this condition and change the error message
> into debug message.
IMO the patch title should be changed: which ctx are we checking while waiting for response? Something like "check for ct enabled while waiting for response"?
> @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct
> ct_request *req, u32 *status) #define
> GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10 #define
> GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000 #define done \
> - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN,
> +READ_ONCE(req->status)) == \
> GUC_HXG_ORIGIN_GUC)
> err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> if (err)
> err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> #undef done
> + if (!intel_guc_ct_enabled(ct))
> + err = -ECANCELED;
Also, I really don't like intel_guc_ct_enabled() being called in two places. Is there a possibility that intel_guc_ct_enabled() can return false in the first place (causing the wait to exit) and then return true in the second place (so we don't return -ECANCELED)?
Is it possible to change the status of the request to something else from
intel_guc_ct_disable() (or wherever ct->enabled is set to false) rather than introducing intel_guc_ct_enabled() checks here. Changing the status of the request when CT goes down would cause the wait's to exit here. And then we can check that special request status signifying CT went down?
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response
2022-06-14 16:28 ` Dixit, Ashutosh
@ 2022-06-14 20:01 ` Dixit, Ashutosh
-1 siblings, 0 replies; 15+ messages in thread
From: Dixit, Ashutosh @ 2022-06-14 20:01 UTC (permalink / raw)
To: Zhanjun Dong; +Cc: intel-gfx, dri-devel, alan.previn.teres.alexis
On Tue, 14 Jun 2022 09:28:14 -0700, Dixit, Ashutosh wrote:
> On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
> > @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> > #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> > #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> > #define done \
> > - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> > + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> > GUC_HXG_ORIGIN_GUC)
> > err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> > if (err)
> > err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> > #undef done
> > + if (!intel_guc_ct_enabled(ct))
> > + err = -ECANCELED;
>
> Also, I really don't like intel_guc_ct_enabled() being called in two
> places. Is there a possibility that intel_guc_ct_enabled() can return false
> in the first place (causing the wait to exit) and then return true in the
> second place (so we don't return -ECANCELED)?
>
> Is it possible to change the status of the request to something else from
> intel_guc_ct_disable() (or wherever ct->enabled is set to false) rather
> than introducing intel_guc_ct_enabled() checks here. Changing the status of
> the request when CT goes down would cause the wait's to exit here. And then
> we can check that special request status signifying CT went down?
I think there are free bits in the request status fields which can be
used. But setting the request status say from intel_guc_ct_enabled() might
not be straightforward since you have to locate waiting requests and also
there may be multiple such requests (waiting in different threads).
Maybe an easier way might be to do something like:
bool foo(ct, req)
{
if (!intel_guc_ct_enabled(ct)) {
req->status = CT_WENT_AWAY;
return true;
}
return false;
}
Now in your patch we can substitute foo() instead of
!intel_guc_ct_enabled(ct) so that we have:
#define done \
(foo() || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
GUC_HXG_ORIGIN_GUC)
And then check for req->status == CT_WENT_AWAY (most likely in ct_send()).
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH] drm/i915/guc: Check ctx while waiting for response
@ 2022-06-14 20:01 ` Dixit, Ashutosh
0 siblings, 0 replies; 15+ messages in thread
From: Dixit, Ashutosh @ 2022-06-14 20:01 UTC (permalink / raw)
To: Zhanjun Dong
Cc: intel-gfx, dri-devel, alan.previn.teres.alexis, michal.wajdeczko
On Tue, 14 Jun 2022 09:28:14 -0700, Dixit, Ashutosh wrote:
> On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote:
>
> > @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct ct_request *req, u32 *status)
> > #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10
> > #define GUC_CTB_RESPONSE_TIMEOUT_LONG_MS 1000
> > #define done \
> > - (FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> > + (!intel_guc_ct_enabled(ct) || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
> > GUC_HXG_ORIGIN_GUC)
> > err = wait_for_us(done, GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS);
> > if (err)
> > err = wait_for(done, GUC_CTB_RESPONSE_TIMEOUT_LONG_MS);
> > #undef done
> > + if (!intel_guc_ct_enabled(ct))
> > + err = -ECANCELED;
>
> Also, I really don't like intel_guc_ct_enabled() being called in two
> places. Is there a possibility that intel_guc_ct_enabled() can return false
> in the first place (causing the wait to exit) and then return true in the
> second place (so we don't return -ECANCELED)?
>
> Is it possible to change the status of the request to something else from
> intel_guc_ct_disable() (or wherever ct->enabled is set to false) rather
> than introducing intel_guc_ct_enabled() checks here. Changing the status of
> the request when CT goes down would cause the wait's to exit here. And then
> we can check that special request status signifying CT went down?
I think there are free bits in the request status fields which can be
used. But setting the request status say from intel_guc_ct_enabled() might
not be straightforward since you have to locate waiting requests and also
there may be multiple such requests (waiting in different threads).
Maybe an easier way might be to do something like:
bool foo(ct, req)
{
if (!intel_guc_ct_enabled(ct)) {
req->status = CT_WENT_AWAY;
return true;
}
return false;
}
Now in your patch we can substitute foo() instead of
!intel_guc_ct_enabled(ct) so that we have:
#define done \
(foo() || FIELD_GET(GUC_HXG_MSG_0_ORIGIN, READ_ONCE(req->status)) == \
GUC_HXG_ORIGIN_GUC)
And then check for req->status == CT_WENT_AWAY (most likely in ct_send()).
^ permalink raw reply [flat|nested] 15+ messages in thread