From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: John Harrison <john.c.harrison@intel.com>
Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Use drm_err instead of pr_err
Date: Tue, 07 Jun 2022 15:25:24 -0700 [thread overview]
Message-ID: <87zgiojeln.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <6fd4a9fa-5e02-a34f-7c8e-68c8f747e4fb@intel.com>
On Tue, 07 Jun 2022 15:23:17 -0700, John Harrison wrote:
>
> On 6/7/2022 15:07, Dixit, Ashutosh wrote:
> > On Tue, 07 Jun 2022 14:51:03 -0700, John.C.Harrison@Intel.com wrote:
> >> From: John Harrison <John.C.Harrison@Intel.com>
> >>
> >> Don't use pr_err in places where we have access to a struct_drm.
> > Seem to be many more pr_err's in selftests. Is there a reason why drm_err's
> > cannot be used in selftests (especially those using an i915 device)?
> > Thanks.
> I figured I'd start small and just do the gt/uc ones to being with as those
> are the ones that affect me.
>
> It sounds like the only reason to use pr_err is in the mock selftests where
> there is no easy access to a DRM structure. For everything else, there is
> no reason that I am aware of.
Fair enough:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: John Harrison <john.c.harrison@intel.com>
Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org
Subject: Re: [PATCH] drm/i915/guc: Use drm_err instead of pr_err
Date: Tue, 07 Jun 2022 15:25:24 -0700 [thread overview]
Message-ID: <87zgiojeln.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <6fd4a9fa-5e02-a34f-7c8e-68c8f747e4fb@intel.com>
On Tue, 07 Jun 2022 15:23:17 -0700, John Harrison wrote:
>
> On 6/7/2022 15:07, Dixit, Ashutosh wrote:
> > On Tue, 07 Jun 2022 14:51:03 -0700, John.C.Harrison@Intel.com wrote:
> >> From: John Harrison <John.C.Harrison@Intel.com>
> >>
> >> Don't use pr_err in places where we have access to a struct_drm.
> > Seem to be many more pr_err's in selftests. Is there a reason why drm_err's
> > cannot be used in selftests (especially those using an i915 device)?
> > Thanks.
> I figured I'd start small and just do the gt/uc ones to being with as those
> are the ones that affect me.
>
> It sounds like the only reason to use pr_err is in the mock selftests where
> there is no easy access to a DRM structure. For everything else, there is
> no reason that I am aware of.
Fair enough:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2022-06-07 22:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 21:51 [Intel-gfx] [PATCH] drm/i915/guc: Use drm_err instead of pr_err John.C.Harrison
2022-06-07 21:51 ` John.C.Harrison
2022-06-07 22:07 ` [Intel-gfx] " Dixit, Ashutosh
2022-06-07 22:07 ` Dixit, Ashutosh
2022-06-07 22:23 ` [Intel-gfx] " John Harrison
2022-06-07 22:23 ` John Harrison
2022-06-07 22:25 ` Dixit, Ashutosh [this message]
2022-06-07 22:25 ` Dixit, Ashutosh
2022-06-07 23:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2022-06-11 5:22 ` [Intel-gfx] [PATCH] " kernel test robot
2022-06-11 5:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgiojeln.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=DRI-Devel@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.