From: Juan Quintela <quintela@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] migration/compress: disable compress if failed to setup
Date: Mon, 27 Jan 2020 16:13:02 +0100 [thread overview]
Message-ID: <87zhe90w75.fsf@secure.laptop> (raw)
In-Reply-To: <20191012023932.1863-3-richardw.yang@linux.intel.com> (Wei Yang's message of "Sat, 12 Oct 2019 10:39:32 +0800")
Wei Yang <richardw.yang@linux.intel.com> wrote:
> In current logic, if compress_threads_save_setup() returns -1 the whole
> migration would fail, while we could handle it gracefully by disable
> compress.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Fully agree with Dave here.
If user asks for compression, and compression fails, we fail migration.
If user wants to continue without compression, it just have to disable
compression.
Thanks, Juan.
prev parent reply other threads:[~2020-01-27 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 2:39 [PATCH 0/2] migration/compress: refine the compress case Wei Yang
2019-10-12 2:39 ` [PATCH 1/2] migration/compress: compress QEMUFile is not writable Wei Yang
2019-11-07 11:59 ` Dr. David Alan Gilbert
2019-11-07 12:08 ` Wei Yang
2020-01-27 15:32 ` Juan Quintela
2019-10-12 2:39 ` [PATCH 2/2] migration/compress: disable compress if failed to setup Wei Yang
2019-11-07 12:11 ` Dr. David Alan Gilbert
2020-01-27 15:13 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhe90w75.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.