From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 7/7] drm/i915: Use Engine1 instance for gen11 pm interrupts
Date: Wed, 10 Apr 2019 11:20:25 +0300 [thread overview]
Message-ID: <87zhoy2rw6.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <155482720751.26510.9774396675061232618@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-04-09 17:13:10)
>> With gen11 the interrupt registers are shared between 2 engines,
>> with Engine1 instance being upper word and Engine0 instance being
>> lower. Annoyingly gen11 selected the pm interrupts to be in the
>> Engine1 instance.
>
> Sounds weird, but I can't fault the solution. The choice would either to
> have been shift pm_rps_events andadd gen11_pm_imr/_ier, so this patch
> looks to be the smaller delta.
Small wart added is one extra posting read on disabling.
I didn't like the under the hood shifting but the much
smaller delta was too tempting.
Perhaps a comment to the register definitions
would be warranted at minimum.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-10 8:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 16:13 [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Mika Kuoppala
2019-04-09 16:13 ` [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold Mika Kuoppala
2019-04-09 16:51 ` Michal Wajdeczko
2019-04-09 16:13 ` [PATCH 3/7] drm/i915/icl: Apply recommended rc6 idle hysteresis Mika Kuoppala
2019-04-09 16:16 ` Chris Wilson
2019-04-10 8:04 ` Mika Kuoppala
2019-04-09 16:13 ` [PATCH 4/7] drm/i915/icl: Enable media sampler powergate Mika Kuoppala
2019-04-09 16:34 ` Chris Wilson
2019-04-09 16:13 ` [PATCH 5/7] drm/i915/icl: Disable video turbo mode for rp control Mika Kuoppala
2019-04-09 16:32 ` Chris Wilson
2019-04-10 8:05 ` Mika Kuoppala
2019-04-09 16:13 ` [PATCH 6/7] drm/i915/icl: Handle rps interrupts without irq lock Mika Kuoppala
2019-04-09 16:21 ` Chris Wilson
2019-04-10 8:09 ` Mika Kuoppala
2019-04-09 16:13 ` [PATCH 7/7] drm/i915: Use Engine1 instance for gen11 pm interrupts Mika Kuoppala
2019-04-09 16:26 ` Chris Wilson
2019-04-10 8:20 ` Mika Kuoppala [this message]
2019-04-09 16:28 ` [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Chris Wilson
2019-04-09 16:57 ` Michal Wajdeczko
2019-04-09 17:04 ` Chris Wilson
2019-04-09 17:16 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] " Patchwork
2019-04-09 17:42 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-10 5:59 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-10 9:04 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhoy2rw6.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.