From: Baruch Siach <baruch@tkos.co.il>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-pwm@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/2] PCI: armada8k: don't toggle reset twice
Date: Thu, 10 Jan 2019 17:57:24 +0200 [thread overview]
Message-ID: <87zhs8h5ej.fsf@tarshish> (raw)
In-Reply-To: <20190110131912.GB29612@lunn.ch>
Hi Andrew,
On Thu, Jan 10 2019, Andrew Lunn wrote:
>> Sven Auhagen reported the same issue with Intel NIC attached to
>> mini-PCIe slots on a custom Armada 8K design.
>
> O.K. so that suggests the issue is on the Armada side.
>
>> How would you suggest to investigate this issue?
>
> I presume reboot works O.K? So it is possible to toggle the reset
> multiple times, but reboot must do something additional which makes it
> work? Do you have sources for the bootloader?
The bootloader is current U-Boot master as BL33 of Marvell provided ATF
version 18.12, current latest.
> Are there status bits in the comphy about the state of the link? Maybe
> comphy needs to be kicked to reestablish the link?
Maybe. The U-Boot comphy PCIe initialization routine
comphy_pcie_power_up() is long and complex.
The ATF code also carries PCIe comphy initialization with this text:
https://github.com/MarvellEmbeddedProcessors/atf-marvell/blob/atf-v1.5-armada-18.12/drivers/marvell/comphy/phy-comphy-cp110.c#L1170
/* In Armada 8K DB boards, PCIe initialization can be executed
* only once (PCIe reset performed during chip power on and
* it cannot be executed via GPIO later).
* This means that power on can be executed only once, so let's
* mark if the caller is bootloader or Linux.
* If bootloader -> run power on.
* If Linux -> exit.
*
* TODO: In MacciatoBIN, PCIe reset is connected via GPIO,
* so after GPIO reset is added to Linux Kernel, it can be
* powered-on by Linux.
*/
if (!called_from_uboot)
return ret;
It looks like vendor code is using a similar trick.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/2] PCI: armada8k: don't toggle reset twice
Date: Thu, 10 Jan 2019 17:57:24 +0200 [thread overview]
Message-ID: <87zhs8h5ej.fsf@tarshish> (raw)
In-Reply-To: <20190110131912.GB29612@lunn.ch>
Hi Andrew,
On Thu, Jan 10 2019, Andrew Lunn wrote:
>> Sven Auhagen reported the same issue with Intel NIC attached to
>> mini-PCIe slots on a custom Armada 8K design.
>
> O.K. so that suggests the issue is on the Armada side.
>
>> How would you suggest to investigate this issue?
>
> I presume reboot works O.K? So it is possible to toggle the reset
> multiple times, but reboot must do something additional which makes it
> work? Do you have sources for the bootloader?
The bootloader is current U-Boot master as BL33 of Marvell provided ATF
version 18.12, current latest.
> Are there status bits in the comphy about the state of the link? Maybe
> comphy needs to be kicked to reestablish the link?
Maybe. The U-Boot comphy PCIe initialization routine
comphy_pcie_power_up() is long and complex.
The ATF code also carries PCIe comphy initialization with this text:
https://github.com/MarvellEmbeddedProcessors/atf-marvell/blob/atf-v1.5-armada-18.12/drivers/marvell/comphy/phy-comphy-cp110.c#L1170
/* In Armada 8K DB boards, PCIe initialization can be executed
* only once (PCIe reset performed during chip power on and
* it cannot be executed via GPIO later).
* This means that power on can be executed only once, so let's
* mark if the caller is bootloader or Linux.
* If bootloader -> run power on.
* If Linux -> exit.
*
* TODO: In MacciatoBIN, PCIe reset is connected via GPIO,
* so after GPIO reset is added to Linux Kernel, it can be
* powered-on by Linux.
*/
if (!called_from_uboot)
return ret;
It looks like vendor code is using a similar trick.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-pwm@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/2] PCI: armada8k: don't toggle reset twice
Date: Thu, 10 Jan 2019 17:57:24 +0200 [thread overview]
Message-ID: <87zhs8h5ej.fsf@tarshish> (raw)
In-Reply-To: <20190110131912.GB29612@lunn.ch>
Hi Andrew,
On Thu, Jan 10 2019, Andrew Lunn wrote:
>> Sven Auhagen reported the same issue with Intel NIC attached to
>> mini-PCIe slots on a custom Armada 8K design.
>
> O.K. so that suggests the issue is on the Armada side.
>
>> How would you suggest to investigate this issue?
>
> I presume reboot works O.K? So it is possible to toggle the reset
> multiple times, but reboot must do something additional which makes it
> work? Do you have sources for the bootloader?
The bootloader is current U-Boot master as BL33 of Marvell provided ATF
version 18.12, current latest.
> Are there status bits in the comphy about the state of the link? Maybe
> comphy needs to be kicked to reestablish the link?
Maybe. The U-Boot comphy PCIe initialization routine
comphy_pcie_power_up() is long and complex.
The ATF code also carries PCIe comphy initialization with this text:
https://github.com/MarvellEmbeddedProcessors/atf-marvell/blob/atf-v1.5-armada-18.12/drivers/marvell/comphy/phy-comphy-cp110.c#L1170
/* In Armada 8K DB boards, PCIe initialization can be executed
* only once (PCIe reset performed during chip power on and
* it cannot be executed via GPIO later).
* This means that power on can be executed only once, so let's
* mark if the caller is bootloader or Linux.
* If bootloader -> run power on.
* If Linux -> exit.
*
* TODO: In MacciatoBIN, PCIe reset is connected via GPIO,
* so after GPIO reset is added to Linux Kernel, it can be
* powered-on by Linux.
*/
if (!called_from_uboot)
return ret;
It looks like vendor code is using a similar trick.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-10 15:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:26 [PATCH 1/2] gpio: mvebu: implement get_direction Baruch Siach
2019-01-10 12:26 ` Baruch Siach
2019-01-10 12:26 ` Baruch Siach
2019-01-10 12:26 ` [PATCH 2/2] PCI: armada8k: don't toggle reset twice Baruch Siach
2019-01-10 12:26 ` Baruch Siach
2019-01-10 12:26 ` Baruch Siach
2019-01-10 12:55 ` Andrew Lunn
2019-01-10 12:55 ` Andrew Lunn
2019-01-10 12:55 ` Andrew Lunn
2019-01-10 13:05 ` Baruch Siach
2019-01-10 13:05 ` Baruch Siach
2019-01-10 13:05 ` Baruch Siach
2019-01-10 13:19 ` Andrew Lunn
2019-01-10 13:19 ` Andrew Lunn
2019-01-10 13:19 ` Andrew Lunn
2019-01-10 15:57 ` Baruch Siach [this message]
2019-01-10 15:57 ` Baruch Siach
2019-01-10 15:57 ` Baruch Siach
2019-01-13 12:38 ` Baruch Siach
2019-01-13 12:38 ` Baruch Siach
2019-01-13 12:38 ` Baruch Siach
2019-01-13 15:40 ` Andrew Lunn
2019-01-13 15:40 ` Andrew Lunn
2019-01-13 15:40 ` Andrew Lunn
2019-01-13 18:42 ` Baruch Siach
2019-01-13 18:42 ` Baruch Siach
2019-01-13 18:42 ` Baruch Siach
2019-01-13 23:35 ` Linus Walleij
2019-01-13 23:35 ` Linus Walleij
2019-01-13 23:35 ` Linus Walleij
2019-01-14 7:19 ` Baruch Siach
2019-01-14 7:19 ` Baruch Siach
2019-01-14 7:19 ` Baruch Siach
2019-01-10 15:20 ` [PATCH 1/2] gpio: mvebu: implement get_direction Linus Walleij
2019-01-10 15:20 ` Linus Walleij
2019-01-10 15:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhs8h5ej.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=bhelgaas@google.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sven.auhagen@voleatech.de \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.