All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/4] board: orangepi: Add Orangepi One Plus support
Date: Sat, 03 Nov 2018 21:27:06 +0200	[thread overview]
Message-ID: <87zhuqner9.fsf@tkos.co.il> (raw)
In-Reply-To: <20181103125608.2255-2-jagan@amarulasolutions.com>

Hi Jagan,

Jagan Teki writes:
> diff --git a/board/orangepi/orangepi-one-plus/extlinux.conf b/board/orangepi/orangepi-one-plus/extlinux.conf
> new file mode 100644
> index 0000000000..eae328449c
> --- /dev/null
> +++ b/board/orangepi/orangepi-one-plus/extlinux.conf
> @@ -0,0 +1,4 @@
> +label linux-4.18.0-rc3

This doesn't match the actual kernel version. I think you can just drop
the version from the label. It is easy to forget keeping it in sync with
the kernel version.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-11-03 19:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-03 12:56 [Buildroot] [PATCH 1/4] uboot: bump to version 2018.09 Jagan Teki
2018-11-03 12:56 ` [Buildroot] [PATCH v2 2/4] board: orangepi: Add Orangepi One Plus support Jagan Teki
2018-11-03 19:27   ` Baruch Siach [this message]
2018-12-16 15:00   ` Thomas Petazzoni
2018-11-03 12:56 ` [Buildroot] [PATCH 3/4] board: orangepi: Add Orangepi Lite2 support Jagan Teki
2018-12-16 15:00   ` Thomas Petazzoni
2018-11-03 12:56 ` [Buildroot] [PATCH 4/4] board: orangepi: lite2: Add WiFi support Jagan Teki
2018-12-16 15:00   ` Thomas Petazzoni
2018-11-03 14:56 ` [Buildroot] [PATCH 1/4] uboot: bump to version 2018.09 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhuqner9.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.