All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: alagusankar@silex-india.com, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	ath10k@lists.infradead.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle
Date: Fri, 29 Jun 2018 14:49:29 +0300	[thread overview]
Message-ID: <87zhzdersm.fsf@codeaurora.org> (raw)
In-Reply-To: <20180620084222.3521-2-niklas.cassel@linaro.org> (Niklas Cassel's message of "Wed, 20 Jun 2018 10:42:20 +0200")

Niklas Cassel <niklas.cassel@linaro.org> writes:

> All packets in a bundle should use the same endpoint id as the
> first lookahead.
>
> This matches how things are done is ath6kl, however,
> this patch can theoretically handle several bundles
> in ath10k_sdio_mbox_rx_process_packets().
>
> Without this patch we get lots of errors about invalid endpoint id:
>
> ath10k_sdio mmc2:0001:1: invalid endpoint in look-ahead: 224
> ath10k_sdio mmc2:0001:1: failed to get pending recv messages: -12
> ath10k_sdio mmc2:0001:1: failed to process pending SDIO interrupts: -12
>
> Signed-off-by: Alagu Sankar <alagusankar@silex-india.com>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

You have Alagu's s-o-b first so that implies Alagu is the author. So
should I add From header for Alagu and add you (Niklas) as
Co-Developed-by? Or vice versa?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	alagusankar@silex-india.com, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle
Date: Fri, 29 Jun 2018 14:49:29 +0300	[thread overview]
Message-ID: <87zhzdersm.fsf@codeaurora.org> (raw)
In-Reply-To: <20180620084222.3521-2-niklas.cassel@linaro.org> (Niklas Cassel's message of "Wed, 20 Jun 2018 10:42:20 +0200")

Niklas Cassel <niklas.cassel@linaro.org> writes:

> All packets in a bundle should use the same endpoint id as the
> first lookahead.
>
> This matches how things are done is ath6kl, however,
> this patch can theoretically handle several bundles
> in ath10k_sdio_mbox_rx_process_packets().
>
> Without this patch we get lots of errors about invalid endpoint id:
>
> ath10k_sdio mmc2:0001:1: invalid endpoint in look-ahead: 224
> ath10k_sdio mmc2:0001:1: failed to get pending recv messages: -12
> ath10k_sdio mmc2:0001:1: failed to process pending SDIO interrupts: -12
>
> Signed-off-by: Alagu Sankar <alagusankar@silex-india.com>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

You have Alagu's s-o-b first so that implies Alagu is the author. So
should I add From header for Alagu and add you (Niklas) as
Co-Developed-by? Or vice versa?

-- 
Kalle Valo

  reply	other threads:[~2018-06-29 11:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  8:42 [PATCH 0/3] ath10k: sdio: essential sdio fixes Niklas Cassel
2018-06-20  8:42 ` Niklas Cassel
2018-06-20  8:42 ` [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle Niklas Cassel
2018-06-20  8:42   ` Niklas Cassel
2018-06-20  8:42   ` Niklas Cassel
2018-06-29 11:49   ` Kalle Valo [this message]
2018-06-29 11:49     ` Kalle Valo
2018-06-29 11:53     ` Kalle Valo
2018-06-29 11:53       ` Kalle Valo
2018-06-29 13:11       ` Niklas Cassel
2018-06-29 13:11         ` Niklas Cassel
2018-06-29 13:51         ` Kalle Valo
2018-06-29 13:51           ` Kalle Valo
2018-06-29 13:56           ` Niklas Cassel
2018-06-29 13:56             ` Niklas Cassel
2018-07-02 14:23   ` [1/3] " Kalle Valo
2018-07-02 14:23     ` Kalle Valo
2018-07-02 14:23   ` Kalle Valo
2018-06-20  8:42 ` [PATCH 2/3] ath10k: sdio: allocate correct size for RECV_1MORE_BLOCK rx packets Niklas Cassel
2018-06-20  8:42   ` Niklas Cassel
2018-06-20  8:42   ` Niklas Cassel
2018-06-20  8:42 ` [PATCH 3/3] ath10k: sdio: set skb len for all " Niklas Cassel
2018-06-20  8:42   ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhzdersm.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=alagusankar@silex-india.com \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.cassel@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.