Re: [Qemu-devel] [PATCH v1 3/3] tcg-runtime: short-circuit lookup_tb_ptr on IRQs

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Henderson <rth@twiddle.net> writes:

> On 06/14/2017 10:08 AM, Paolo Bonzini wrote:
>> And MIPS:
>>
>> diff --git a/target/mips/translate.c b/target/mips/translate.c
>> index 559f8fed89..244f3cb9ab 100644
>> --- a/target/mips/translate.c
>> +++ b/target/mips/translate.c
>> @@ -13403,8 +13403,9 @@ static void gen_pool32axf (CPUMIPSState *env, DisasContext *ctx, int rt, int rs)
>>                   save_cpu_state(ctx, 1);
>>                   gen_helper_ei(t0, cpu_env);
>>                   gen_store_gpr(t0, rs);
>> -                /* Stop translation as we may have switched the execution mode */
>> -                ctx->bstate = BS_STOP;
>> +                /* BS_STOP isn't good enough here, reevaluate cpu_mips_hw_interrupts_enabled. */
>> +                gen_save_pc(ctx->pc + 4);
>> +                ctx->bstate = BS_EXCP;
>>                   tcg_temp_free(t0);
>>               }
>>               break;
>>
>> The others seem okay.
>
> Thanks for this bit.  We also need to fix SSM for s390x.

If your rolling a series for all these can you also pick up Thomas
Huth's fix for --accel?

--
Alex Bennée