From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp: allow setting properties to empty string in qmp-shell
Date: Mon, 06 Mar 2017 09:19:49 +0100 [thread overview]
Message-ID: <87zigy3jh6.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170302122429.7737-1-berrange@redhat.com> (Daniel P. Berrange's message of "Thu, 2 Mar 2017 12:24:29 +0000")
"Daniel P. Berrange" <berrange@redhat.com> writes:
> The qmp-shell property parser currently rejects attempts to
> set string properties to the empty string eg
>
> (QEMU) migrate-set-parameters tls-hostname=
> Error while parsing command line: Expected a key=value pair, got 'tls-hostname='
> command format: <command-name> [arg-name1=arg1] ... [arg-nameN=argN]
>
> This is caused by checking the wrong condition after splitting
> the parameter on '='. The "partition" method will return "" for
> the separator field, if the seperator was not present, so that
> is the correct thing to check for malformed syntax.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
I'll take this through my tree, unless qemu-trivial beats me to the
punch. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp: allow setting properties to empty string in qmp-shell
Date: Mon, 06 Mar 2017 09:19:49 +0100 [thread overview]
Message-ID: <87zigy3jh6.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170302122429.7737-1-berrange@redhat.com> (Daniel P. Berrange's message of "Thu, 2 Mar 2017 12:24:29 +0000")
"Daniel P. Berrange" <berrange@redhat.com> writes:
> The qmp-shell property parser currently rejects attempts to
> set string properties to the empty string eg
>
> (QEMU) migrate-set-parameters tls-hostname=
> Error while parsing command line: Expected a key=value pair, got 'tls-hostname='
> command format: <command-name> [arg-name1=arg1] ... [arg-nameN=argN]
>
> This is caused by checking the wrong condition after splitting
> the parameter on '='. The "partition" method will return "" for
> the separator field, if the seperator was not present, so that
> is the correct thing to check for malformed syntax.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
I'll take this through my tree, unless qemu-trivial beats me to the
punch. Thanks!
next prev parent reply other threads:[~2017-03-06 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 12:24 [Qemu-trivial] [PATCH] qmp: allow setting properties to empty string in qmp-shell Daniel P. Berrange
2017-03-02 12:24 ` [Qemu-devel] " Daniel P. Berrange
2017-03-02 16:03 ` [Qemu-trivial] " Eric Blake
2017-03-02 16:03 ` Eric Blake
2017-03-03 17:15 ` [Qemu-trivial] " John Snow
2017-03-03 17:15 ` John Snow
2017-03-06 8:19 ` Markus Armbruster [this message]
2017-03-06 8:19 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zigy3jh6.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.