All of lore.kernel.org
 help / color / mirror / Atom feed
From: rusty@rustcorp.com.au (Rusty Russell)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol
Date: Thu, 31 Oct 2013 13:44:13 +1030	[thread overview]
Message-ID: <87zjpqb08q.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20131030230920.GQ16735@n2100.arm.linux.org.uk>

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> On Mon, Oct 28, 2013 at 04:20:19PM +1030, Rusty Russell wrote:
>> Ming Lei <tom.leiming@gmail.com> writes:
>> > On Mon, 28 Oct 2013 13:44:30 +1030
>> > Rusty Russell <rusty@rustcorp.com.au> wrote:
>> >
>> >> Ming Lei <tom.leiming@gmail.com> writes:
>> >> 
>> >> I don't know...  It would be your job, as the person making the change,
>> >> to find all the users of kallsyms and prove that.
>> >> 
>> >> This is why it is easier not to include incorrect values in the kernel's
>> >> kallsyms in the first place.
>> >
>> > OK, thanks for your comment, and I figured out one way to do it in
>> > scripts/kallsyms.c, could you comment on below patch?
>> 
>> Looks great! Seems like we spent more time arguing than it took you to
>> code that up.
>> 
>> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>> 
>> Russell, this seems logical for you to take along with the changes which
>> caused the problem?
>
> The changes are already in mainline since a long time (back in July/August
> time).  Am I the right person to take stuff for scripts/ ?  Isn't that
> more kbuild territory?

Kallsyms tends to fall between modules and scripts.  I assume it's not
urgent, so no cc:stable on this one.

Applied,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Ming Lei <tom.leiming@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Chen Gang <gang.chen@asianux.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Michal Marek <mmarek@suse.cz>
Subject: Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol
Date: Thu, 31 Oct 2013 13:44:13 +1030	[thread overview]
Message-ID: <87zjpqb08q.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20131030230920.GQ16735@n2100.arm.linux.org.uk>

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> On Mon, Oct 28, 2013 at 04:20:19PM +1030, Rusty Russell wrote:
>> Ming Lei <tom.leiming@gmail.com> writes:
>> > On Mon, 28 Oct 2013 13:44:30 +1030
>> > Rusty Russell <rusty@rustcorp.com.au> wrote:
>> >
>> >> Ming Lei <tom.leiming@gmail.com> writes:
>> >> 
>> >> I don't know...  It would be your job, as the person making the change,
>> >> to find all the users of kallsyms and prove that.
>> >> 
>> >> This is why it is easier not to include incorrect values in the kernel's
>> >> kallsyms in the first place.
>> >
>> > OK, thanks for your comment, and I figured out one way to do it in
>> > scripts/kallsyms.c, could you comment on below patch?
>> 
>> Looks great! Seems like we spent more time arguing than it took you to
>> code that up.
>> 
>> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>> 
>> Russell, this seems logical for you to take along with the changes which
>> caused the problem?
>
> The changes are already in mainline since a long time (back in July/August
> time).  Am I the right person to take stuff for scripts/ ?  Isn't that
> more kbuild territory?

Kallsyms tends to fall between modules and scripts.  I assume it's not
urgent, so no cc:stable on this one.

Applied,
Rusty.

  reply	other threads:[~2013-10-31  3:14 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23  3:18 [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol Ming Lei
2013-10-23  3:18 ` Ming Lei
2013-10-24  1:21 ` Rusty Russell
2013-10-24  1:21   ` Rusty Russell
2013-10-24  5:42   ` Ming Lei
2013-10-24  5:42     ` Ming Lei
2013-10-24  8:45   ` Russell King - ARM Linux
2013-10-24  8:45     ` Russell King - ARM Linux
2013-10-24  9:10     ` Ming Lei
2013-10-24  9:10       ` Ming Lei
2013-10-24 23:08     ` Rusty Russell
2013-10-24 23:08       ` Rusty Russell
2013-10-25  1:29       ` Ming Lei
2013-10-25  1:29         ` Ming Lei
2013-10-25  5:50         ` Rusty Russell
2013-10-25  5:50           ` Rusty Russell
2013-10-25  7:01           ` Ming Lei
2013-10-25  7:01             ` Ming Lei
2013-10-25 11:58             ` Rusty Russell
2013-10-25 11:58               ` Rusty Russell
2013-10-26 12:31               ` Ming Lei
2013-10-26 12:31                 ` Ming Lei
2013-10-28  3:14                 ` Rusty Russell
2013-10-28  3:14                   ` Rusty Russell
2013-10-28  5:23                   ` Ming Lei
2013-10-28  5:23                     ` Ming Lei
2013-10-28  5:50                     ` Rusty Russell
2013-10-28  5:50                       ` Rusty Russell
2013-10-30 23:09                       ` Russell King - ARM Linux
2013-10-30 23:09                         ` Russell King - ARM Linux
2013-10-31  3:14                         ` Rusty Russell [this message]
2013-10-31  3:14                           ` Rusty Russell
2013-10-31  4:55                           ` Ming Lei
2013-10-31  4:55                             ` Ming Lei
2013-11-01  2:28                             ` Rusty Russell
2013-11-01  2:28                               ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjpqb08q.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.