From: ebiederm@xmission.com (Eric W. Biederman)
To: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
Cc: David Miller <davem@davemloft.net>,
vyasevich@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] SCTP: Free the per-net sysctl table on net exit. v2
Date: Tue, 29 Jan 2013 00:20:35 +0000 [thread overview]
Message-ID: <87zjzskffw.fsf@xmission.com> (raw)
In-Reply-To: <5106ECCF.7080105@fold.natur.cuni.cz> (Martin Mokrejs's message of "Mon, 28 Jan 2013 22:25:35 +0100")
Martin Mokrejs <mmokrejs@fold.natur.cuni.cz> writes:
> Martin Mokrejs wrote:
>> Hi Eric,
>>
>> Eric W. Biederman wrote:
>>> Martin Mokrejs <mmokrejs@fold.natur.cuni.cz> writes:
>>>
>>>> David Miller wrote:
>>>>> From: ebiederm@xmission.com (Eric W. Biederman)
>>>>> Date: Sun, 27 Jan 2013 19:25:11 -0800
>>>>>
>>>>>> The typo is fixed in the patch this time in addition to my test
>>>>>> tree.
>>>>>
>>>>> Applied, thanks for fixing this up Eric.
>
>> So I haven't tested the patch yet. doh. Provided I am running 3 days without reproducing
>> the original memleak on an unpatched kernel I doubt I can easily prove it after a reboot.
>
> Umm, I spoke too early. It did happen again during these 3 days on unpatched 3.7.4:
>
> unreferenced object 0xffff880402769030 (size 2048):
> comm "chrome_sandbox", pid 4720, jiffies 4294966701 (age 285697.590s)
> hex dump (first 32 bytes):
> b2 68 89 81 ff ff ff ff 20 84 4f d8 03 88 ff ff .h...... .O.....
> 04 00 00 00 a4 01 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff815b4aad>] kmemleak_alloc+0x21/0x3e
> [<ffffffff81110352>] slab_post_alloc_hook+0x28/0x2a
> [<ffffffff81113fad>] __kmalloc_track_caller+0xf1/0x104
> [<ffffffff810f10c2>] kmemdup+0x1b/0x30
> [<ffffffff81571e9f>] sctp_sysctl_net_register+0x1f/0x72
> [<ffffffff8155d305>] sctp_net_init+0x100/0x39f
> [<ffffffff814ad53c>] ops_init+0xc6/0xf5
> [<ffffffff814ad5b7>] setup_net+0x4c/0xd0
> [<ffffffff814ada5e>] copy_net_ns+0x6d/0xd6
> [<ffffffff810938b1>] create_new_namespaces+0xd7/0x147
> [<ffffffff810939f4>] copy_namespaces+0x63/0x99
> [<ffffffff81076733>] copy_process+0xa65/0x1233
> [<ffffffff81077030>] do_fork+0x10b/0x271
> [<ffffffff8100a0e9>] sys_clone+0x23/0x25
> [<ffffffff815dda73>] stub_clone+0x13/0x20
> [<ffffffffffffffff>] 0xffffffffffffffff
>
> But I won't make it to a reboot in next 2-3 days to test the patch v2, sorry.
No biggy the logic remains the same and the fix in the patch is clrearly
needed from an inspection of the code.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>
Cc: David Miller <davem@davemloft.net>,
vyasevich@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH] SCTP: Free the per-net sysctl table on net exit. v2
Date: Mon, 28 Jan 2013 16:20:35 -0800 [thread overview]
Message-ID: <87zjzskffw.fsf@xmission.com> (raw)
In-Reply-To: <5106ECCF.7080105@fold.natur.cuni.cz> (Martin Mokrejs's message of "Mon, 28 Jan 2013 22:25:35 +0100")
Martin Mokrejs <mmokrejs@fold.natur.cuni.cz> writes:
> Martin Mokrejs wrote:
>> Hi Eric,
>>
>> Eric W. Biederman wrote:
>>> Martin Mokrejs <mmokrejs@fold.natur.cuni.cz> writes:
>>>
>>>> David Miller wrote:
>>>>> From: ebiederm@xmission.com (Eric W. Biederman)
>>>>> Date: Sun, 27 Jan 2013 19:25:11 -0800
>>>>>
>>>>>> The typo is fixed in the patch this time in addition to my test
>>>>>> tree.
>>>>>
>>>>> Applied, thanks for fixing this up Eric.
>
>> So I haven't tested the patch yet. doh. Provided I am running 3 days without reproducing
>> the original memleak on an unpatched kernel I doubt I can easily prove it after a reboot.
>
> Umm, I spoke too early. It did happen again during these 3 days on unpatched 3.7.4:
>
> unreferenced object 0xffff880402769030 (size 2048):
> comm "chrome_sandbox", pid 4720, jiffies 4294966701 (age 285697.590s)
> hex dump (first 32 bytes):
> b2 68 89 81 ff ff ff ff 20 84 4f d8 03 88 ff ff .h...... .O.....
> 04 00 00 00 a4 01 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff815b4aad>] kmemleak_alloc+0x21/0x3e
> [<ffffffff81110352>] slab_post_alloc_hook+0x28/0x2a
> [<ffffffff81113fad>] __kmalloc_track_caller+0xf1/0x104
> [<ffffffff810f10c2>] kmemdup+0x1b/0x30
> [<ffffffff81571e9f>] sctp_sysctl_net_register+0x1f/0x72
> [<ffffffff8155d305>] sctp_net_init+0x100/0x39f
> [<ffffffff814ad53c>] ops_init+0xc6/0xf5
> [<ffffffff814ad5b7>] setup_net+0x4c/0xd0
> [<ffffffff814ada5e>] copy_net_ns+0x6d/0xd6
> [<ffffffff810938b1>] create_new_namespaces+0xd7/0x147
> [<ffffffff810939f4>] copy_namespaces+0x63/0x99
> [<ffffffff81076733>] copy_process+0xa65/0x1233
> [<ffffffff81077030>] do_fork+0x10b/0x271
> [<ffffffff8100a0e9>] sys_clone+0x23/0x25
> [<ffffffff815dda73>] stub_clone+0x13/0x20
> [<ffffffffffffffff>] 0xffffffffffffffff
>
> But I won't make it to a reboot in next 2-3 days to test the patch v2, sorry.
No biggy the logic remains the same and the fix in the patch is clrearly
needed from an inspection of the code.
Eric
next prev parent reply other threads:[~2013-01-29 0:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 20:59 linux-3.7.4: kmemleak in sctp_sysctl_net_register()? Martin Mokrejs
2013-01-23 20:59 ` Martin Mokrejs
2013-01-24 16:02 ` [PATCH] SCTP: Free the per-net sysctl table on net exit Vlad Yasevich
2013-01-24 16:02 ` Vlad Yasevich
2013-01-24 16:44 ` Neil Horman
2013-01-24 16:44 ` Neil Horman
2013-01-24 22:14 ` Eric W. Biederman
2013-01-24 22:14 ` Eric W. Biederman
2013-01-28 0:35 ` David Miller
2013-01-28 0:35 ` David Miller
2013-01-28 1:58 ` Eric W. Biederman
2013-01-28 1:58 ` Eric W. Biederman
2013-01-28 3:25 ` [PATCH] SCTP: Free the per-net sysctl table on net exit. v2 Eric W. Biederman
2013-01-28 3:25 ` Eric W. Biederman
2013-01-28 5:11 ` David Miller
2013-01-28 5:11 ` David Miller
2013-01-28 8:33 ` Martin Mokrejs
2013-01-28 8:33 ` Martin Mokrejs
2013-01-28 15:47 ` Eric W. Biederman
2013-01-28 15:47 ` Eric W. Biederman
2013-01-28 21:17 ` Martin Mokrejs
2013-01-28 21:17 ` Martin Mokrejs
2013-01-28 21:25 ` Martin Mokrejs
2013-01-28 21:25 ` Martin Mokrejs
2013-01-29 0:20 ` Eric W. Biederman [this message]
2013-01-29 0:20 ` Eric W. Biederman
2013-03-05 9:05 ` Martin Mokrejs
2013-03-05 9:05 ` Martin Mokrejs
2013-03-05 19:32 ` David Miller
2013-03-05 19:32 ` David Miller
2013-03-05 21:04 ` Martin Mokrejs
2013-03-05 21:04 ` Martin Mokrejs
2013-03-05 21:08 ` David Miller
2013-03-05 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjzskffw.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=mmokrejs@fold.natur.cuni.cz \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.