Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal

[Anthony Liguori <anthony@codemonkey.ws>]

Amit Shah <amit.shah@redhat.com> writes:

> Disable the rate-limit timer on device remove (e.g. hot-unplug).
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

Nice catch.

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  hw/virtio-rng.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
> index cf5a8ff..c8a6da7 100644
> --- a/hw/virtio-rng.c
> +++ b/hw/virtio-rng.c
> @@ -194,6 +194,8 @@ void virtio_rng_exit(VirtIODevice *vdev)
>  {
>      VirtIORNG *vrng = DO_UPCAST(VirtIORNG, vdev, vdev);
>  
> +    qemu_del_timer(vrng->rate_limit_timer);
> +    qemu_free_timer(vrng->rate_limit_timer);
>      unregister_savevm(vrng->qdev, "virtio-rng", vrng);
>      virtio_cleanup(vdev);
>  }
> -- 
> 1.8.0