From: Kevin Hilman <khilman@deeprootsystems.com>
To: jean.pihet@newoldbits.com
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com, Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH] ARM: OMAP: SmartReflex: select CONFIG_POWER_SUPPLY in Kconfig
Date: Tue, 02 Oct 2012 14:50:53 -0700 [thread overview]
Message-ID: <87zk447dc2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1348151816-30248-1-git-send-email-j-pihet@ti.com> (jean pihet's message of "Thu, 20 Sep 2012 16:36:56 +0200")
jean.pihet@newoldbits.com writes:
> From: Jean Pihet <j-pihet@ti.com>
>
> Select POWER_SUPPLY from POWER_AVS_OMAP entry in Kconfig.
>
> This avoids the following build problems using a randconfig
> that has CONFIG_POWER_SUPPLY not set:
>
> LD init/built-in.o
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
> arch/arm/mach-omap2/smartreflex-class3.c:44: undefined reference to `sr_configure_errgen'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_disable':
> arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to `sr_disable_errgen'
> arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to `sr_disable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
> arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to `sr_enable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_init':
> arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
Thanks, queuing for v3.7-rc
Kevin
> ---
> arch/arm/plat-omap/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index dd36eba..001a795 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -48,6 +48,7 @@ config OMAP_DEBUG_LEDS
> config POWER_AVS_OMAP
> bool "AVS(Adaptive Voltage Scaling) support for OMAP IP versions 1&2"
> depends on POWER_AVS && (ARCH_OMAP3 || ARCH_OMAP4) && PM
> + select POWER_SUPPLY
> help
> Say Y to enable AVS(Adaptive Voltage Scaling)
> support on OMAP containing the version 1 or
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: SmartReflex: select CONFIG_POWER_SUPPLY in Kconfig
Date: Tue, 02 Oct 2012 14:50:53 -0700 [thread overview]
Message-ID: <87zk447dc2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1348151816-30248-1-git-send-email-j-pihet@ti.com> (jean pihet's message of "Thu, 20 Sep 2012 16:36:56 +0200")
jean.pihet at newoldbits.com writes:
> From: Jean Pihet <j-pihet@ti.com>
>
> Select POWER_SUPPLY from POWER_AVS_OMAP entry in Kconfig.
>
> This avoids the following build problems using a randconfig
> that has CONFIG_POWER_SUPPLY not set:
>
> LD init/built-in.o
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
> arch/arm/mach-omap2/smartreflex-class3.c:44: undefined reference to `sr_configure_errgen'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_disable':
> arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to `sr_disable_errgen'
> arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to `sr_disable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
> arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to `sr_enable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_init':
> arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
Thanks, queuing for v3.7-rc
Kevin
> ---
> arch/arm/plat-omap/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index dd36eba..001a795 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -48,6 +48,7 @@ config OMAP_DEBUG_LEDS
> config POWER_AVS_OMAP
> bool "AVS(Adaptive Voltage Scaling) support for OMAP IP versions 1&2"
> depends on POWER_AVS && (ARCH_OMAP3 || ARCH_OMAP4) && PM
> + select POWER_SUPPLY
> help
> Say Y to enable AVS(Adaptive Voltage Scaling)
> support on OMAP containing the version 1 or
next prev parent reply other threads:[~2012-10-02 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:36 [PATCH] ARM: OMAP: SmartReflex: select CONFIG_POWER_SUPPLY in Kconfig jean.pihet
2012-09-20 14:36 ` jean.pihet at newoldbits.com
2012-10-02 21:50 ` Kevin Hilman [this message]
2012-10-02 21:50 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk447dc2.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.