From: Kevin Hilman <khilman@ti.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
R Sricharan <r.sricharan@ti.com>
Subject: Re: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
Date: Mon, 14 May 2012 15:24:11 -0700 [thread overview]
Message-ID: <87zk9apfjo.fsf@ti.com> (raw)
In-Reply-To: <1336716163-2960-1-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Fri, 11 May 2012 11:32:43 +0530")
Vaibhav Hiremath <hvaibhav@ti.com> writes:
> From: Kevin Hilman <khilman@ti.com>
>
> There are certain fields inside 'struct dpll_data' which are
> included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> difficult to use it for new devices like, am33xx, ti81xx, etc...
>
> So remove the ifdef completely, this will add few fields to the struct
> unused, but it improves readability and maintainability of the code.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: R Sricharan <r.sricharan@ti.com>
> ---
> Since Kevin had provided this idea and code change,
> making this patch under his authorship.
Be sure to give yourself credit for writing the changelog. Normally, if
you make changes/additions to patch, you can add a line just before your
signoff. Something like:
[hvaibhav@ti.com: wrote detailed changelog]
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data
Date: Mon, 14 May 2012 15:24:11 -0700 [thread overview]
Message-ID: <87zk9apfjo.fsf@ti.com> (raw)
In-Reply-To: <1336716163-2960-1-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Fri, 11 May 2012 11:32:43 +0530")
Vaibhav Hiremath <hvaibhav@ti.com> writes:
> From: Kevin Hilman <khilman@ti.com>
>
> There are certain fields inside 'struct dpll_data' which are
> included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> difficult to use it for new devices like, am33xx, ti81xx, etc...
>
> So remove the ifdef completely, this will add few fields to the struct
> unused, but it improves readability and maintainability of the code.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: R Sricharan <r.sricharan@ti.com>
> ---
> Since Kevin had provided this idea and code change,
> making this patch under his authorship.
Be sure to give yourself credit for writing the changelog. Normally, if
you make changes/additions to patch, you can add a line just before your
signoff. Something like:
[hvaibhav at ti.com: wrote detailed changelog]
Kevin
next prev parent reply other threads:[~2012-05-14 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 6:02 [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data Vaibhav Hiremath
2012-05-11 6:02 ` Vaibhav Hiremath
2012-05-11 6:31 ` Shilimkar, Santosh
2012-05-11 6:31 ` Shilimkar, Santosh
2012-05-14 22:24 ` Kevin Hilman [this message]
2012-05-14 22:24 ` Kevin Hilman
2012-05-15 5:41 ` Hiremath, Vaibhav
2012-05-15 5:41 ` Hiremath, Vaibhav
2012-06-18 20:19 ` Paul Walmsley
2012-06-18 20:19 ` Paul Walmsley
2012-06-14 15:01 ` Hiremath, Vaibhav
2012-06-14 15:01 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk9apfjo.fsf@ti.com \
--to=khilman@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=r.sricharan@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.