From: Kevin Hilman <khilman@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
Nishanth Menon <nm@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 REPOST 21/24] gpio/omap: save and restore debounce registers
Date: Fri, 04 Nov 2011 09:57:49 -0700 [thread overview]
Message-ID: <87zkgbbzaq.fsf@ti.com> (raw)
In-Reply-To: <1318422730-22282-1-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 12 Oct 2011 18:02:10 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> From: Nishanth Menon <nm@ti.com>
>
> GPIO debounce registers need to be saved and restored for proper functioning
> of driver.
OK.
> To save the registers, we cannot cut the clock before the save,
> hence move the clk disable after the save.
This patch doesn't move any clk disable.
I suspect you made some changes to the original patch from Nishanth.
Please note that in the changelog. This is typically done by adding
something like:
[my@email.addr: describe changes made]
just before your signoff.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 REPOST 21/24] gpio/omap: save and restore debounce registers
Date: Fri, 04 Nov 2011 09:57:49 -0700 [thread overview]
Message-ID: <87zkgbbzaq.fsf@ti.com> (raw)
In-Reply-To: <1318422730-22282-1-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 12 Oct 2011 18:02:10 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> From: Nishanth Menon <nm@ti.com>
>
> GPIO debounce registers need to be saved and restored for proper functioning
> of driver.
OK.
> To save the registers, we cannot cut the clock before the save,
> hence move the clk disable after the save.
This patch doesn't move any clk disable.
I suspect you made some changes to the original patch from Nishanth.
Please note that in the changelog. This is typically done by adding
something like:
[my at email.addr: describe changes made]
just before your signoff.
Kevin
next prev parent reply other threads:[~2011-11-04 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 12:32 [PATCH v8 REPOST 21/24] gpio/omap: save and restore debounce registers Tarun Kanti DebBarma
2011-10-12 12:32 ` Tarun Kanti DebBarma
2011-11-04 16:57 ` Kevin Hilman [this message]
2011-11-04 16:57 ` Kevin Hilman
2011-11-07 11:11 ` DebBarma, Tarun Kanti
2011-11-07 11:11 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkgbbzaq.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.