Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver

[Kevin Hilman <khilman@ti.com>]

Carlos Chinea <carlos.chinea@nokia.com> writes:

> On Mon, 2011-06-13 at 13:21 -0700, ext Kevin Hilman wrote:
>> Carlos Chinea <carlos.chinea@nokia.com> writes:
>> 

[...]

>> > + * Copyright (C) 2010 Nokia Corporation. All rights reserved.
>> > + *
>> > + * Contact: Carlos Chinea <carlos.chinea@nokia.com>
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> > + * modify it under the terms of the GNU General Public License
>> > + * version 2 as published by the Free Software Foundation.
>> > + *
>> > + * This program is distributed in the hope that it will be useful, but
>> > + * WITHOUT ANY WARRANTY; without even the implied warranty of
>> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> > + * General Public License for more details.
>> > + *
>> > + * You should have received a copy of the GNU General Public License
>> > + * along with this program; if not, write to the Free Software
>> > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
>> > + * 02110-1301 USA
>> > + */
> -- cut --
>
>> > +static struct platform_device ssi_pdev = {
>> > +	.name		= "omap_ssi",
>> > +	.id		= 0,
>> > +	.num_resources	= ARRAY_SIZE(ssi_resources),
>> > +	.resource	= ssi_resources,
>> > +	.dev		= {
>> > +				.platform_data	= &ssi_pdata,
>> > +	},
>> > +};
>> 
>> omap_hwmod has all the base address and IRQ data, will construct the
>> struct resources and the platform_devices for you.  Please use
>> omap_hwmod + omap_device for this part of the code.
>> 
>
> Yes, it  is already in my TODO list ;)
>

Great.  Just so you know, we are not taking new OMAP drivers unless they
are using omap_hwmod + omap_device to create the devices.

Kevin