* [PATCH v1] OMAP: GPIO: Correct IP version message during boot
@ 2010-12-16 14:09 ` Varadarajan, Charulatha
0 siblings, 0 replies; 8+ messages in thread
From: Varadarajan, Charulatha @ 2010-12-16 14:09 UTC (permalink / raw)
To: linux-omap
Cc: tony, linux-arm-kernel, b-cousson, balbi, Varadarajan, Charulatha
With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
"OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
the IP version information for all the banks are shown during bootup,
but it does not show the bank number.
Use dev_info instead of printk in omap_gpio_show_rev() so that the
bank id is displayed along with the IP version
[1] http://www.spinics.net/lists/arm-kernel/msg105872.html
Signed-off-by: Varadarajan, Charulatha <charu@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/plat-omap/gpio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 8d493b9..47aeaeb 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
else
return;
- printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
+ dev_info(bank->dev, "hardware version %d.%d\n",
(rev >> 4) & 0x0f, rev & 0x0f);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v1] OMAP: GPIO: Correct IP version message during boot
@ 2010-12-16 14:09 ` Varadarajan, Charulatha
0 siblings, 0 replies; 8+ messages in thread
From: Varadarajan, Charulatha @ 2010-12-16 14:09 UTC (permalink / raw)
To: linux-arm-kernel
With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
"OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
the IP version information for all the banks are shown during bootup,
but it does not show the bank number.
Use dev_info instead of printk in omap_gpio_show_rev() so that the
bank id is displayed along with the IP version
[1] http://www.spinics.net/lists/arm-kernel/msg105872.html
Signed-off-by: Varadarajan, Charulatha <charu@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/plat-omap/gpio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 8d493b9..47aeaeb 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
else
return;
- printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
+ dev_info(bank->dev, "hardware version %d.%d\n",
(rev >> 4) & 0x0f, rev & 0x0f);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1] OMAP: GPIO: Correct IP version message during boot
2010-12-16 14:09 ` Varadarajan, Charulatha
@ 2010-12-16 16:49 ` Kevin Hilman
-1 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2010-12-16 16:49 UTC (permalink / raw)
To: Varadarajan, Charulatha
Cc: linux-omap, tony, linux-arm-kernel, b-cousson, balbi
"Varadarajan, Charulatha" <charu@ti.com> writes:
> With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
> "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
> the IP version information for all the banks are shown during bootup,
> but it does not show the bank number.
>
> Use dev_info instead of printk in omap_gpio_show_rev() so that the
> bank id is displayed along with the IP version
>
> [1] http://www.spinics.net/lists/arm-kernel/msg105872.html
A related question, the commit above also changed the GPIO revision
display from one-time to once per bank. Do we need to know the GPIO HW
revision for each bank, or can we assume it's the same for all banks?
Kevin
> Signed-off-by: Varadarajan, Charulatha <charu@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/plat-omap/gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 8d493b9..47aeaeb 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
> else
> return;
>
> - printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
> + dev_info(bank->dev, "hardware version %d.%d\n",
> (rev >> 4) & 0x0f, rev & 0x0f);
> }
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1] OMAP: GPIO: Correct IP version message during boot
@ 2010-12-16 16:49 ` Kevin Hilman
0 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2010-12-16 16:49 UTC (permalink / raw)
To: linux-arm-kernel
"Varadarajan, Charulatha" <charu@ti.com> writes:
> With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
> "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
> the IP version information for all the banks are shown during bootup,
> but it does not show the bank number.
>
> Use dev_info instead of printk in omap_gpio_show_rev() so that the
> bank id is displayed along with the IP version
>
> [1] http://www.spinics.net/lists/arm-kernel/msg105872.html
A related question, the commit above also changed the GPIO revision
display from one-time to once per bank. Do we need to know the GPIO HW
revision for each bank, or can we assume it's the same for all banks?
Kevin
> Signed-off-by: Varadarajan, Charulatha <charu@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/plat-omap/gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 8d493b9..47aeaeb 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
> else
> return;
>
> - printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
> + dev_info(bank->dev, "hardware version %d.%d\n",
> (rev >> 4) & 0x0f, rev & 0x0f);
> }
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] OMAP: GPIO: Correct IP version message during boot
2010-12-16 16:49 ` Kevin Hilman
@ 2010-12-17 14:15 ` Varadarajan, Charulatha
-1 siblings, 0 replies; 8+ messages in thread
From: Varadarajan, Charulatha @ 2010-12-17 14:15 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap, tony, linux-arm-kernel, b-cousson, balbi
Kevin,
On Thu, Dec 16, 2010 at 11:49, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> "Varadarajan, Charulatha" <charu@ti.com> writes:
>
>> With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
>> "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
>> the IP version information for all the banks are shown during bootup,
>> but it does not show the bank number.
>>
>> Use dev_info instead of printk in omap_gpio_show_rev() so that the
>> bank id is displayed along with the IP version
>>
>> [1] http://www.spinics.net/lists/arm-kernel/msg105872.html
>
> A related question, the commit above also changed the GPIO revision
> display from one-time to once per bank. Do we need to know the GPIO HW
> revision for each bank, or can we assume it's the same for all banks?
The IP version is the same for all the gpio banks in all OMAP2+ CPUs.
But I am not sure about OMAP16xx.
>
> Kevin
>
>> Signed-off-by: Varadarajan, Charulatha <charu@ti.com>
>> Acked-by: Felipe Balbi <balbi@ti.com>
>> ---
>> arch/arm/plat-omap/gpio.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
>> index 8d493b9..47aeaeb 100644
>> --- a/arch/arm/plat-omap/gpio.c
>> +++ b/arch/arm/plat-omap/gpio.c
>> @@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
>> else
>> return;
>>
>> - printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
>> + dev_info(bank->dev, "hardware version %d.%d\n",
>> (rev >> 4) & 0x0f, rev & 0x0f);
>> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1] OMAP: GPIO: Correct IP version message during boot
@ 2010-12-17 14:15 ` Varadarajan, Charulatha
0 siblings, 0 replies; 8+ messages in thread
From: Varadarajan, Charulatha @ 2010-12-17 14:15 UTC (permalink / raw)
To: linux-arm-kernel
Kevin,
On Thu, Dec 16, 2010 at 11:49, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> "Varadarajan, Charulatha" <charu@ti.com> writes:
>
>> With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
>> "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
>> the IP version information for all the banks are shown during bootup,
>> but it does not show the bank number.
>>
>> Use dev_info instead of printk in omap_gpio_show_rev() so that the
>> bank id is displayed along with the IP version
>>
>> [1] http://www.spinics.net/lists/arm-kernel/msg105872.html
>
> A related question, the commit above also changed the GPIO revision
> display from one-time to once per bank. ?Do we need to know the GPIO HW
> revision for each bank, or can we assume it's the same for all banks?
The IP version is the same for all the gpio banks in all OMAP2+ CPUs.
But I am not sure about OMAP16xx.
>
> Kevin
>
>> Signed-off-by: Varadarajan, Charulatha <charu@ti.com>
>> Acked-by: Felipe Balbi <balbi@ti.com>
>> ---
>> ?arch/arm/plat-omap/gpio.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
>> index 8d493b9..47aeaeb 100644
>> --- a/arch/arm/plat-omap/gpio.c
>> +++ b/arch/arm/plat-omap/gpio.c
>> @@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
>> ? ? ? else
>> ? ? ? ? ? ? ? return;
>>
>> - ? ? printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
>> + ? ? dev_info(bank->dev, "hardware version %d.%d\n",
>> ? ? ? ? ? ? ? (rev >> 4) & 0x0f, rev & 0x0f);
>> ?}
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] OMAP: GPIO: Correct IP version message during boot
2010-12-17 14:15 ` Varadarajan, Charulatha
@ 2010-12-20 23:49 ` Kevin Hilman
-1 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2010-12-20 23:49 UTC (permalink / raw)
To: Varadarajan, Charulatha
Cc: linux-omap, tony, linux-arm-kernel, b-cousson, balbi
"Varadarajan, Charulatha" <charu@ti.com> writes:
> Kevin,
>
> On Thu, Dec 16, 2010 at 11:49, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> "Varadarajan, Charulatha" <charu@ti.com> writes:
>>
>>> With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
>>> "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
>>> the IP version information for all the banks are shown during bootup,
>>> but it does not show the bank number.
>>>
>>> Use dev_info instead of printk in omap_gpio_show_rev() so that the
>>> bank id is displayed along with the IP version
>>>
>>> [1] http://www.spinics.net/lists/arm-kernel/msg105872.html
>>
>> A related question, the commit above also changed the GPIO revision
>> display from one-time to once per bank. Do we need to know the GPIO HW
>> revision for each bank, or can we assume it's the same for all banks?
>
> The IP version is the same for all the gpio banks in all OMAP2+ CPUs.
> But I am not sure about OMAP16xx.
>
OK, then I suggest we switch this back to just printing the GPIO
revision once. Maybe after all banks are found, just print the
revision for bank 1.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1] OMAP: GPIO: Correct IP version message during boot
@ 2010-12-20 23:49 ` Kevin Hilman
0 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2010-12-20 23:49 UTC (permalink / raw)
To: linux-arm-kernel
"Varadarajan, Charulatha" <charu@ti.com> writes:
> Kevin,
>
> On Thu, Dec 16, 2010 at 11:49, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> "Varadarajan, Charulatha" <charu@ti.com> writes:
>>
>>> With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is
>>> "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]),
>>> the IP version information for all the banks are shown during bootup,
>>> but it does not show the bank number.
>>>
>>> Use dev_info instead of printk in omap_gpio_show_rev() so that the
>>> bank id is displayed along with the IP version
>>>
>>> [1] http://www.spinics.net/lists/arm-kernel/msg105872.html
>>
>> A related question, the commit above also changed the GPIO revision
>> display from one-time to once per bank. ?Do we need to know the GPIO HW
>> revision for each bank, or can we assume it's the same for all banks?
>
> The IP version is the same for all the gpio banks in all OMAP2+ CPUs.
> But I am not sure about OMAP16xx.
>
OK, then I suggest we switch this back to just printing the GPIO
revision once. Maybe after all banks are found, just print the
revision for bank 1.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-12-20 23:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-16 14:09 [PATCH v1] OMAP: GPIO: Correct IP version message during boot Varadarajan, Charulatha
2010-12-16 14:09 ` Varadarajan, Charulatha
2010-12-16 16:49 ` Kevin Hilman
2010-12-16 16:49 ` Kevin Hilman
2010-12-17 14:15 ` Varadarajan, Charulatha
2010-12-17 14:15 ` Varadarajan, Charulatha
2010-12-20 23:49 ` Kevin Hilman
2010-12-20 23:49 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.