status of MMP?

status of MMP?

[Bernd Schubert]

Hello all,

what is the status of MMP for ext4? While MMP is not particularly useful for 
desktop systems, it is a very useful feature for HA servers. While HA software 
such a pacemaker is supposed to prevent starting resources (e.g. mounts) 
several times, there can come situations where this does not work perfectly.

Lustres ldiskfs already has MMP support for several years and I would like to 
know what is the blocker for ext4? Updating the MMP patches for ext4-git 
should be fairly simple.


Thanks,
Bernd 


-- 
Bernd Schubert
DataDirect Networks

Re: status of MMP?

[Andi Kleen]

Bernd Schubert <bs_lists@aakef.fastmail.fm> writes:

>
> Lustres ldiskfs already has MMP support for several years and I would like to 
> know what is the blocker for ext4? Updating the MMP patches for ext4-git 
> should be fairly simple.

AFAIK simply nobody has done the work and submitted it.

Simply adding it would break LVM snapshots though, so there's a 
compatibility issue.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

Re: status of MMP?

[Bernd Schubert]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/07/2010 05:06 PM, Andi Kleen wrote:
> Bernd Schubert <bs_lists@aakef.fastmail.fm> writes:
> 
>>
>> Lustres ldiskfs already has MMP support for several years and I would like to 
>> know what is the blocker for ext4? Updating the MMP patches for ext4-git 
>> should be fairly simple.
> 
> AFAIK simply nobody has done the work and submitted it.
> 
> Simply adding it would break LVM snapshots though, so there's a 
> compatibility issue.

Well, firstly, you are not forced to enable MMP. And then, I don't
understand what should be the issue with MMP. We use snapshots + ldiskfs
+ MMP all the time.


I have a basic understanding how the MMP code works, but not as thorough
as the Orcacle Lustre team. Andreas, would you mind if I post updated
patches here?

Cheers,
Bernd
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvkLmsACgkQqh74FqyuOzT0bwCfQQRWqaUcTM0xQ1dgyAv483t1
2fQAniCT6AWBdqJiKWQmpUMdYvEKKubW
=U2NE
-----END PGP SIGNATURE-----

Re: status of MMP?

[Andreas Dilger]

On 2010-05-07, at 11:14, Bernd Schubert wrote:
> On 05/07/2010 05:06 PM, Andi Kleen wrote:
>> Bernd Schubert <bs_lists@aakef.fastmail.fm> writes:
>>> Lustres ldiskfs already has MMP support for several years and I would like to know what is the blocker for ext4? Updating the MMP patches for ext4-git 
>>> should be fairly simple.
>> 
>> AFAIK simply nobody has done the work and submitted it.
>> 
>> Simply adding it would break LVM snapshots though, so there's a 
>> compatibility issue.
> 
> Well, firstly, you are not forced to enable MMP. And then, I don't
> understand what should be the issue with MMP. We use snapshots + ldiskfs
> + MMP all the time.

The MMP thread is not started on a device that is mounted read-only, which should be the case for all snapshots.  The snapshot is a logically different block device, so even if it were changed to be read-write that would be fine since the MMP thread would prevent shared access to THAT block device, not the original block device.

> I have a basic understanding how the MMP code works, but not as thorough
> as the Orcacle Lustre team. Andreas, would you mind if I post updated
> patches here?

No objection at all - it's one of the things I've been meaning to do for a while, but haven't gotten around to.  It has been in widespread use at a number of sites and has been working well.  It definitely isn't something that we would want to enable by default, since it would prevent disks from spinning down and would add some background IO overhead.  For environments with SAN or multi-port storage (e.g. HA servers) it is an important safety check that can prevent massive data corruption.

In Lustre bugzilla bug 22375 is a version that has been updated for the 2.6.32 kernel, so that is probably the best one to start with and I'd be surprised if much needs to change to land it upstream.  The e2fsprogs support is in the Lustre e2fsprogs against 1.41.10 and should really be landed upstream before or at the same time as the kernel.

Cheers, Andreas
--
Andreas Dilger
Lustre Technical Lead
Oracle Corporation Canada Inc.