From: Andi Kleen <andi@firstfloor.org>
To: Sheng Yang <sheng@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64
Date: Wed, 13 May 2009 10:38:29 +0200 [thread overview]
Message-ID: <87zldhl7ne.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1242202647-32446-1-git-send-email-sheng@linux.intel.com> (Sheng Yang's message of "Wed, 13 May 2009 16:17:27 +0800")
Sheng Yang <sheng@linux.intel.com> writes:
> -static inline int test_and_set_bit(int nr, volatile unsigned long *addr)
> +static inline int test_and_set_bit(long int nr, volatile unsigned long *addr)
> {
> int oldbit;
>
> - asm volatile(LOCK_PREFIX "bts %2,%1\n\t"
> + asm volatile(LOCK_PREFIX REX_X86 "bts %2,%1\n\t"
Use btsq on 64bit, then you don't need the explicit rex prefix.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Sheng Yang <sheng@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64
Date: Wed, 13 May 2009 10:38:29 +0200 [thread overview]
Message-ID: <87zldhl7ne.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1242202647-32446-1-git-send-email-sheng@linux.intel.com> (Sheng Yang's message of "Wed, 13 May 2009 16:17:27 +0800")
Sheng Yang <sheng@linux.intel.com> writes:
> -static inline int test_and_set_bit(int nr, volatile unsigned long *addr)
> +static inline int test_and_set_bit(long int nr, volatile unsigned long *addr)
> {
> int oldbit;
>
> - asm volatile(LOCK_PREFIX "bts %2,%1\n\t"
> + asm volatile(LOCK_PREFIX REX_X86 "bts %2,%1\n\t"
Use btsq on 64bit, then you don't need the explicit rex prefix.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-13 8:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 8:17 [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64 Sheng Yang
2009-05-13 8:17 ` Sheng Yang
2009-05-13 8:38 ` Andi Kleen [this message]
2009-05-13 8:38 ` Andi Kleen
2009-05-14 3:45 ` Sheng Yang
2009-05-14 3:45 ` Sheng Yang
2009-05-14 8:32 ` Andi Kleen
2009-05-14 8:32 ` Andi Kleen
2009-05-14 14:09 ` H. Peter Anvin
2009-05-14 14:09 ` H. Peter Anvin
2009-05-14 14:16 ` Andi Kleen
2009-05-14 14:16 ` Andi Kleen
2009-05-14 14:16 ` H. Peter Anvin
2009-05-14 14:16 ` H. Peter Anvin
2009-05-14 14:27 ` Andi Kleen
2009-05-14 14:27 ` Andi Kleen
2009-05-14 14:25 ` H. Peter Anvin
2009-05-14 14:25 ` H. Peter Anvin
2009-05-14 14:33 ` Andi Kleen
2009-05-14 14:33 ` Andi Kleen
2009-05-14 14:36 ` H. Peter Anvin
2009-05-14 14:36 ` H. Peter Anvin
2009-05-13 16:18 ` H. Peter Anvin
2009-05-13 16:55 ` H. Peter Anvin
2009-05-13 16:55 ` H. Peter Anvin
2009-05-13 17:29 ` H. Peter Anvin
2009-05-14 3:52 ` Sheng Yang
2009-05-14 3:52 ` Sheng Yang
2009-05-14 14:09 ` H. Peter Anvin
2009-05-14 14:09 ` H. Peter Anvin
2009-05-14 13:57 ` Christoph Hellwig
2009-05-14 13:57 ` Christoph Hellwig
2009-05-14 14:29 ` H. Peter Anvin
2009-05-14 14:29 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zldhl7ne.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.