Re: [patch] Fix for vga terminal

[Marco Gerards <mgerards@xs4all.nl>]

Vesa Jääskeläinen <chaac@nic.fi> writes:

Hi Vesa,

> Here is patch for fixing vga terminal. At least it worked fine on qemu.
> Now it uses only font system to get fonts so you need to load font
> module and use fonts. See gfxterm section on the wiki on how to do that.
>
> I had to edit patch by hand as 64bit patch is still pending and I need
> that to compile my codes. But it should still apply nicely to current CVS.

Great!  Thanks for fixing this!

[...]

> +2007-11-10  Vesa Jaaskelainen  <chaac@nic.fi>
> +
> +	* conf/i386-pc.rmk (pkgdata_MODULES): Added vga.mod.
> +	(vga_mod_SOURCES): Added.
> +	(vga_mod_CFLAGS): Likewise.
> +	(vga_mod_LDFLAGS): Likewise.
> +
> +	* term/i386/pc/vga.c (get_map_mask): Switch order of arguments in
> +	grub_outb() calls.
> +	(set_map_mask): Likewise.
> +	(set_read_map): Likewise.
> +	(set_read_address): Likewise.
> +	(vga_font): Removed variable.
> +	(get_vga_glyph): Removed function.
> +	(invalidate_char): Likewise.
> +	(write_char): Changed to use grub_font_get_glyph() for font
> +	information.
> +	(grub_vga_putchar): Likewise.
> +	(grub_vga_getcharwidth): Likewise.

This looks good to me.  Feel free to commit this! :-)

--
Marco