All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: SELinux@tycho.nsa.gov
Subject: infelicity in context_user_set; new syscalls: setfileconat, etc.?
Date: Sat, 29 Jul 2006 16:50:16 +0200	[thread overview]
Message-ID: <87zmeslb2v.fsf@rho.meyering.net> (raw)

Hello,

I've just discovered what may be a documentation error
for context_user_set, context_role_set, etc.

Those functions are documented as setting errno upon failure,
yet the following program prints "failed with errno=0":

  #include <stdio.h>
  #include <errno.h>
  #include <selinux/context.h>

  int
  main ()
  {
    context_t c = context_new ("a:b:c");
    if (!c)
      return 1;
    errno = 0;
    if (context_user_set (c, ":") != 0)
      printf ("failed with errno=%d\n", errno);
    return 0;
  }

FYI, as part of merging the coreutils SE Linux changes "upstream",
I've just rewritten chcon to use fts (and new openat-style functions,
getfileconat, lgetfileconat, setfileconat, lsetfileconat[*]).  Now,
chcon -R can operate on an arbitrarily deep hierarchy.
One test was to process a 100K-level hierarchy -- finished in just 19sec.
The old version chokes on PATH_MAX at a depth of 2k.

Can any of you point me to a test suite for chcon.
That might save me the trouble of writing my own.

Jim

[*] With linux and /proc, I can emulate functions like openat and
setfileconat, but not everyone has linux, and some linux environments
lack access to /proc, so...

Has anyone considered adding these system calls?
  getfileconat
  lgetfileconat
  setfileconat
  lsetfileconat

They'd be useful for the same reasons openat, lstatat, etc.
are useful (and are now in the Linux kernel).

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

             reply	other threads:[~2006-07-29 14:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29 14:50 Jim Meyering [this message]
2006-07-31  4:58 ` infelicity in context_user_set; new syscalls: setfileconat, etc.? Valdis.Kletnieks
2006-07-31  8:39   ` Jim Meyering
2006-07-31 12:35     ` Russell Coker
2006-07-31 13:27       ` Jim Meyering
2006-07-31 13:26 ` Karl MacMillan
2006-07-31 13:48   ` Jim Meyering
2006-07-31 14:01     ` Stephen Smalley
2006-07-31 14:21       ` Jim Meyering
2006-07-31 14:02     ` Karl MacMillan
2006-07-31 16:37   ` Jim Meyering
2006-08-01 20:17     ` Stephen Smalley
2006-07-31 13:44 ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zmeslb2v.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=SELinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.