Re: [Xen-changelog] /home/emellor/log2

Re: [Xen-changelog] /home/emellor/log2

[Dan Smith]

> # HG changeset patch
> # User emellor@ewan
> # Node ID 32f9300618d607a486d7efccccc57d8a08b9deae
> # Parent  8e3ec9ab0075cbf6fcd1125a96a4c2734405374c
> /home/emellor/log2

This changeset breaks a lot of xm commands.  I get the following stack
trace on about 40 xm-tests:

>  Traceback (most recent call last):
>   File "/usr/sbin/xm", line 10, in ?
>     main.main(sys.argv)
>   File "/usr/lib/python/xen/xm/main.py", line 706, in main
>     handle_xend_error(argv[1], args[0], ex)
>   File "/usr/lib/python/xen/xm/main.py", line 174, in handle_xend_error
>     raise ex
> xen.xend.XendProtocol.XendError: Exception: Missing parameter: dev_config

I've tracked the problem down to the following in this changeset:

>      def op_device_create(self, op, req):
> -        fn = FormFn(self.xd.domain_device_create,
> -                    [['dom',    'int'],
> -                     ['config', 'sxpr']])
> -        val = fn(req.args, {'dom': self.dom.domid})
> -        return val
> +        return self.call(self.dom.device_create,
> +                         [['dev_config', 'sxpr']],
> +                         req)

The problem is that req.args has a 'config' arg, but no 'dev_config'
arg.  I imagine this was made in anticipation of changing the actual
argument to 'dev_config'.  If I change it back to 'config', things
start working again.

Do we want it named 'config' or 'dev_config'?  I can fix it up if I
know which way to go :)

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com