From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU
Date: Wed, 20 May 2015 14:01:25 +0200 [thread overview]
Message-ID: <8810674.KfveOO5Unf@wuerfel> (raw)
In-Reply-To: <20150520113231.GA21937@ulmo.nvidia.com>
On Wednesday 20 May 2015 13:32:33 Thierry Reding wrote:
>
> Since these are all static functions, perhaps an "if (IS_ENABLED(...))"
> would work here? That way you'd get compile coverage of the code in all
> cases.
I had the same thought at first.
> But perhaps that doesn't work for IOMMU. I have a vague memory of
> running across something like this before and IOMMU has this quirk of
> defining struct iommu_ops as empty if IOMMU_API is deselected so you'll
> probably get compiler errors unless you actually preprocess the code
> out.
Exactly.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: gnurou@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU
Date: Wed, 20 May 2015 14:01:25 +0200 [thread overview]
Message-ID: <8810674.KfveOO5Unf@wuerfel> (raw)
In-Reply-To: <20150520113231.GA21937@ulmo.nvidia.com>
On Wednesday 20 May 2015 13:32:33 Thierry Reding wrote:
>
> Since these are all static functions, perhaps an "if (IS_ENABLED(...))"
> would work here? That way you'd get compile coverage of the code in all
> cases.
I had the same thought at first.
> But perhaps that doesn't work for IOMMU. I have a vague memory of
> running across something like this before and IOMMU has this quirk of
> defining struct iommu_ops as empty if IOMMU_API is deselected so you'll
> probably get compiler errors unless you actually preprocess the code
> out.
Exactly.
Arnd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Thierry Reding <treding@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>,
gnurou@gmail.com, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU
Date: Wed, 20 May 2015 14:01:25 +0200 [thread overview]
Message-ID: <8810674.KfveOO5Unf@wuerfel> (raw)
In-Reply-To: <20150520113231.GA21937@ulmo.nvidia.com>
On Wednesday 20 May 2015 13:32:33 Thierry Reding wrote:
>
> Since these are all static functions, perhaps an "if (IS_ENABLED(...))"
> would work here? That way you'd get compile coverage of the code in all
> cases.
I had the same thought at first.
> But perhaps that doesn't work for IOMMU. I have a vague memory of
> running across something like this before and IOMMU has this quirk of
> defining struct iommu_ops as empty if IOMMU_API is deselected so you'll
> probably get compiler errors unless you actually preprocess the code
> out.
Exactly.
Arnd
next prev parent reply other threads:[~2015-05-20 12:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 12:53 [PATCH] drm/nouveau/platform: add IOMMU dependency Arnd Bergmann
2015-05-19 12:53 ` Arnd Bergmann
2015-05-19 12:53 ` Arnd Bergmann
2015-05-19 13:32 ` Thierry Reding
2015-05-19 13:32 ` Thierry Reding
2015-05-19 13:32 ` Thierry Reding
2015-05-20 0:33 ` Alexandre Courbot
2015-05-20 0:33 ` Alexandre Courbot
2015-05-20 0:33 ` Alexandre Courbot
2015-05-20 6:10 ` [PATCH] drm/nouveau/platform: fix compilation if !CONFIG_IOMMU Alexandre Courbot
2015-05-20 6:10 ` Alexandre Courbot
2015-05-20 6:10 ` Alexandre Courbot
2015-05-20 7:07 ` Arnd Bergmann
2015-05-20 7:07 ` Arnd Bergmann
2015-05-20 7:07 ` Arnd Bergmann
2015-05-26 8:43 ` Alexandre Courbot
2015-05-26 8:43 ` Alexandre Courbot
2015-05-26 8:43 ` Alexandre Courbot
2015-05-20 11:32 ` Thierry Reding
2015-05-20 11:32 ` Thierry Reding
2015-05-20 11:32 ` Thierry Reding
2015-05-20 12:01 ` Arnd Bergmann [this message]
2015-05-20 12:01 ` Arnd Bergmann
2015-05-20 12:01 ` Arnd Bergmann
2015-05-20 14:18 ` Alexandre Courbot
2015-05-20 14:18 ` Alexandre Courbot
2015-05-20 14:18 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8810674.KfveOO5Unf@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.