All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Harshal Dev <harshal.dev@oss.qualcomm.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	cros-qcom-dts-watchers@chromium.org,
	Eric Biggers <ebiggers@google.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Tengfei Fan <tengfei.fan@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	David Wronek <davidwronek@gmail.com>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Melody Olvera <quic_molvera@quicinc.com>,
	Alexander Koskovich <akoskovich@pm.me>
Cc: Brian Masney <bmasney@redhat.com>,
	Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
	Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Subject: Re: [PATCH v3 12/12] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE
Date: Wed, 18 Mar 2026 08:33:29 +0100	[thread overview]
Message-ID: <8863f38b-51df-43ea-995c-08b9fb04f4dc@kernel.org> (raw)
In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-12-53371dbabd6a@oss.qualcomm.com>

On 17/03/2026 10:20, Harshal Dev wrote:
> Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver
> de-coupled from the QCOM UFS driver, it explicitly votes for its required
> clocks during probe. For scenarios where the 'clk_ignore_unused' flag is
> not passed on the kernel command line, to avoid potential unclocked ICE
> hardware register access during probe the ICE driver should additionally
> vote on the 'iface' clock.
> Also update the suspend and resume callbacks to handle un-voting and voting
> on the 'iface' clock.
> 
> Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver")
> Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
> ---
>  drivers/soc/qcom/ice.c | 17 +++++++++++++++--

Why the driver patch is after the DTS patches? It is explicitly
documented as no-go.

You do not understand how patches are being applied and you think you
can fix inherent problems in bisectability by creating incorrect order
of patches. No, you cannot. Read maintainer soc profile and entire
development-process document, so you understand how patches are applied,
what are branches, what is current RC and how kernel is effectively
released.

Best regards,
Krzysztof

  reply	other threads:[~2026-03-18  7:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  9:20 [PATCH v3 00/12] Add explicit clock vote and enable power-domain for QCOM-ICE Harshal Dev
2026-03-17  9:20 ` [PATCH v3 01/12] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk Harshal Dev
2026-03-17 15:12   ` Dmitry Baryshkov
2026-03-18  7:21     ` Harshal Dev
2026-03-18  7:22     ` Krzysztof Kozlowski
2026-03-18 10:30       ` Harshal Dev
2026-03-18 11:33         ` Krzysztof Kozlowski
2026-03-17  9:20 ` [PATCH v3 02/12] dt-bindings: crypto: qcom,ice: Require " Harshal Dev
2026-03-17 15:13   ` Dmitry Baryshkov
2026-03-18  7:27     ` Krzysztof Kozlowski
2026-03-18 10:32       ` Harshal Dev
2026-03-18  7:23   ` Krzysztof Kozlowski
2026-03-18 10:33     ` Harshal Dev
2026-03-17  9:20 ` [PATCH v3 03/12] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Harshal Dev
2026-03-17  9:20 ` [PATCH v3 04/12] arm64: dts: qcom: lemans: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 05/12] arm64: dts: qcom: monaco: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 06/12] arm64: dts: qcom: sc7180: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 07/12] arm64: dts: qcom: kodiak: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 08/12] arm64: dts: qcom: sm8450: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 09/12] arm64: dts: qcom: sm8550: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 10/12] arm64: dts: qcom: sm8650: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 11/12] arm64: dts: qcom: sm8750: " Harshal Dev
2026-03-17  9:20 ` [PATCH v3 12/12] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Harshal Dev
2026-03-18  7:33   ` Krzysztof Kozlowski [this message]
2026-03-18 10:39     ` Harshal Dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8863f38b-51df-43ea-995c-08b9fb04f4dc@kernel.org \
    --to=krzk@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=davem@davemloft.net \
    --cc=davidwronek@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=ebiggers@google.com \
    --cc=gaurav.kashyap@oss.qualcomm.com \
    --cc=harshal.dev@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=neeraj.soni@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_molvera@quicinc.com \
    --cc=robh@kernel.org \
    --cc=tengfei.fan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.