From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] ARM64: use linux/types.h in kvm.h
Date: Fri, 13 Nov 2015 12:46:09 +0100 [thread overview]
Message-ID: <8866273.XDAptVUNIk@wuerfel> (raw)
In-Reply-To: <20151113113843.GG12968@cbox>
On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> >
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> >
> > This patch does as Kbuild asks us.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I don't see this error when building the kernel, does it require a
> special option to check for these things?
CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig builds fail,
so you don't get to this point unless you also apply my other fixes.
> In any case, thanks for the patch, I have applied it.
Thanks!
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: use linux/types.h in kvm.h
Date: Fri, 13 Nov 2015 12:46:09 +0100 [thread overview]
Message-ID: <8866273.XDAptVUNIk@wuerfel> (raw)
In-Reply-To: <20151113113843.GG12968@cbox>
On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> >
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> >
> > This patch does as Kbuild asks us.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I don't see this error when building the kernel, does it require a
> special option to check for these things?
CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig builds fail,
so you don't get to this point unless you also apply my other fixes.
> In any case, thanks for the patch, I have applied it.
Thanks!
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] ARM64: use linux/types.h in kvm.h
Date: Fri, 13 Nov 2015 12:46:09 +0100 [thread overview]
Message-ID: <8866273.XDAptVUNIk@wuerfel> (raw)
In-Reply-To: <20151113113843.GG12968@cbox>
On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
> On Thu, Nov 12, 2015 at 03:41:08PM +0100, Arnd Bergmann wrote:
> > We should always use linux/types.h instead of asm/types.h for
> > consistency, and Kbuild actually warns about it:
> >
> > ./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
> >
> > This patch does as Kbuild asks us.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I don't see this error when building the kernel, does it require a
> special option to check for these things?
CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the
configuration I used. I think at the moment, allmodconfig builds fail,
so you don't get to this point unless you also apply my other fixes.
> In any case, thanks for the patch, I have applied it.
Thanks!
Arnd
next prev parent reply other threads:[~2015-11-13 11:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 14:41 [PATCH] ARM64: use linux/types.h in kvm.h Arnd Bergmann
2015-11-12 14:41 ` Arnd Bergmann
2015-11-12 14:41 ` Arnd Bergmann
2015-11-13 11:38 ` Christoffer Dall
2015-11-13 11:38 ` Christoffer Dall
2015-11-13 11:38 ` Christoffer Dall
2015-11-13 11:46 ` Arnd Bergmann [this message]
2015-11-13 11:46 ` Arnd Bergmann
2015-11-13 11:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8866273.XDAptVUNIk@wuerfel \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.