From: Thomas Richard <thomas.richard@bootlin.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, vigneshr@ti.com, kishon@kernel.org,
cassel@kernel.org,
wojciech.jasko-EXT@continental-corporation.com,
bwawrzyn@cisco.com
Cc: linux-pci@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH 4/4] PCI: j721e: Add support to build as a loadable module
Date: Fri, 14 Mar 2025 10:03:01 +0100 [thread overview]
Message-ID: <88b3ecbe-32b6-4310-afb9-da19a2d0506a@bootlin.com> (raw)
In-Reply-To: <20250307103128.3287497-5-s-vadapalli@ti.com>
> +
> + if (pcie->reset_gpio) {
> + msleep(PCIE_T_PVPERL_MS);
> + gpiod_set_value_cansleep(pcie->reset_gpio, 1);
> + }
> +
> + if (pcie->refclk)
> + clk_disable_unprepare(pcie->refclk);
>
Hello Siddharth,
I think clk_disable_unprepare() is a no-op if the clock is NULL, so the
if statement is useless.
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/clk.h#L1157
https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/clk/clk.c#L1237
https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/clk/clk.c#L1099
Regards,
Thomas
next prev parent reply other threads:[~2025-03-14 9:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 10:31 [PATCH 0/4] Loadable Module support for PCIe Cadence and J721E Siddharth Vadapalli
2025-03-07 10:31 ` [PATCH 1/4] PCI: cadence: Add support to build pcie-cadence library as a kernel module Siddharth Vadapalli
2025-03-13 17:44 ` Manivannan Sadhasivam
2025-03-14 6:54 ` Siddharth Vadapalli
2025-03-18 7:49 ` Manivannan Sadhasivam
2025-03-18 7:55 ` Siddharth Vadapalli
2025-03-07 10:31 ` [PATCH 2/4] PCI: cadence-host: Introduce cdns_pcie_host_disable helper for cleanup Siddharth Vadapalli
2025-03-18 7:55 ` Manivannan Sadhasivam
2025-03-07 10:31 ` [PATCH 3/4] PCI: cadence-ep: Introduce cdns_pcie_ep_disable " Siddharth Vadapalli
2025-03-18 8:03 ` Manivannan Sadhasivam
2025-03-18 8:12 ` Siddharth Vadapalli
2025-03-19 10:32 ` Manivannan Sadhasivam
2025-03-19 10:37 ` Siddharth Vadapalli
2025-04-01 11:28 ` Niklas Cassel
2025-04-09 16:56 ` Manivannan Sadhasivam
2025-03-07 10:31 ` [PATCH 4/4] PCI: j721e: Add support to build as a loadable module Siddharth Vadapalli
2025-03-14 9:03 ` Thomas Richard [this message]
2025-03-14 9:07 ` Siddharth Vadapalli
2025-03-19 6:09 ` [PATCH 0/4] Loadable Module support for PCIe Cadence and J721E Peter Chen
2025-03-19 6:25 ` Siddharth Vadapalli
2025-03-19 9:31 ` Peter Chen
2025-03-19 9:55 ` manivannan.sadhasivam
2025-03-20 2:14 ` hans.zhang
2025-03-20 2:26 ` hans.zhang
2025-03-25 15:26 ` manivannan.sadhasivam
2025-03-25 16:03 ` Hans Zhang
2025-03-25 16:36 ` manivannan.sadhasivam
2025-03-26 1:56 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88b3ecbe-32b6-4310-afb9-da19a2d0506a@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=bhelgaas@google.com \
--cc=bwawrzyn@cisco.com \
--cc=cassel@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=wojciech.jasko-EXT@continental-corporation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.