From: Randy Dunlap <rdunlap@infradead.org>
To: Alex Deucher <alexdeucher@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Tao Zhou" <tao.zhou1@amd.com>, "David Airlie" <airlied@linux.ie>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
kernel-janitors@vger.kernel.org,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Candice Li" <candice.li@amd.com>,
"John Clements" <john.clements@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH 2/2] drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write()
Date: Tue, 26 Apr 2022 18:38:39 -0700 [thread overview]
Message-ID: <88d7b912-a12f-4bc9-abe6-e221a37f2eb2@infradead.org> (raw)
In-Reply-To: <CADnq5_PmoHWzJ9Mh=-ghMzOexv20h-Du2hGsoaR0owdDBnc8iw@mail.gmail.com>
Alex--
On 4/26/22 07:47, Alex Deucher wrote:
> Applied the series. Thanks!
>
> Alex
>
I just saw a build warning here when CONFIG_DEBUG_FS is not enabled:
../drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c:281:23: warning: 'amdgpu_ta_if_debugfs_create' defined but not used [-Wunused-function]
281 | static struct dentry *amdgpu_ta_if_debugfs_create(struct amdgpu_device *adev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Alex Deucher <alexdeucher@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Candice Li" <candice.li@amd.com>, "Tao Zhou" <tao.zhou1@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
kernel-janitors@vger.kernel.org,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"John Clements" <john.clements@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH 2/2] drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write()
Date: Tue, 26 Apr 2022 18:38:39 -0700 [thread overview]
Message-ID: <88d7b912-a12f-4bc9-abe6-e221a37f2eb2@infradead.org> (raw)
In-Reply-To: <CADnq5_PmoHWzJ9Mh=-ghMzOexv20h-Du2hGsoaR0owdDBnc8iw@mail.gmail.com>
Alex--
On 4/26/22 07:47, Alex Deucher wrote:
> Applied the series. Thanks!
>
> Alex
>
I just saw a build warning here when CONFIG_DEBUG_FS is not enabled:
../drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c:281:23: warning: 'amdgpu_ta_if_debugfs_create' defined but not used [-Wunused-function]
281 | static struct dentry *amdgpu_ta_if_debugfs_create(struct amdgpu_device *adev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Alex Deucher <alexdeucher@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Tao Zhou" <tao.zhou1@amd.com>, "David Airlie" <airlied@linux.ie>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
kernel-janitors@vger.kernel.org,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Candice Li" <candice.li@amd.com>,
"John Clements" <john.clements@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH 2/2] drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write()
Date: Tue, 26 Apr 2022 18:38:39 -0700 [thread overview]
Message-ID: <88d7b912-a12f-4bc9-abe6-e221a37f2eb2@infradead.org> (raw)
In-Reply-To: <CADnq5_PmoHWzJ9Mh=-ghMzOexv20h-Du2hGsoaR0owdDBnc8iw@mail.gmail.com>
Alex--
On 4/26/22 07:47, Alex Deucher wrote:
> Applied the series. Thanks!
>
> Alex
>
I just saw a build warning here when CONFIG_DEBUG_FS is not enabled:
../drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c:281:23: warning: 'amdgpu_ta_if_debugfs_create' defined but not used [-Wunused-function]
281 | static struct dentry *amdgpu_ta_if_debugfs_create(struct amdgpu_device *adev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
~Randy
next prev parent reply other threads:[~2022-04-27 7:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 8:48 [PATCH 1/2] drm/amdgpu: debugfs: fix error codes in write functions Dan Carpenter
2022-04-26 8:48 ` Dan Carpenter
2022-04-26 8:48 ` Dan Carpenter
2022-04-26 8:49 ` [PATCH 2/2] drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write() Dan Carpenter
2022-04-26 8:49 ` Dan Carpenter
2022-04-26 8:49 ` Dan Carpenter
2022-04-26 14:47 ` Alex Deucher
2022-04-26 14:47 ` Alex Deucher
2022-04-26 14:47 ` Alex Deucher
2022-04-27 1:38 ` Randy Dunlap [this message]
2022-04-27 1:38 ` Randy Dunlap
2022-04-27 1:38 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d7b912-a12f-4bc9-abe6-e221a37f2eb2@infradead.org \
--to=rdunlap@infradead.org \
--cc=Hawking.Zhang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=candice.li@amd.com \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.clements@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tao.zhou1@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.