From: Jerome Pinot <ngc891@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota
Date: Sat, 01 Oct 2005 15:42:04 +0000 [thread overview]
Message-ID: <88ee31b70510010842545d15ff@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
Hi,
Posted this on lkml and to Andrew Morton for -rc2 but doesn't get it fixed :-(
Hope a better welcome here for a so trivial fix:
sbi is not used if quota is not defined. This leads to a uselessvariable after preprocessing and a build warning.
Thanks to apply.
Signed-off-by: Jerome Pinot <ngc891@gmail.com>
------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c 2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c 2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) seq_puts(seq, ",data=journal"); ------8<------
Regards,
--Jerome Pinothttp://ngc891.blogdns.net/
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-10-01 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-01 15:42 Jerome Pinot [this message]
2005-10-01 16:20 ` [KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota Jerome Pinot
2005-10-01 16:36 ` Alexey Dobriyan
2005-10-02 11:40 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88ee31b70510010842545d15ff@mail.gmail.com \
--to=ngc891@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.