[KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota

[KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota

[Jerome Pinot]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi,
Posted this on lkml and to Andrew Morton for -rc2 but doesn't get it fixed :-(
Hope a better welcome here for a so trivial fix:
sbi is not used if quota is not defined. This leads to a uselessvariable after preprocessing and a build warning.
Thanks to apply.
Signed-off-by: Jerome Pinot <ngc891@gmail.com>
 ------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c	2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c	2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { 	struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) 	struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
 	if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) 		seq_puts(seq, ",data=journal"); ------8<------
Regards,
--Jerome Pinothttp://ngc891.blogdns.net/

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota

[Jerome Pinot]

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

> There is a problem with your mailer setup, if you can't manage to> include the patch inline, please attach it (it is considered bad, but> at least your patch can be applied).
I really think I'm doomed with this one.
Here is the patch (sorry for the list)
------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c	2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c	2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { 	struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) 	struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
 	if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) 		seq_puts(seq, ",data=journal");------8<------
You can get it too from here:http://lkml.org/lkml/diff/2005/9/28/341/1
I'll work on my patch submission process...
Thanks
--Jerome Pinothttp://ngc891.blogdns.net/

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Sun, Oct 02, 2005 at 12:42:04AM +0900, Jerome Pinot wrote:
> Posted this on lkml and to Andrew Morton for -rc2 but doesn't get it fixed :-(

Uhh... Who stripped almost all newlines from the patch?

> Hope a better welcome here for a so trivial fix:

Sure. For MUA testing send a patch to youself, the apply it.

> sbi is not used if quota is not defined. This leads to a uselessvariable after preprocessing and a build warning.
> Thanks to apply.
> Signed-off-by: Jerome Pinot <ngc891@gmail.com>
>  ------8<------diff -Naur a/fs/ext3/super.c b/fs/ext3/super.c--- a/fs/ext3/super.c	2005-09-29 00:28:16.000000000 +0000+++ b/fs/ext3/super.c	2005-09-29 02:18:22.000000000 +0000@@ -513,7 +513,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) { 	struct super_block *sb = vfs->mnt_sb;+#if defined(CONFIG_QUOTA) 	struct ext3_sb_info *sbi = EXT3_SB(sb);+#endif
>  	if (test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA) 		seq_puts(seq, ",data=journal"); ------8<------


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH][2.6.14-rc3] ext3: fix build warning if !quota

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

On Sun, Oct 02, 2005 at 01:20:25AM +0900, Jerome Pinot wrote:
> You can get it too from here:http://lkml.org/lkml/diff/2005/9/28/341/1

Applied. Awaiting you Signed-off-by line.


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors