* 2.4.2-ac calls FS truncate w/o BKL
@ 2001-03-09 15:41 Chris Mason
2001-03-09 17:28 ` Alexander Viro
0 siblings, 1 reply; 2+ messages in thread
From: Chris Mason @ 2001-03-09 15:41 UTC (permalink / raw)
To: linux-kernel, alan, viro
The added vmtruncate calls in the ac series trigger calls to the FS
truncate without the BKL held. Easy enough to fix on the reiserfs side,
but if other filesystems care we might want to change vmtruncate to grab
the lock before calling truncate (and update the Locking doc ;-)
-chris
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.4.2-ac calls FS truncate w/o BKL
2001-03-09 15:41 2.4.2-ac calls FS truncate w/o BKL Chris Mason
@ 2001-03-09 17:28 ` Alexander Viro
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Viro @ 2001-03-09 17:28 UTC (permalink / raw)
To: Chris Mason; +Cc: linux-kernel, alan
On Fri, 9 Mar 2001, Chris Mason wrote:
>
> The added vmtruncate calls in the ac series trigger calls to the FS
> truncate without the BKL held. Easy enough to fix on the reiserfs side,
> but if other filesystems care we might want to change vmtruncate to grab
> the lock before calling truncate (and update the Locking doc ;-)
Grr... Thanks for spotting - it's my fault. No, I don't think that
we should move BKL into filesystems right now. Should move it into
vmtruncate(), though...
Alan, could you put lock_kernel()/unlock_kernel() around the call of
->truncate() in vmtruncate()?
Thanks,
Al
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-03-09 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-03-09 15:41 2.4.2-ac calls FS truncate w/o BKL Chris Mason
2001-03-09 17:28 ` Alexander Viro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.