From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/4] Centralize format information
Date: Tue, 07 Jun 2016 16:33:42 +0300 [thread overview]
Message-ID: <8937629.jWhc9vlPnA@avalon> (raw)
In-Reply-To: <20160607132709.GE10110@phenom.ffwll.local>
Hi Daniel,
On Tuesday 07 Jun 2016 15:27:09 Daniel Vetter wrote:
> On Tue, Jun 07, 2016 at 02:33:10AM +0300, Laurent Pinchart wrote:
> > Hello,
> >
> > Various pieces of information about DRM formats (number of planes, color
> > depth, chroma subsampling, ...) are scattered across different helper
> > functions in the DRM core. Callers of those functions often need to access
> > more than a single parameter of the format, leading to inefficiencies due
> > to multiple lookups.
> >
> > This patch series addresses this issue by centralizing all format
> > information in a single data structure (1/4). It reimplements the
> > existing format helper functions based on that structure (3/4) and
> > converts the DRM core code to use the new structure (4/4). Two unused
> > format helper functions are removed in the process (2/4).
> >
> > The new API is also useful for drivers. I will shortly post a patch series
> > for the omapdrm driver that makes use of it.
>
> I'm still meh on this, but you could convince me if you'd extract all the
> format related stuff into drm_fourcc.c. drm_crtc is a mess, and the abi
> docs are confusing since everything is in one bag. Splitting parts out
> would be awesome.
I think we're on the same page, I had the exact same thought today. I'll work
on that.
> Other stuff I think we could split out is all the framebuffer handling,
> basic property stuff, specialized properties (for zorder, blending,
> whatever) and maybe even a few more sub-topics. But let's start somewhere.
Deal, I'll start here :-)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-07 13:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 23:33 [PATCH 0/4] Centralize format information Laurent Pinchart
2016-06-06 23:33 ` [PATCH 1/4] drm: " Laurent Pinchart
2016-06-07 9:18 ` Tomi Valkeinen
2016-06-07 11:48 ` Laurent Pinchart
2016-06-07 9:25 ` Tomi Valkeinen
2016-06-07 12:05 ` Laurent Pinchart
2016-06-07 13:20 ` Ville Syrjälä
2016-06-07 13:24 ` Laurent Pinchart
2016-06-06 23:33 ` [PATCH 2/4] drm: Remove unused drm_format_plane_(width|height) helpers Laurent Pinchart
2016-06-07 13:19 ` Ville Syrjälä
2016-06-07 13:23 ` Laurent Pinchart
2016-06-06 23:33 ` [PATCH 3/4] drm: Implement the drm_format_*() helpers as drm_format_info() wrappers Laurent Pinchart
2016-06-06 23:33 ` [PATCH 4/4] drm: Use drm_format_info() in DRM core code Laurent Pinchart
2016-06-07 13:27 ` [PATCH 0/4] Centralize format information Daniel Vetter
2016-06-07 13:33 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8937629.jWhc9vlPnA@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.