From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/4] drm: Centralize format information
Date: Tue, 7 Jun 2016 12:18:34 +0300 [thread overview]
Message-ID: <5756916A.2010301@ti.com> (raw)
In-Reply-To: <1465255994-317-2-git-send-email-laurent.pinchart@ideasonboard.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 819 bytes --]
On 07/06/16 02:33, Laurent Pinchart wrote:
> +/**
> + * struct drm_format_info - information about a DRM format
> + * @format: 4CC format identifier (DRM_FORMAT_*)
> + * @depth: color depth (number of bits per pixel excluding padding bits)
> + * @bpp: number of bits per pixel including padding
> + * @num_planes: number of color planes (1 to 3)
> + * @cpp: number of bytes per pixel (per plane)
> + * @hsub: horizontal chroma subsampling factor
> + * @vsub: vertical chroma subsampling factor
> + */
> +struct drm_format_info {
> + u32 format;
> + unsigned int depth;
> + unsigned int bpp;
> + unsigned int num_planes;
> + unsigned int cpp[3];
> + unsigned int hsub;
> + unsigned int vsub;
> +};
Any reason not to pack this a bit? All those unsigned ints would fit
easily into u8.
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-07 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 23:33 [PATCH 0/4] Centralize format information Laurent Pinchart
2016-06-06 23:33 ` [PATCH 1/4] drm: " Laurent Pinchart
2016-06-07 9:18 ` Tomi Valkeinen [this message]
2016-06-07 11:48 ` Laurent Pinchart
2016-06-07 9:25 ` Tomi Valkeinen
2016-06-07 12:05 ` Laurent Pinchart
2016-06-07 13:20 ` Ville Syrjälä
2016-06-07 13:24 ` Laurent Pinchart
2016-06-06 23:33 ` [PATCH 2/4] drm: Remove unused drm_format_plane_(width|height) helpers Laurent Pinchart
2016-06-07 13:19 ` Ville Syrjälä
2016-06-07 13:23 ` Laurent Pinchart
2016-06-06 23:33 ` [PATCH 3/4] drm: Implement the drm_format_*() helpers as drm_format_info() wrappers Laurent Pinchart
2016-06-06 23:33 ` [PATCH 4/4] drm: Use drm_format_info() in DRM core code Laurent Pinchart
2016-06-07 13:27 ` [PATCH 0/4] Centralize format information Daniel Vetter
2016-06-07 13:33 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756916A.2010301@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.