Re: [PATCH v1 6/8] configs: cyclone5: Enable SPL FAT support

[Jan Kiszka <jan.kiszka@siemens.com>]

On 25.11.25 09:13, alif.zakuan.yuslaimi@altera.com wrote:
> From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>
> 
> Enable support for FAT filesystem with SPL for CycloneV instead of raw
> mode.
> 
> Recent changes breaks CycloneV MMC boot from raw mode, and so we are taking
> this opportunity to migrate MMC boot mode to FAT as smaller OCRAM size is
> required, as well as aligning MMC boot flow with our other devices.
> 
> Fixes: 2a00d73d081a1 ("spl: mmc: Try to clean up raw-mode options")
> 
> Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>
> ---
>  configs/socfpga_cyclone5_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configs/socfpga_cyclone5_defconfig b/configs/socfpga_cyclone5_defconfig
> index 2bec82b0625..2b2435a27bb 100644
> --- a/configs/socfpga_cyclone5_defconfig
> +++ b/configs/socfpga_cyclone5_defconfig
> @@ -12,6 +12,7 @@ CONFIG_DM_RESET=y
>  CONFIG_SPL_STACK=0x0
>  CONFIG_SPL_TEXT_BASE=0xFFFF0000
>  CONFIG_TARGET_SOCFPGA_CYCLONE5_SOCDK=y
> +CONFIG_SPL_FS_FAT=y
>  CONFIG_TIMESTAMP=y
>  CONFIG_FIT=y
>  CONFIG_DISTRO_DEFAULTS=y
> @@ -27,6 +28,7 @@ CONFIG_SPL_PAD_TO=0x10000
>  CONFIG_SPL_NO_BSS_LIMIT=y
>  # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
>  CONFIG_SPL_HAVE_INIT_STACK=y
> +# CONFIG_SPL_SYS_MMCSD_RAW_MODE is not set
>  CONFIG_SPL_SPI_LOAD=y
>  CONFIG_SYS_SPI_U_BOOT_OFFS=0x40000
>  CONFIG_SYS_MAXARGS=32

But what about other boards for the cycline5? If you want to switch,
switch them all. This looks half-backed.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center