All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Tune down sink crc timeout dmesg output
@ 2014-11-19 10:18 Daniel Vetter
  2014-11-19 19:39 ` [PATCH] drm/i915: Tune down sink crc timeout dmesg shuang.he
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Vetter @ 2014-11-19 10:18 UTC (permalink / raw)
  To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter, Rodrigo Vivi

For whatever reasons this can happen. For real testcases the test will
notice the -EIO and fall over, but we also have some testcases that
just read all debugfs files. And that shouldn't cause dmesg spam.

So tune it down a bit so that we still have the information for
debugging. And change the errno so that real testcases can easily
differentiate.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84890
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 45b53ff64552..9fb2a323e0e9 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4052,8 +4052,8 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
 	} while (--attempts && (buf & DP_TEST_COUNT_MASK) == test_crc_count);
 
 	if (attempts == 0) {
-		DRM_ERROR("Panel is unable to calculate CRC after 6 vblanks\n");
-		return -EIO;
+		DRM_DEBUG_KMS("Panel is unable to calculate CRC after 6 vblanks\n");
+		return -ETIMEDOUT;
 	}
 
 	if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0)
-- 
2.1.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: Tune down sink crc timeout dmesg
  2014-11-19 10:18 [PATCH] drm/i915: Tune down sink crc timeout dmesg output Daniel Vetter
@ 2014-11-19 19:39 ` shuang.he
  0 siblings, 0 replies; 2+ messages in thread
From: shuang.he @ 2014-11-19 19:39 UTC (permalink / raw)
  To: shuang.he, intel-gfx, daniel.vetter

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                 -1              369/369              368/369
ILK                 -7              403/403              396/403
SNB                                  459/459              459/459
IVB                                  535/545              535/545
BYT                                  290/290              290/290
HSW                                  610/610              610/610
BDW                                  451/451              451/451
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
PNV  igt_gem_userptr_blits_forked-sync-normal      PASS(4, M25)      DMESG_WARN(1, M25)PASS(3, M25)
ILK  igt_kms_flip_flip-vs-absolute-wf_vblank      DMESG_WARN(3, M26)PASS(1, M37)      DMESG_WARN(1, M26)PASS(3, M26)
ILK  igt_kms_flip_flip-vs-dpms      DMESG_WARN(1, M26)PASS(3, M6M26)      DMESG_WARN(1, M26)PASS(3, M26)
ILK  igt_kms_flip_flip-vs-modeset-vs-hang-interruptible      DMESG_WARN(2, M26M37)PASS(8, M37M26)      DMESG_WARN(1, M26)PASS(3, M26)
ILK  igt_kms_flip_plain-flip      DMESG_WARN(1, M26)PASS(9, M37M26)      DMESG_WARN(1, M26)PASS(3, M26)
ILK  igt_kms_flip_wf_vblank-ts-check      DMESG_WARN(1, M26)PASS(9, M37M26)      DMESG_WARN(1, M26)PASS(3, M26)
ILK  igt_kms_flip_wf_vblank-vs-dpms      DMESG_WARN(1, M26)PASS(6, M6M26)      NSPT(1, M26)PASS(3, M26)
ILK  igt_kms_flip_wf_vblank-vs-modeset-interruptible      PASS(4, M37M26)      DMESG_WARN(1, M26)PASS(3, M26)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-19 19:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-19 10:18 [PATCH] drm/i915: Tune down sink crc timeout dmesg output Daniel Vetter
2014-11-19 19:39 ` [PATCH] drm/i915: Tune down sink crc timeout dmesg shuang.he

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.